App\Controller\TicketsController

Complexity

Total Complexity

19

Size/Duplication

Total Lines	174
Duplicated Lines	0 %

Test Coverage

Coverage

44.21%

Importance

Changes	3
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	viewOperation()	0	9	1
A	editOperation()	0	20	3
A	addOperation()	0	22	3
A	delete()	0	10	2
A	deleteOperation()	0	15	2
A	view()	0	7	1
A	add()	0	15	3
A	index()	0	6	1
A	edit()	0	17	3

<?php

Filename "TicketsController.php" doesn't match the expected filename "ticketscontroller.php"

The PHP open tag does not have a corresponding PHP close tag

This file is missing a doc comment.

Class found in ".php" file; use ".inc" extension instead

Missing file doc comment

namespace App\Controller;

use App\Controller\AppController;

Unused use statement

use Cake\I18n\Time;
use Cake\I18n\I18n;

Unused use statement

/**
 * Tickets Controller
 *
 * @property \App\Model\Table\TicketsTable $Tickets
 */

Missing @category tag in class comment

Missing @package tag in class comment

Missing @link tag in class comment

Missing @license tag in class comment

Missing @author tag in class comment

class TicketsController extends AppController {

Opening brace of a class must be on the line after the definition

    /**
     * Index method
     *
     * @return \Cake\Network\Response|null

Function return type is not void, but function has no return statement

@return doc comment specified, but function has no return statement

     */
    public function index() {

Expected 0 blank lines after opening function brace; 1 found

Opening brace should be on a new line

        $tickets = $this->paginate($this->Tickets->find('all', ['contain' => ['Tickettypes', 'Ticketstatuses']]));

        $this->set(compact('tickets'));
        $this->set('_serialize', ['tickets']);
    }

    /**
     * View method
     *
     * @param string|null $id Ticket id.

Parameter comment must be on the next line

     * @return \Cake\Network\Response|null

@return doc comment specified, but function has no return statement

Function return type is not void, but function has no return statement

Separate the @param and @return sections by a blank line.

     * @throws \Cake\Datasource\Exception\RecordNotFoundException When record not found.

@throws comment must be on the next line

Separate the @return and @throws sections by a blank line.

     */
    public function view($id = null) {

Opening brace should be on a new line

        $ticket = $this->Tickets->get($id, [
            'contain' => ['Operations', 'Tickettypes']

A comma should follow the last multiline array item. Found: ]

        ]);

        $this->set('ticket', $ticket);
        $this->set('_serialize', ['ticket']);
    }

    /**
     * Add method
     *
     * @return \Cake\Network\Response|null Redirects on successful add, renders view otherwise.
     */
    public function add() {

Opening brace should be on a new line

        $ticket = $this->Tickets->newEmptyEntity();
        if ($this->request->is('post')) {
            $ticket = $this->Tickets->patchEntity($ticket, $this->getRequest()->getData());
            if ($this->Tickets->save($ticket)) {
                $this->Flash->success(__('The ticket has been saved.'));

                return $this->redirect(['prefix' => false, 'controller' => 'Tickets', 'action' => 'index']);
            }

No blank line found after control structure

            $this->Flash->error(__('The ticket could not be saved. Please, try again.'));
        }

No blank line found after control structure

        $types = $this->Tickets->Tickettypes->find('list');

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        $statuses = $this->Tickets->Ticketstatuses->find('list');
        $this->set(compact('ticket', 'types', 'statuses'));
        $this->set('_serialize', ['ticket']);
    }

    /**
     * Edit method
     *
     * @param string|null $id Ticket id.

Parameter comment must be on the next line

     * @return \Cake\Network\Response|null Redirects on successful edit, renders view otherwise.

Separate the @param and @return sections by a blank line.

     * @throws \Cake\Network\Exception\NotFoundException When record not found.

Separate the @return and @throws sections by a blank line.

@throws comment must be on the next line

     */
    public function edit($id = null) {

Opening brace should be on a new line

        $ticket = $this->Tickets->get($id, [
            'contain' => ['Tickettypes']

A comma should follow the last multiline array item. Found: ]

        ]);
        if ($this->request->is(['patch', 'post', 'put'])) {
            $ticket = $this->Tickets->patchEntity($ticket, $this->getRequest()->getData());
            if ($this->Tickets->save($ticket)) {
                $this->Flash->success(__('The ticket has been saved.'));

                return $this->redirect(['prefix' => false, 'controller' => 'Tickets', 'action' => 'index']);
            }

No blank line found after control structure

            $this->Flash->error(__('The ticket could not be saved. Please, try again.'));
        }

No blank line found after control structure

        $tickettypes = $this->Tickets->Tickettypes->find('list');

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        $ticketstatuses = $this->Tickets->Ticketstatuses->find('list');
        $this->set(compact('ticket', 'tickettypes', 'ticketstatuses'));
        $this->set('_serialize', ['ticket']);
    }

    /**
     * Delete method
     *
     * @param string|null $id Ticket id.

Parameter comment must be on the next line

     * @return \Cake\Network\Response|null Redirects to index.

Separate the @param and @return sections by a blank line.

     * @throws \Cake\Datasource\Exception\RecordNotFoundException When record not found.

Separate the @return and @throws sections by a blank line.

@throws comment must be on the next line

     */
    public function delete($id = null) {

Opening brace should be on a new line

        $this->request->allowMethod(['post', 'delete']);
        $ticket = $this->Tickets->get($id);
        if ($this->Tickets->delete($ticket)) {
            $this->Flash->success(__('The ticket has been deleted.'));
        } else {

Expected newline after closing brace

            $this->Flash->error(__('The ticket could not be deleted. Please, try again.'));
        }

        return $this->redirect(['prefix' => false, 'controller' => 'Tickets', 'action' => 'index']);
    }

    public function addOperation($id = null) {

Missing doc comment for function addOperation()

Opening brace should be on a new line

Missing function doc comment

        $ticket = $this->Tickets->get($id, [
            'contain' => []

A comma should follow the last multiline array item. Found: ]

        ]);

        $this->loadModel('Operations');
        $newOperation = $this->Operations->newEntity();
        if ($this->request->is('post')) {
            $datetimeStart = Time::parseDateTime($this->request->data['start']);

Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space

            $datetimeEnd = Time::parseDateTime($this->request->data['end']);

Equals sign not aligned with surrounding assignments; expected 15 spaces but found 1 space

            $newOperation->ticket_id = $this->request->data['ticket_id'];

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

            $newOperation->description = $this->request->data['description'];
            $newOperation->start = $datetimeStart;

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

            $newOperation->end = $datetimeEnd;

Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space

            if ($this->Operations->save($newOperation)) {
                $this->Flash->success(__('The new operation has been saved.'));
                return $this->redirect(['prefix' => false, 'controller' => 'Tickets', 'action' => 'view', $this->request->data['ticket_id']]);
            }

No blank line found after control structure

            $this->Flash->error(__('The new operation could not be saved. Please, try again.'));
        }

No blank line found after control structure

        $newOperation->ticket_id = $id;
        $this->set('newOperation', $newOperation);
    }

    /**

Missing short description in doc comment

     * @param null $operation_id

Are you sure the doc-type for parameter $operation_id is correct as it would always require null to be passed?

Missing parameter comment

     * @return \Cake\Network\Response|null
     */
    public function editOperation($operation_id = null) {

Type hint "null" missing for $operation_id

Expected 0 blank lines after opening function brace; 1 found

Opening brace should be on a new line

        $this->loadModel('Operations');
        $operation = $this->Operations->get($operation_id, [
            'contain' => ['Tickets']

A comma should follow the last multiline array item. Found: ]

        ]);
        if ($this->request->is(['patch', 'post', 'put'])) {
            $this->request->data['start'] = Time::parseDateTime($this->request->data['start']);
            $this->request->data['end'] = Time::parseDateTime($this->request->data['end']);

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

            $operation = $this->Operations->patchEntity($operation, $this->request->data);

Equals sign not aligned with surrounding assignments; expected 20 spaces but found 1 space

            if ($this->Operations->save($operation)) {
                $this->Flash->success(__('The operation has been saved.'));

                return $this->redirect(['prefix' => false, 'controller' => 'Tickets', 'action' => 'view', $this->request->data['ticket_id']]);
            }

No blank line found after control structure

            $this->Flash->error(__('The operation could not be saved. Please, try again.'));
        }

No blank line found after control structure

        $this->set(compact('operation'));
        $this->set('_serialize', ['operation']);
    }

    public function viewOperation($id = null) {

Missing doc comment for function viewOperation()

Missing function doc comment

Expected 0 blank lines after opening function brace; 1 found

Opening brace should be on a new line

        $this->loadModel('Operations');
        $operation = $this->Operations->get($id, [
            'contain' => ['Tickets']

A comma should follow the last multiline array item. Found: ]

        ]);

        $this->set('operation', $operation);
        $this->set('_serialize', ['operation']);
    }

    public function deleteOperation($id = null) {

Missing doc comment for function deleteOperation()

Opening brace should be on a new line

Expected 0 blank lines after opening function brace; 1 found

Missing function doc comment

        $this->loadModel('Operations');
        $this->request->allowMethod(['post', 'delete']);
        $operation = $this->Operations->get($id, [
            'contain' => ['Tickets']

A comma should follow the last multiline array item. Found: ]

                ]

Array close brace not indented correctly; expected 8 spaces but found 16

        );
        if ($this->Operations->delete($operation)) {
            $this->Flash->success(__('The operation has been deleted.'));
        } else {

Expected newline after closing brace

            $this->Flash->error(__('The operation could not be deleted. Please, try again.'));
        }

        return $this->redirect(['prefix' => false, 'controller' => 'Tickets', 'action' => 'view', $operation->ticket_id]);
    }

}