ProjectNamespaceController::postTeams() - Code Metrics - Inspection of "Fixed bugs" - gitaminhq/Gitamin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#33)

by Phecho

created 2015-12-06 13:48 UTC

ProjectNamespaceController::postTeams() A

↳ Parent: ProjectNamespaceController

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	9

Duplication

Lines	14
Ratio	100 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	14
loc	14
rs	9.4286
cc	2
eloc	9
nc	2
nop	0

<?php

/*
 * This file is part of Gitamin.
 * 
 * Copyright (C) 2015-2016 The Gitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gitamin\Http\Controllers\Api;

use Gitamin\Commands\ProjectNamespace\AddProjectNamespaceCommand;
use Gitamin\Commands\ProjectNamespace\RemoveProjectNamespaceCommand;
use Gitamin\Commands\ProjectNamespace\UpdateProjectNamespaceCommand;
use Gitamin\Models\ProjectNamespace;
use GrahamCampbell\Binput\Facades\Binput;
use Illuminate\Database\QueryException;
use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Http\Request;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;

class ProjectNamespaceController extends AbstractApiController
{
    use DispatchesJobs;

    /**
     * Get all teams.
     *
     * @param \Symfony\Component\HttpFoundation\Request $request
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function getTeams(Request $request)
    {
        $teams = ProjectNamespace::paginate(Binput::get('per_page', 20));

        return $this->paginator($teams, $request);
    }

    /**
     * Get a single team.
     *
     * @param \Gitamin\Models\ProjectNamespace $team
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function getTeam(ProjectNamespace $team)
    {
        return $this->item($team);
    }

    /**
     * Create a new project team.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function postTeams()

    {
        try {
            $team = $this->dispatch(new AddProjectNamespaceCommand(

                Binput::get('name'),
                Binput::get('path'),
                Binput::get('order', 0)
            ));
        } catch (QueryException $e) {
            throw new BadRequestHttpException();
        }

        return $this->item($team);
    }

    /**
     * Update an existing team.
     *
     * @param \Gitamin\Models\ProjectNamespace $team
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function putTeam(ProjectNamespace $team)

    {
        try {
            $team = $this->dispatch(new UpdateProjectNamespaceCommand(

                $team,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                Binput::get('name'),
                Binput::get('path'),
                Binput::get('order', 0)
            ));
        } catch (QueryException $e) {
            throw new BadRequestHttpException();
        }

        return $this->item($team);
    }

    /**
     * Delete an existing team.
     *
     * @param \Gitamin\Models\ProjectNamespace $team
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function deleteTeam(ProjectNamespace $team)
    {
        $this->dispatch(new RemoveProjectNamespaceCommand($team));

        return $this->noContent();
    }
}


1		<?php
2
3		/*
4		* This file is part of Gitamin.
5		*
6		* Copyright (C) 2015-2016 The Gitamin Team
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Gitamin\Http\Controllers\Api;
13
14		use Gitamin\Commands\ProjectNamespace\AddProjectNamespaceCommand;
15		use Gitamin\Commands\ProjectNamespace\RemoveProjectNamespaceCommand;
16		use Gitamin\Commands\ProjectNamespace\UpdateProjectNamespaceCommand;
17		use Gitamin\Models\ProjectNamespace;
18		use GrahamCampbell\Binput\Facades\Binput;
19		use Illuminate\Database\QueryException;
20		use Illuminate\Foundation\Bus\DispatchesJobs;
21		use Illuminate\Http\Request;
22		use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
23
24		class ProjectNamespaceController extends AbstractApiController
25		{
26		use DispatchesJobs;
27
28		/**
29		* Get all teams.
30		*
31		* @param \Symfony\Component\HttpFoundation\Request $request
32		*
33		* @return \Illuminate\Http\JsonResponse
34		*/
35		public function getTeams(Request $request)
36		{
37		$teams = ProjectNamespace::paginate(Binput::get('per_page', 20));
38
39		return $this->paginator($teams, $request);
40		}
41
42		/**
43		* Get a single team.
44		*
45		* @param \Gitamin\Models\ProjectNamespace $team
46		*
47		* @return \Illuminate\Http\JsonResponse
48		*/
49		public function getTeam(ProjectNamespace $team)
50		{
51		return $this->item($team);
52		}
53
54		/**
55		* Create a new project team.
56		*
57		* @return \Illuminate\Http\JsonResponse
58		*/
59	View Code Duplication	public function postTeams()
		0 ignored issues – show Duplication introduced 2015-12-06 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60		{
61		try {
62		$team = $this->dispatch(new AddProjectNamespaceCommand(
		0 ignored issues – show Bug introduced 2015-12-06 13:52 UTC by Report Bug Copy Issue Report The call to `AddProjectNamespaceCommand::__construct()` misses some required arguments starting with `$description`. Loading history...
63		Binput::get('name'),
64		Binput::get('path'),
65		Binput::get('order', 0)
66		));
67		} catch (QueryException $e) {
68		throw new BadRequestHttpException();
69		}
70
71		return $this->item($team);
72		}
73
74		/**
75		* Update an existing team.
76		*
77		* @param \Gitamin\Models\ProjectNamespace $team
78		*
79		* @return \Illuminate\Http\JsonResponse
80		*/
81	View Code Duplication	public function putTeam(ProjectNamespace $team)
		0 ignored issues – show Duplication introduced 2015-12-06 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
82		{
83		try {
84		$team = $this->dispatch(new UpdateProjectNamespaceCommand(
		0 ignored issues – show Bug introduced 2015-12-06 13:52 UTC by Report Bug Copy Issue Report The call to `UpdateProjectNamespaceCommand::__construct()` misses a required argument `$description`. This check looks for function calls that miss required arguments. Loading history...
85		$team,
		0 ignored issues – show Documentation introduced 2015-12-06 13:52 UTC by Report Bug Copy Issue Report `$team` is of type `object<Gitamin\Models\ProjectNamespace>`, but the function expects a `object<Gitamin\Models\ProjectNamepsace>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
86		Binput::get('name'),
87		Binput::get('path'),
88		Binput::get('order', 0)
89		));
90		} catch (QueryException $e) {
91		throw new BadRequestHttpException();
92		}
93
94		return $this->item($team);
95		}
96
97		/**
98		* Delete an existing team.
99		*
100		* @param \Gitamin\Models\ProjectNamespace $team
101		*
102		* @return \Illuminate\Http\JsonResponse
103		*/
104		public function deleteTeam(ProjectNamespace $team)
105		{
106		$this->dispatch(new RemoveProjectNamespaceCommand($team));
107
108		return $this->noContent();
109		}
110		}
111

gitaminhq / Gitamin

Pull Request — master (#33)

ProjectNamespaceController::postTeams() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like