Completed
Pull Request — master (#89)
by Phecho
03:31
created
app/Http/Controllers/FeedController.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
     /**
72 72
      * Generates a feed of all issues.
73 73
      *
74
-     * @param \Gitamin\Models\Owner|null $owner
74
+     * @param Owner $owner
75 75
      * @param bool                       $isRss
76 76
      *
77 77
      * @return \Illuminate\Http\Response
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -76,16 +76,16 @@
 block discarded – undo
76 76
      *
77 77
      * @return \Illuminate\Http\Response
78 78
      */
79
-    private function feedAction(Owner &$owner, $isRss)
79
+    private function feedAction(Owner & $owner, $isRss)
80 80
     {
81 81
         if ($owner->exists) {
82
-            $owner->projects->map(function ($project) {
83
-                $project->issues()->visible()->orderBy('created_at', 'desc')->get()->map(function ($issue) use ($isRss) {
82
+            $owner->projects->map(function($project) {
83
+                $project->issues()->visible()->orderBy('created_at', 'desc')->get()->map(function($issue) use ($isRss) {
84 84
                     $this->feedAddItem($issue, $isRss);
85 85
                 });
86 86
             });
87 87
         } else {
88
-            Issue::visible()->orderBy('created_at', 'desc')->get()->map(function ($issue) use ($isRss) {
88
+            Issue::visible()->orderBy('created_at', 'desc')->get()->map(function($issue) use ($isRss) {
89 89
                 $this->feedAddItem($issue, $isRss);
90 90
             });
91 91
         }
Please login to merge, or discard this patch.
app/Handlers/Commands/Owner/RemoveOwnerCommandHandler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
         event(new OwnerWasRemovedEvent($owner));
31 31
 
32 32
         // Remove the owner id from all project.
33
-        $owner->projects->map(function ($project) {
33
+        $owner->projects->map(function($project) {
34 34
             $project->update(['owner_id' => 0]);
35 35
         });
36 36
 
Please login to merge, or discard this patch.
app/Models/Project.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
      */
162 162
     public static function findByPath($owner_path, $project_path, $columns = ['projects.*'])
163 163
     {
164
-        $project = static::leftJoin('owners', function ($join) {
164
+        $project = static::leftJoin('owners', function($join) {
165 165
             $join->on('projects.owner_id', '=', 'owners.id');
166 166
         })->where('projects.path', '=', $project_path)->where('owners.path', '=', $owner_path)->first($columns);
167 167
 
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
      */
216 216
     public function getTagsListAttribute()
217 217
     {
218
-        $tags = $this->tags->map(function ($tag) {
218
+        $tags = $this->tags->map(function($tag) {
219 219
             return $tag->name;
220 220
         });
221 221
 
Please login to merge, or discard this patch.
app/Presenters/CommentPresenter.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,6 @@
 block discarded – undo
11 11
 
12 12
 namespace Gitamin\Presenters;
13 13
 
14
-use Gitamin\Facades\Setting;
15 14
 use Gitamin\Presenters\Traits\TimestampsTrait;
16 15
 use GrahamCampbell\Markdown\Facades\Markdown;
17 16
 use Jenssegers\Date\Date;
Please login to merge, or discard this patch.
app/Http/Controllers/Api/CommentController.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
      * @param \Symfony\Component\HttpFoundation\Request $request
33 33
      * @param \Illuminate\Contracts\Auth\Guard          $auth
34 34
      *
35
-     * @return \Illuminate\Http\JsonResponse
35
+     * @return \Illuminate\Http\Response
36 36
      */
37 37
     public function getComments(Request $request, Guard $auth)
38 38
     {
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
      *
47 47
      * @param \Gitamin\Models\Comment $comment
48 48
      *
49
-     * @return \Illuminate\Http\JsonResponse
49
+     * @return \Illuminate\Http\Response
50 50
      */
51 51
     public function getComment(Comment $comment)
52 52
     {
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
      *
59 59
      * @param \Illuminate\Contracts\Auth\Guard $auth
60 60
      *
61
-     * @return \Illuminate\Http\JsonResponse
61
+     * @return \Illuminate\Http\Response
62 62
      */
63 63
     public function postComments(Guard $auth)
64 64
     {
@@ -80,9 +80,9 @@  discard block
 block discarded – undo
80 80
     /**
81 81
      * Update an existing comment.
82 82
      *
83
-     * @param \Gitamin\Models\Inicdent $comment
83
+     * @param Comment $comment
84 84
      *
85
-     * @return \Illuminate\Http\JsonResponse
85
+     * @return \Illuminate\Http\Response
86 86
      */
87 87
     public function putComment(Comment $comment)
88 88
     {
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      *
104 104
      * @param \Gitamin\Models\Comment $comment
105 105
      *
106
-     * @return \Illuminate\Http\JsonResponse
106
+     * @return \Illuminate\Http\Response
107 107
      */
108 108
     public function deleteComment(Comment $comment)
109 109
     {
Please login to merge, or discard this patch.
app/Handlers/Commands/Comment/UpdateCommentCommandHandler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
             'team_id'     => $command->team_id,
55 55
         ];
56 56
 
57
-        return array_filter($params, function ($val) {
57
+        return array_filter($params, function($val) {
58 58
             return $val !== null;
59 59
         });
60 60
     }
Please login to merge, or discard this patch.
app/Handlers/Events/Project/SendProjectMomentHandler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
      * @param \Gitamin\Models\Project $project
44 44
      * @param int                     $action
45 45
      */
46
-    protected function trigger(Project &$project, $action)
46
+    protected function trigger(Project & $project, $action)
47 47
     {
48 48
         $data = [
49 49
             'target_type' => 'Project',
Please login to merge, or discard this patch.
app/Presenters/MomentPresenter.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -11,13 +11,11 @@
 block discarded – undo
11 11
 
12 12
 namespace Gitamin\Presenters;
13 13
 
14
-use Gitamin\Facades\Setting;
15 14
 use Gitamin\Models\Moment;
16 15
 use Gitamin\Models\Comment;
17 16
 use Gitamin\Models\Issue;
18 17
 use Gitamin\Presenters\Traits\TimestampsTrait;
19 18
 use GrahamCampbell\Markdown\Facades\Markdown;
20
-use Jenssegers\Date\Date;
21 19
 
22 20
 class MomentPresenter extends AbstractPresenter
23 21
 {
Please login to merge, or discard this patch.
app/Http/Routes/DefaultRoutes.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -30,14 +30,14 @@  discard block
 block discarded – undo
30 30
             'middleware' => ['app.hasSetting', 'auth'],
31 31
             'setting'    => 'app_name',
32 32
             'as'         => 'dashboard.'
33
-        ], function ($router) {
33
+        ], function($router) {
34 34
             $router->get('/', [
35 35
                 'as'   => 'index',
36 36
                 'uses' => 'DashboardController@indexAction',
37 37
             ]);
38 38
         });
39 39
         //Install Area
40
-        $router->group(['middleware' => ['app.isInstalled', 'localize']], function ($router) {
40
+        $router->group(['middleware' => ['app.isInstalled', 'localize']], function($router) {
41 41
             $router->controller('install', 'InstallController');
42 42
         });
43 43
 
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
             'middleware' => ['app.hasSetting', 'guest'],
47 47
             'setting'    => 'app_name',
48 48
             'as'         => 'signup.',
49
-        ], function ($router) {
49
+        ], function($router) {
50 50
             $router->get('signup', [
51 51
                 'as'         => 'signup',
52 52
                 'uses'       => 'SignupController@getSignup',
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
             'setting'    => 'app_name',
71 71
             'prefix'     => 'explore',
72 72
             'as'         => 'explore.',
73
-        ], function ($router) {
73
+        ], function($router) {
74 74
             $router->get('/', [
75 75
                 'as'   => 'index',
76 76
                 'uses' => 'ExploreController@indexAction',
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         $router->group([
91 91
             'middleware' => 'app.hasSetting',
92 92
             'setting'    => 'app_name',
93
-        ], function ($router) {
93
+        ], function($router) {
94 94
             $router->get('/atom/{namespace?}', [
95 95
                 'as'   => 'feed.atom',
96 96
                 'uses' => 'FeedController@atomAction',
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
             'middleware' => ['app.hasSetting'],
107 107
             'setting'    => 'app_name',
108 108
             'as'         => 'profile.',
109
-        ], function ($router) {
109
+        ], function($router) {
110 110
             $router->get('profile', [
111 111
                 'as'   => 'index',
112 112
                 'uses' => 'ProfilesController@indexAction',
Please login to merge, or discard this patch.