gitaminhq /
Gitamin
| Conditions | 9 |
| Paths | 60 |
| Total Lines | 67 |
| Code Lines | 40 |
| Lines | 0 |
| Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 30 | public function index() |
||
| 31 | { |
||
| 32 | $today = Date::now(); |
||
| 33 | $startDate = Date::now(); |
||
| 34 | |||
| 35 | // Check if we have another starting date |
||
| 36 | if (Binput::has('start_date')) { |
||
| 37 | try { |
||
| 38 | // If date provided is valid |
||
| 39 | $oldDate = Date::createFromFormat('Y-m-d', Binput::get('start_date')); |
||
| 40 | |||
| 41 | // If trying to get a future date fallback to today |
||
| 42 | if ($today->gt($oldDate)) { |
||
| 43 | $startDate = $oldDate; |
||
| 44 | } |
||
| 45 | } catch (Exception $e) { |
||
| 46 | // Fallback to today |
||
| 47 | } |
||
| 48 | } |
||
| 49 | |||
| 50 | $daysToShow = Setting::get('app_issue_days', 0) - 1; |
||
| 51 | if ($daysToShow < 0) { |
||
| 52 | $daysToShow = 0; |
||
| 53 | $issueDays = []; |
||
| 54 | } else { |
||
| 55 | $issueDays = range(0, $daysToShow); |
||
| 56 | } |
||
| 57 | $dateTimeZone = Setting::get('app_timezone'); |
||
| 58 | |||
| 59 | $issueVisiblity = Auth::check() ? 0 : 1; |
||
| 60 | |||
| 61 | $allIssues = Issue::where('visible', '>=', $issueVisiblity)->whereBetween('created_at', [ |
||
| 62 | $startDate->copy()->subDays($daysToShow)->format('Y-m-d').' 00:00:00', |
||
| 63 | $startDate->format('Y-m-d').' 23:59:59', |
||
| 64 | ])->orderBy('scheduled_at', 'desc')->orderBy('created_at', 'desc')->get()->groupBy(function (Issue $issue) use ($dateTimeZone) { |
||
| 65 | // If it's scheduled, get the scheduled at date. |
||
| 66 | if ($issue->is_scheduled) { |
||
| 67 | return (new Date($issue->scheduled_at)) |
||
| 68 | ->setTimezone($dateTimeZone)->toDateString(); |
||
| 69 | } |
||
| 70 | |||
| 71 | return (new Date($issue->created_at)) |
||
| 72 | ->setTimezone($dateTimeZone)->toDateString(); |
||
| 73 | }); |
||
| 74 | |||
| 75 | // Add in days that have no issues |
||
| 76 | foreach ($issueDays as $i) { |
||
| 77 | $date = (new Date($startDate))->setTimezone($dateTimeZone)->subDays($i); |
||
| 78 | |||
| 79 | if (!isset($allIssues[$date->toDateString()])) { |
||
| 80 | $allIssues[$date->toDateString()] = []; |
||
| 81 | } |
||
| 82 | } |
||
| 83 | |||
| 84 | // Sort the array so it takes into account the added days |
||
| 85 | $allIssues = $allIssues->sortBy(function ($value, $key) { |
||
| 86 | return strtotime($key); |
||
| 87 | }, SORT_REGULAR, true)->all(); |
||
| 88 | |||
| 89 | return View::make('index') |
||
| 90 | ->withDaysToShow($daysToShow) |
||
| 91 | ->withAllIssues($allIssues) |
||
| 92 | ->withCanPageForward((bool) $today->gt($startDate)) |
||
| 93 | ->withCanPageBackward(Issue::where('created_at', '<', $startDate->format('Y-m-d'))->count() > 0) |
||
| 94 | ->withPreviousDate($startDate->copy()->subDays($daysToShow)->toDateString()) |
||
| 95 | ->withNextDate($startDate->copy()->addDays($daysToShow)->toDateString()); |
||
| 96 | } |
||
| 97 | |||
| 111 |
Loading history...
Let’s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let’s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: