Completed
Pull Request — master (#14)
by Phecho
06:39 queued 03:32
created
app/Http/Controllers/Dashboard/GroupsController.php 1 patch
Unused Use Statements   -13 removed lines patch added patch discarded remove patch
@@ -11,22 +11,9 @@
 block discarded – undo
11 11
 
12 12
 namespace Gitamin\Http\Controllers\Dashboard;
13 13
 
14
-use AltThree\Validator\ValidationException;
15
-use Gitamin\Commands\Project\AddProjectCommand;
16
-use Gitamin\Commands\Project\RemoveProjectCommand;
17
-use Gitamin\Commands\Project\UpdateProjectCommand;
18
-use Gitamin\Commands\ProjectNamespace\AddProjectNamespaceCommand;
19
-use Gitamin\Commands\ProjectNamespace\RemoveProjectNamespaceCommand;
20
-use Gitamin\Commands\ProjectNamespace\UpdateProjectNamespaceCommand;
21 14
 use Gitamin\Http\Controllers\Controller;
22
-use Gitamin\Models\Project;
23 15
 use Gitamin\Models\Group;
24
-use Gitamin\Models\Tag;
25
-use GrahamCampbell\Binput\Facades\Binput;
26
-use Illuminate\Foundation\Bus\DispatchesJobs;
27
-use Illuminate\Support\Facades\Redirect;
28 16
 use Illuminate\Support\Facades\View;
29
-use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
30 17
 
31 18
 class GroupsController extends Controller
32 19
 {
Please login to merge, or discard this patch.
app/Http/Routes/GroupsRoutes.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -52,12 +52,12 @@
 block discarded – undo
52 52
             'setting'    => 'app_name',
53 53
             'as'         => 'groups.',
54 54
         ], function ($router) {
55
-           $router->get('{namespace}', [
55
+            $router->get('{namespace}', [
56 56
                 'as'   => 'group_show',
57 57
                 'uses' => 'GroupsController@show',
58 58
             ])->where('namespace', '[a-zA-z.0-9_\-]+');
59 59
 
60
-           $router->get('{namespace}/edit', [
60
+            $router->get('{namespace}/edit', [
61 61
                 'as'   => 'group_edit',
62 62
                 'uses' => 'GroupsController@edit',
63 63
             ])->where('namespace', '[a-zA-z.0-9_\-]+');
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
             'setting'    => 'app_name',
33 33
             'prefix'     => 'projects',
34 34
             'as'         => 'projects.',
35
-        ], function ($router) {
35
+        ], function($router) {
36 36
             $router->get('/', [
37 37
                 'as'   => 'index',
38 38
                 'uses' => 'ProjectsController@index',
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
             'middleware' => ['app.hasSetting'],
55 55
             'setting'    => 'app_name',
56 56
             'as'         => 'projects.',
57
-        ], function ($router) {
57
+        ], function($router) {
58 58
            $router->get('{namespace}/{project}', [
59 59
                 'as'   => 'project_show',
60 60
                 'uses' => 'ProjectsController@show',
Please login to merge, or discard this patch.
app/Http/Routes/ProjectsRoutes.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,12 +55,12 @@
 block discarded – undo
55 55
             'setting'    => 'app_name',
56 56
             'as'         => 'projects.',
57 57
         ], function ($router) {
58
-           $router->get('{namespace}/{project}', [
58
+            $router->get('{namespace}/{project}', [
59 59
                 'as'   => 'project_show',
60 60
                 'uses' => 'ProjectsController@show',
61 61
             ])->where('namespace', '[a-zA-z.0-9_\-]+')->where('project', '[a-zA-z.0-9_\-]+');
62 62
 
63
-           $router->get('{namespace}/{project}/edit', [
63
+            $router->get('{namespace}/{project}/edit', [
64 64
                 'as'   => 'project_edit',
65 65
                 'uses' => 'ProjectsController@edit',
66 66
             ])->where('namespace', '[a-zA-z.0-9_\-]+')->where('project', '[a-zA-z.0-9_\-]+');
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
             'setting'    => 'app_name',
33 33
             'prefix'     => 'projects',
34 34
             'as'         => 'projects.',
35
-        ], function ($router) {
35
+        ], function($router) {
36 36
             $router->get('/', [
37 37
                 'as'   => 'index',
38 38
                 'uses' => 'ProjectsController@index',
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
             'middleware' => ['app.hasSetting'],
55 55
             'setting'    => 'app_name',
56 56
             'as'         => 'projects.',
57
-        ], function ($router) {
57
+        ], function($router) {
58 58
            $router->get('{namespace}/{project}', [
59 59
                 'as'   => 'project_show',
60 60
                 'uses' => 'ProjectsController@show',
Please login to merge, or discard this patch.
app/Commands/ProjectNamespace/UpdateProjectNamespaceCommand.php 1 patch
Doc Comments   -3 removed lines patch added patch discarded remove patch
@@ -52,10 +52,7 @@
 block discarded – undo
52 52
     /**
53 53
      * Create a add project team command instance.
54 54
      *
55
-     * @param \Gitamin\Models\ProjectTeam $team
56 55
      * @param string                      $name
57
-     * @param string                      $slug
58
-     * @param int                         $order
59 56
      *
60 57
      * @return void
61 58
      */
Please login to merge, or discard this patch.
Handlers/Commands/ProjectNamespace/RemoveProjectNamespaceCommandHandler.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
     /**
20 20
      * Handle the remove project team command.
21 21
      *
22
-     * @param \Gitamin\Commands\ProjectTeam\RemoveProjectTeamCommand $command
22
+     * @param RemoveProjectNamespaceCommand $command
23 23
      *
24 24
      * @return void
25 25
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,6 @@
 block discarded – undo
12 12
 namespace Gitamin\Handlers\Commands\ProjectNamespace;
13 13
 
14 14
 use Gitamin\Commands\ProjectNamespace\RemoveProjectNamespaceCommand;
15
-use Gitamin\Events\ProjectNamespace\ProjectNamespaceWasRemovedEvent;
16 15
 
17 16
 class RemoveProjectNamespaceCommandHandler
18 17
 {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
         event(new ProjectTeamWasRemovedEvent($team));
31 31
 
32 32
         // Remove the namespace id from all project.
33
-        $group->projects->map(function ($project) {
33
+        $group->projects->map(function($project) {
34 34
             $project->update(['namespace_id' => 0]);
35 35
         });
36 36
 
Please login to merge, or discard this patch.
app/Commands/Project/UpdateProjectCommand.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,6 @@
 block discarded – undo
86 86
      * @param string                  $description
87 87
      * @param int                     $visibility_level
88 88
      * @param string                  $path
89
-     * @param int                     $creator_id
90 89
      * @param int                     $namespace_id
91 90
      *
92 91
      * @return void
Please login to merge, or discard this patch.