Inspection of "Merge pull request #3 from phecho/master" - gitaminhq/Gitamin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (a062c5)

by Phecho

created 2015-11-30 08:35 UTC

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@
 block discarded – undo
     /**
      * Create a unsubscribe subscriber command instance.
      *
-     * @param string $subscriber
+     * @param Subscriber $subscriber
      *
      * @return void
      */

Please login to merge, or discard this patch.

app/Commands/Subscriber/VerifySubscriberCommand.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@
 block discarded – undo
     /**
      * Create a verify subscriber command instance.
      *
-     * @param string $subscriber
+     * @param Subscriber $subscriber
      *
      * @return void
      */

Please login to merge, or discard this patch.

app/Commands/User/InviteGroupMemberCommand.php 1 patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -32,7 +32,7 @@
 block discarded – undo
     /**
      * Create a new invite group member command instance.
      *
-     * @param array $email
+     * @param array $emails
      *
      * @return void
      */

Please login to merge, or discard this patch.

app/Handlers/Events/Issue/SendIssueEmailNotificationHandler.php 1 patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
     /**
      * Create a new send issue email notification handler.
      *
-     * @param \Illuminate\Contracts\Mail\Mailer $mailer
+     * @param MailQueue $mailer
      * @param \Gitamin\Models\Subscriber        $subscriber
      *
      * @return void
@@ -50,9 +50,9 @@  discard block
 block discarded – undo
     /**
      * Handle the event.
      *
-     * @param \Gitamin\Events\Issue\IssueHasAddedEvent $event
+     * @param IssueWasAddedEvent $event
      *
-     * @return void
+     * @return false|null
      */
     public function handle(IssueWasAddedEvent $event)
     {

Please login to merge, or discard this patch.

app/Handlers/Events/Subscriber/SendSubscriberVerificationEmailHandler.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -27,7 +27,7 @@  discard block
 block discarded – undo
     /**
      * Create a new send subscriber verification email handler.
      *
-     * @param \Illuminate\Contracts\Mail\Mailer $mailer
+     * @param MailQueue $mailer
      *
      * @return void
      */
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
     /**
      * Handle the event.
      *
-     * @param \Gitamin\Events\SubscriberHasSubscribedEvent $event
+     * @param SubscriberHasSubscribedEvent $event
      *
      * @return void
      */

Please login to merge, or discard this patch.

app/Handlers/Events/User/SendInviteUserEmailHandler.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -27,7 +27,7 @@  discard block
 block discarded – undo
     /**
      * Create a new send invite user email handler.
      *
-     * @param \Illuminate\Contracts\Mail\Mailer $mailer
+     * @param MailQueue $mailer
      *
      * @return void
      */
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
     /**
      * Handle the event.
      *
-     * @param \Gitamin\Events\UserWasInvitedEvent $event
+     * @param UserWasInvitedEvent $event
      *
      * @return void
      */

Please login to merge, or discard this patch.

app/Http/Controllers/Api/AbstractApiController.php 1 patch

Doc Comments +4 added lines, -5 removed lines patch added patch discarded remove patch

@@ -110,7 +110,7 @@  discard block
 block discarded – undo
      *
      * @param mixed
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Illuminate\Http\Response
      */
     public function item($item)
     {
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
      *
      * @param \Illuminate\Support\Collection $collection
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Illuminate\Http\Response
      */
     public function collection(Collection $collection)
     {
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
      * @param \Illuminate\Pagination\Paginator $paginator
      * @param \Illuminate\Http\Request         $request
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Illuminate\Http\Response
      */
     protected function paginator(Paginator $paginator, Request $request)
     {
@@ -173,9 +173,8 @@  discard block
 block discarded – undo
     /**
      * Respond with a no content response.
      *
-     * @param string $message
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Illuminate\Http\Response
      */
     protected function noContent()
     {

Please login to merge, or discard this patch.

app/Http/Controllers/Api/IssueController.php 1 patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -32,7 +32,7 @@  discard block
 block discarded – undo
      * @param \Symfony\Component\HttpFoundation\Request $request
      * @param \Illuminate\Contracts\Auth\Guard          $auth
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Illuminate\Http\Response
      */
     public function getIssues(Request $request, Guard $auth)
     {
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
      *
      * @param \Gitamin\Models\Issue $issue
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Illuminate\Http\Response
      */
     public function getIssue(Issue $issue)
     {
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
      *
      * @param \Illuminate\Contracts\Auth\Guard $auth
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Illuminate\Http\Response
      */
     public function postIssues(Guard $auth)
     {
@@ -85,9 +85,9 @@  discard block
 block discarded – undo
     /**
      * Update an existing issue.
      *
-     * @param \Gitamin\Models\Inicdent $issue
+     * @param Issue $issue
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Illuminate\Http\Response
      */
     public function putIssue(Issue $issue)
     {
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
      *
      * @param \Gitamin\Models\Issue $issue
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Illuminate\Http\Response
      */
     public function deleteIssue(Issue $issue)
     {

Please login to merge, or discard this patch.

app/Http/Controllers/Api/ProjectController.php 1 patch

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
      * @param \Symfony\Component\HttpFoundation\Request $request
      * @param \Illuminate\Contracts\Auth\Guard          $auth
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Illuminate\Http\Response
      */
     public function getProjects(Request $request, Guard $auth)
     {
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
      *
      * @param \Gitamin\Models\Project $project
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Illuminate\Http\Response
      */
     public function getProject(Project $project)
     {
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
     /**
      * Create a new project.
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Illuminate\Http\Response
      */
     public function postProjects()
     {
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
      *
      * @param \Gitamin\Models\Project $project
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Illuminate\Http\Response
      */
     public function putProject(Project $project)
     {
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
      *
      * @param \Gitamin\Models\Project $project
      *
-     * @return \Illuminate\Http\JsonResponse
+     * @return \Illuminate\Http\Response
      */
     public function deleteProject(Project $project)
     {

Please login to merge, or discard this patch.

		@@ -110,7 +110,7 @@ discard block
		block discarded – undo
110	110	*
111	111	* @param mixed
112	112	*
113		- * @return \Illuminate\Http\JsonResponse
	113	+ * @return \Illuminate\Http\Response
114	114	*/
115	115	public function item($item)
116	116	{
		@@ -122,7 +122,7 @@ discard block
		block discarded – undo
122	122	*
123	123	* @param \Illuminate\Support\Collection $collection
124	124	*
125		- * @return \Illuminate\Http\JsonResponse
	125	+ * @return \Illuminate\Http\Response
126	126	*/
127	127	public function collection(Collection $collection)
128	128	{
		@@ -135,7 +135,7 @@ discard block
		block discarded – undo
135	135	* @param \Illuminate\Pagination\Paginator $paginator
136	136	* @param \Illuminate\Http\Request $request
137	137	*
138		- * @return \Illuminate\Http\JsonResponse
	138	+ * @return \Illuminate\Http\Response
139	139	*/
140	140	protected function paginator(Paginator $paginator, Request $request)
141	141	{
		@@ -173,9 +173,8 @@ discard block
		block discarded – undo
173	173	/**
174	174	* Respond with a no content response.
175	175	*
176		- * @param string $message
177	176	*
178		- * @return \Illuminate\Http\JsonResponse
	177	+ * @return \Illuminate\Http\Response
179	178	*/
180	179	protected function noContent()
181	180	{

		@@ -25,7 +25,7 @@
		block discarded – undo
25	25	/**
26	26	* Create a unsubscribe subscriber command instance.
27	27	*
28		- * @param string $subscriber
	28	+ * @param Subscriber $subscriber
29	29	*
30	30	* @return void
31	31	*/

		@@ -25,7 +25,7 @@
		block discarded – undo
25	25	/**
26	26	* Create a verify subscriber command instance.
27	27	*
28		- * @param string $subscriber
	28	+ * @param Subscriber $subscriber
29	29	*
30	30	* @return void
31	31	*/

		@@ -32,7 +32,7 @@
		block discarded – undo
32	32	/**
33	33	* Create a new invite group member command instance.
34	34	*
35		- * @param array $email
	35	+ * @param array $emails
36	36	*
37	37	* @return void
38	38	*/

		@@ -36,7 +36,7 @@ discard block
		block discarded – undo
36	36	/**
37	37	* Create a new send issue email notification handler.
38	38	*
39		- * @param \Illuminate\Contracts\Mail\Mailer $mailer
	39	+ * @param MailQueue $mailer
40	40	* @param \Gitamin\Models\Subscriber $subscriber
41	41	*
42	42	* @return void
		@@ -50,9 +50,9 @@ discard block
		block discarded – undo
50	50	/**
51	51	* Handle the event.
52	52	*
53		- * @param \Gitamin\Events\Issue\IssueHasAddedEvent $event
	53	+ * @param IssueWasAddedEvent $event
54	54	*
55		- * @return void
	55	+ * @return false\|null
56	56	*/
57	57	public function handle(IssueWasAddedEvent $event)
58	58	{

		@@ -27,7 +27,7 @@ discard block
		block discarded – undo
27	27	/**
28	28	* Create a new send subscriber verification email handler.
29	29	*
30		- * @param \Illuminate\Contracts\Mail\Mailer $mailer
	30	+ * @param MailQueue $mailer
31	31	*
32	32	* @return void
33	33	*/
		@@ -39,7 +39,7 @@ discard block
		block discarded – undo
39	39	/**
40	40	* Handle the event.
41	41	*
42		- * @param \Gitamin\Events\SubscriberHasSubscribedEvent $event
	42	+ * @param SubscriberHasSubscribedEvent $event
43	43	*
44	44	* @return void
45	45	*/

		@@ -27,7 +27,7 @@ discard block
		block discarded – undo
27	27	/**
28	28	* Create a new send invite user email handler.
29	29	*
30		- * @param \Illuminate\Contracts\Mail\Mailer $mailer
	30	+ * @param MailQueue $mailer
31	31	*
32	32	* @return void
33	33	*/
		@@ -39,7 +39,7 @@ discard block
		block discarded – undo
39	39	/**
40	40	* Handle the event.
41	41	*
42		- * @param \Gitamin\Events\UserWasInvitedEvent $event
	42	+ * @param UserWasInvitedEvent $event
43	43	*
44	44	* @return void
45	45	*/

		@@ -32,7 +32,7 @@ discard block
		block discarded – undo
32	32	* @param \Symfony\Component\HttpFoundation\Request $request
33	33	* @param \Illuminate\Contracts\Auth\Guard $auth
34	34	*
35		- * @return \Illuminate\Http\JsonResponse
	35	+ * @return \Illuminate\Http\Response
36	36	*/
37	37	public function getIssues(Request $request, Guard $auth)
38	38	{
		@@ -48,7 +48,7 @@ discard block
		block discarded – undo
48	48	*
49	49	* @param \Gitamin\Models\Issue $issue
50	50	*
51		- * @return \Illuminate\Http\JsonResponse
	51	+ * @return \Illuminate\Http\Response
52	52	*/
53	53	public function getIssue(Issue $issue)
54	54	{
		@@ -60,7 +60,7 @@ discard block
		block discarded – undo
60	60	*
61	61	* @param \Illuminate\Contracts\Auth\Guard $auth
62	62	*
63		- * @return \Illuminate\Http\JsonResponse
	63	+ * @return \Illuminate\Http\Response
64	64	*/
65	65	public function postIssues(Guard $auth)
66	66	{
		@@ -85,9 +85,9 @@ discard block
		block discarded – undo
85	85	/**
86	86	* Update an existing issue.
87	87	*
88		- * @param \Gitamin\Models\Inicdent $issue
	88	+ * @param Issue $issue
89	89	*
90		- * @return \Illuminate\Http\JsonResponse
	90	+ * @return \Illuminate\Http\Response
91	91	*/
92	92	public function putIssue(Issue $issue)
93	93	{
		@@ -115,7 +115,7 @@ discard block
		block discarded – undo
115	115	*
116	116	* @param \Gitamin\Models\Issue $issue
117	117	*
118		- * @return \Illuminate\Http\JsonResponse
	118	+ * @return \Illuminate\Http\Response
119	119	*/
120	120	public function deleteIssue(Issue $issue)
121	121	{

		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33	* @param \Symfony\Component\HttpFoundation\Request $request
34	34	* @param \Illuminate\Contracts\Auth\Guard $auth
35	35	*
36		- * @return \Illuminate\Http\JsonResponse
	36	+ * @return \Illuminate\Http\Response
37	37	*/
38	38	public function getProjects(Request $request, Guard $auth)
39	39	{
		@@ -51,7 +51,7 @@ discard block
		block discarded – undo
51	51	*
52	52	* @param \Gitamin\Models\Project $project
53	53	*
54		- * @return \Illuminate\Http\JsonResponse
	54	+ * @return \Illuminate\Http\Response
55	55	*/
56	56	public function getProject(Project $project)
57	57	{
		@@ -61,7 +61,7 @@ discard block
		block discarded – undo
61	61	/**
62	62	* Create a new project.
63	63	*
64		- * @return \Illuminate\Http\JsonResponse
	64	+ * @return \Illuminate\Http\Response
65	65	*/
66	66	public function postProjects()
67	67	{
		@@ -101,7 +101,7 @@ discard block
		block discarded – undo
101	101	*
102	102	* @param \Gitamin\Models\Project $project
103	103	*
104		- * @return \Illuminate\Http\JsonResponse
	104	+ * @return \Illuminate\Http\Response
105	105	*/
106	106	public function putProject(Project $project)
107	107	{
		@@ -139,7 +139,7 @@ discard block
		block discarded – undo
139	139	*
140	140	* @param \Gitamin\Models\Project $project
141	141	*
142		- * @return \Illuminate\Http\JsonResponse
	142	+ * @return \Illuminate\Http\Response
143	143	*/
144	144	public function deleteProject(Project $project)
145	145	{

gitaminhq / Gitamin

Branch — master (a062c5)

Category

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +3 added lines, -3 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Doc Comments +4 added lines, -5 removed lines patch added patch discarded remove patch

Doc Comments +6 added lines, -6 removed lines patch added patch discarded remove patch

Doc Comments +5 added lines, -5 removed lines patch added patch discarded remove patch