AddOwnerAfterUserAddedHandler - Code Metrics - Inspection of "fix problems with signup" - gitaminhq/Gitamin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 37af5c...47524a )

by Phecho

created 2015-12-17 13:34 UTC

AddOwnerAfterUserAddedHandler A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
wmc	3
c	1
b	1
f	0
lcom	0
cbo	2
dl	0
loc	34
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	8	2
A	trigger()	0	12	1

<?php

/*
 * This file is part of Gitamin.
 *
 * Copyright (C) 2015-2016 The Gitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gitamin\Handlers\Events\Owner;

use Gitamin\Commands\Owner\AddOwnerCommand;
use Gitamin\Events\User\UserEventInterface;
use Gitamin\Events\User\UserWasAddedEvent;
use Gitamin\Models\User;
use Illuminate\Foundation\Bus\DispatchesJobs;

class AddOwnerAfterUserAddedHandler
{
    use DispatchesJobs;

    /**
     * Handle the comment updated moment.
     */
    public function handle(UserEventInterface $event)
    {
        if (! $event instanceof UserWasAddedEvent) {
            return;
        }

        $this->trigger($event->user);
    }

    /**
     * Trigger the moment.
     *
     * @param \Gitamin\Models\User $user
     */
    protected function trigger(User &$user)
    {
        $ownerData = [
            'path' => $user->username,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'name' => $user->username,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'user_id' => $user->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'type' => 'User',
            'description' => '',
        ];

        $group = $this->dispatchFromArray(AddOwnerCommand::class, $ownerData);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}


1			<?php
2
3			/*
4			* This file is part of Gitamin.
5			*
6			* Copyright (C) 2015-2016 The Gitamin Team
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Gitamin\Handlers\Events\Owner;
13
14			use Gitamin\Commands\Owner\AddOwnerCommand;
15			use Gitamin\Events\User\UserEventInterface;
16			use Gitamin\Events\User\UserWasAddedEvent;
17			use Gitamin\Models\User;
18			use Illuminate\Foundation\Bus\DispatchesJobs;
19
20			class AddOwnerAfterUserAddedHandler
21			{
22			use DispatchesJobs;
23
24			/**
25			* Handle the comment updated moment.
26			*/
27			public function handle(UserEventInterface $event)
28			{
29			if (! $event instanceof UserWasAddedEvent) {
30			return;
31			}
32
33			$this->trigger($event->user);
34			}
35
36			/**
37			* Trigger the moment.
38			*
39			* @param \Gitamin\Models\User $user
40			*/
41			protected function trigger(User &$user)
42			{
43			$ownerData = [
44			'path' => $user->username,
			0 ignored issues – show Documentation introduced 2015-12-17 13:40 UTC by Report Bug Copy Issue Report The property `username` does not exist on `object<Gitamin\Models\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
45			'name' => $user->username,
			0 ignored issues – show Documentation introduced 2015-12-17 13:40 UTC by Report Bug Copy Issue Report The property `username` does not exist on `object<Gitamin\Models\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
46			'user_id' => $user->id,
			0 ignored issues – show Documentation introduced 2015-12-17 13:40 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Gitamin\Models\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
47			'type' => 'User',
48			'description' => '',
49			];
50
51			$group = $this->dispatchFromArray(AddOwnerCommand::class, $ownerData);
			0 ignored issues – show Unused Code introduced 2015-12-17 13:40 UTC by Report Bug Copy Issue Report `$group` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
52			}
53			}
54

gitaminhq / Gitamin

Push — master ( 37af5c...47524a )

AddOwnerAfterUserAddedHandler A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like