Gitamin\Http\Controllers\DashboardController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	120
Duplicated Lines	43.33 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	2
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	showNotifications()	0	5	1
B	getIssues()	26	26	3
B	getSubscribers()	26	26	3
A	indexAction()	0	12	1

<?php

/*
 * This file is part of Gitamin.
 * 
 * Copyright (C) 2015-2016 The Gitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gitamin\Http\Controllers;

use Gitamin\Facades\Setting;
use Gitamin\Models\Issue;
use Gitamin\Models\Project;
use Gitamin\Models\Subscriber;
use Illuminate\Support\Facades\View;
use Jenssegers\Date\Date;

class DashboardController extends Controller
{
    /**
     * Start date.
     *
     * @var \Jenssegers\Date\Date
     */
    protected $startDate;

    /**
     * The timezone the system is running in.
     *
     * @var string
     */
    protected $timeZone;

    /**
     * Creates a new dashboard controller.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        $this->startDate = new Date();
        $this->dateTimeZone = Setting::get('app_timezone');

The property dateTimeZone does not seem to exist. Did you mean timeZone?

    }

    /**
     * Shows the dashboard view.
     *
     * @return \Illuminate\View\View
     */
    public function indexAction()
    {
        $projects = Project::get();
        $issues = $this->getIssues();
        $subscribers = $this->getSubscribers();

        return View::make('dashboard.index')
            ->withPageTitle(trans('dashboard.dashboard'))
            ->withProjects($projects)
            ->withIssues($issues)
            ->withSubscribers($subscribers);
    }

    /**
     * Shows the notifications view.
     *
     * @return \Illuminate\View\View
     */
    public function showNotifications()
    {
        return View::make('dashboard.notifications.index')
            ->withPageTitle(trans('dashboard.notifications.notifications').' '.trans('dashboard.dashboard'));
    }

    /**
     * Fetches all of the issues over the last 30 days.
     *
     * @return \Illuminate\Support\Collection
     */
    protected function getIssues()

This method seems to be duplicated in your project.

    {
        $allIssues = Issue::whereBetween('created_at', [
            $this->startDate->copy()->subDays(30)->format('Y-m-d').' 00:00:00',
            $this->startDate->format('Y-m-d').' 23:59:59',
        ])->orderBy('created_at', 'desc')->get()->groupBy(function (Issue $issue) {
            return (new Date($issue->created_at))

The property created_at does not exist on object<Gitamin\Models\Issue>. Since you implemented __get, maybe consider adding a @property annotation.

                ->setTimezone($this->dateTimeZone)->toDateString();

The property dateTimeZone does not seem to exist. Did you mean timeZone?

        });

        // Add in days that have no issues
        foreach (range(0, 30) as $i) {
            $date = (new Date($this->startDate))->setTimezone($this->dateTimeZone)->subDays($i);

The property dateTimeZone does not seem to exist. Did you mean timeZone?

            if (!isset($allIssues[$date->toDateString()])) {
                $allIssues[$date->toDateString()] = [];
            }
        }

        // Sort the array so it takes into account the added days
        $allIssues = $allIssues->sortBy(function ($value, $key) {
            return strtotime($key);
        }, SORT_REGULAR, false);

        return $allIssues;
    }

    /**
     * Fetches all of the subscribers over the last 30 days.
     *
     * @return \Illuminate\Support\Collection
     */
    protected function getSubscribers()

This method seems to be duplicated in your project.

    {
        $allSubscribers = Subscriber::whereBetween('created_at', [
            $this->startDate->copy()->subDays(30)->format('Y-m-d').' 00:00:00',
            $this->startDate->format('Y-m-d').' 23:59:59',
        ])->orderBy('created_at', 'desc')->get()->groupBy(function (Subscriber $issue) {
            return (new Date($issue->created_at))

The property created_at does not exist on object<Gitamin\Models\Subscriber>. Since you implemented __get, maybe consider adding a @property annotation.

                ->setTimezone($this->dateTimeZone)->toDateString();

The property dateTimeZone does not seem to exist. Did you mean timeZone?

        });

        // Add in days that have no issues
        foreach (range(0, 30) as $i) {
            $date = (new Date($this->startDate))->setTimezone($this->dateTimeZone)->subDays($i);

The property dateTimeZone does not seem to exist. Did you mean timeZone?

            if (!isset($allSubscribers[$date->toDateString()])) {
                $allSubscribers[$date->toDateString()] = [];
            }
        }

        // Sort the array so it takes into account the added days
        $allSubscribers = $allSubscribers->sortBy(function ($value, $key) {
            return strtotime($key);
        }, SORT_REGULAR, false);

        return $allSubscribers;
    }
}