ProjectController - Code Metrics - Inspection of "Cleaned up useless codes" - gitaminhq/Gitamin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#70)

by Phecho

created 2015-12-11 03:45 UTC

ProjectController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	79
Duplicated Lines	12.66 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	12
Bugs	3	Features	1

Metric	Value
wmc	3
c	12
b	3
f	1
lcom	1
cbo	2
dl	10
loc	79
rs	10

3 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	28	1
A	indexAction()	10	10	1
A	starredAction()	0	12	1

How to fix Duplicated Code

<?php

/*
 * This file is part of Gitamin.
 * 
 * Copyright (C) 2015-2016 The Gitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gitamin\Http\Controllers\Dashboard;

use AltThree\Validator\ValidationException;
use Gitamin\Commands\Project\AddProjectCommand;
use Gitamin\Commands\Project\RemoveProjectCommand;
use Gitamin\Commands\Project\UpdateProjectCommand;
use Gitamin\Models\Owner;
use Gitamin\Models\Project;
use Gitamin\Models\Tag;
use GrahamCampbell\Binput\Facades\Binput;
use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Routing\Controller;
use Illuminate\Support\Facades\Redirect;
use Illuminate\Support\Facades\View;

class ProjectController extends Controller
{
    use DispatchesJobs;

    /**
     * Array of sub-menu items.
     *
     * @var array
     */
    protected $subMenu = [];

    /**
     * Creates a new project controller instance.
     *
     * @return void

     */
    public function __construct()
    {
        $this->subMenu = [
            'yours' => [
                'title'  => trans('dashboard.projects.yours'),
                'url'    => route('dashboard.projects.index'),
                'icon'   => 'fa fa-edit',
                'active' => false,
            ],
            'starred' => [
                'title'  => trans('dashboard.projects.starred'),
                'url'    => route('dashboard.projects.starred'),
                'icon'   => 'fa fa-umbrella',
                'active' => false,
            ],
            'explore' => [
                'title'  => trans('dashboard.projects.explore'),
                'url'    => route('explore.index'),
                'icon'   => 'fa fa-eye',
                'active' => false,
            ],
        ];

        View::share([
            'sub_menu'  => $this->subMenu,
            'sub_title' => trans_choice('dashboard.projects.projects', 2),
        ]);
    }

    /**
     * Shows the projects view.
     *
     * @return \Illuminate\View\View
     */
    public function indexAction()

    {
        $projects = Project::orderBy('created_at')->get();
        $this->subMenu['yours']['active'] = true;

        return View::make('dashboard.projects.index')
            ->withPageTitle(trans_choice('dashboard.projects.projects', 2).' - '.trans('dashboard.dashboard'))
            ->withProjects($projects)
            ->withSubMenu($this->subMenu);
    }

    /**
     * Shows the starred projects view.
     *
     * @return \Illuminate\View\View
     */
    public function starredAction()
    {
        $this->subMenu['starred']['active'] = true;
        $projects = Project::orderBy('created_at')->get();

        $this->subMenu['starred']['active'] = true;

        return View::make('dashboard.projects.index')
            ->withPageTitle(trans_choice('dashboard.projects.projects', 2).' - '.trans('dashboard.dashboard'))
            ->withProjects($projects)
            ->withSubMenu($this->subMenu);
    }
}


1		<?php
2
3		/*
4		* This file is part of Gitamin.
5		*
6		* Copyright (C) 2015-2016 The Gitamin Team
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Gitamin\Http\Controllers\Dashboard;
13
14		use AltThree\Validator\ValidationException;
15		use Gitamin\Commands\Project\AddProjectCommand;
16		use Gitamin\Commands\Project\RemoveProjectCommand;
17		use Gitamin\Commands\Project\UpdateProjectCommand;
18		use Gitamin\Models\Owner;
19		use Gitamin\Models\Project;
20		use Gitamin\Models\Tag;
21		use GrahamCampbell\Binput\Facades\Binput;
22		use Illuminate\Foundation\Bus\DispatchesJobs;
23		use Illuminate\Routing\Controller;
24		use Illuminate\Support\Facades\Redirect;
25		use Illuminate\Support\Facades\View;
26
27		class ProjectController extends Controller
28		{
29		use DispatchesJobs;
30
31		/**
32		* Array of sub-menu items.
33		*
34		* @var array
35		*/
36		protected $subMenu = [];
37
38		/**
39		* Creates a new project controller instance.
40		*
41		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2015-11-30 08:43 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
42		*/
43		public function __construct()
44		{
45		$this->subMenu = [
46		'yours' => [
47		'title' => trans('dashboard.projects.yours'),
48		'url' => route('dashboard.projects.index'),
49		'icon' => 'fa fa-edit',
50		'active' => false,
51		],
52		'starred' => [
53		'title' => trans('dashboard.projects.starred'),
54		'url' => route('dashboard.projects.starred'),
55		'icon' => 'fa fa-umbrella',
56		'active' => false,
57		],
58		'explore' => [
59		'title' => trans('dashboard.projects.explore'),
60		'url' => route('explore.index'),
61		'icon' => 'fa fa-eye',
62		'active' => false,
63		],
64		];
65
66		View::share([
67		'sub_menu' => $this->subMenu,
68		'sub_title' => trans_choice('dashboard.projects.projects', 2),
69		]);
70		}
71
72		/**
73		* Shows the projects view.
74		*
75		* @return \Illuminate\View\View
76		*/
77	View Code Duplication	public function indexAction()
		0 ignored issues – show Duplication introduced 2015-11-30 08:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		{
79		$projects = Project::orderBy('created_at')->get();
80		$this->subMenu['yours']['active'] = true;
81
82		return View::make('dashboard.projects.index')
83		->withPageTitle(trans_choice('dashboard.projects.projects', 2).' - '.trans('dashboard.dashboard'))
84		->withProjects($projects)
85		->withSubMenu($this->subMenu);
86		}
87
88		/**
89		* Shows the starred projects view.
90		*
91		* @return \Illuminate\View\View
92		*/
93		public function starredAction()
94		{
95		$this->subMenu['starred']['active'] = true;
96		$projects = Project::orderBy('created_at')->get();
97
98		$this->subMenu['starred']['active'] = true;
99
100		return View::make('dashboard.projects.index')
101		->withPageTitle(trans_choice('dashboard.projects.projects', 2).' - '.trans('dashboard.dashboard'))
102		->withProjects($projects)
103		->withSubMenu($this->subMenu);
104		}
105		}
106

gitaminhq / Gitamin

Pull Request — master (#70)

ProjectController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like