SendProjectMomentHandler::trigger() - Code Metrics - Inspection of "Dev moments" - gitaminhq/Gitamin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#58)

by Phecho

created 2015-12-10 08:13 UTC

SendProjectMomentHandler::trigger() A

↳ Parent: SendProjectMomentHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	11
rs	9.4286
cc	1
eloc	8
nc	1
nop	2

<?php

/*
 * This file is part of Gitamin.
 * 
 * Copyright (C) 2015-2016 The Gitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gitamin\Handlers\Events\Project;

use Illuminate\Foundation\Bus\DispatchesJobs;
use Gitamin\Events\Project\ProjectEventInterface;
use Gitamin\Events\Project\ProjectWasAddedEvent;
use Gitamin\Events\Project\ProjectWasUpdatedEvent;
use Gitamin\Events\Project\ProjectWasRemovedEvent;
use Gitamin\Handlers\Commands\Moment\AddMomentCommandHandler;
use Gitamin\Commands\Moment\AddMomentCommand;
use Gitamin\Models\Project;
use Gitamin\Models\Moment;

class SendProjectMomentHandler
{

    use DispatchesJobs;

    /**
     * Handle the project updated moment.
     */
    public function handle(ProjectEventInterface $event)
    {
        if($event instanceof ProjectWasUpdateEvent) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $action = Moment::UPDATED;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } else if ($event instanceof ProjectWasRemovedEvent) {
            $action = Moment::CLOSED;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } else {
            $action = Moment::CREATED;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }

        $this->trigger($event->project, Moment::CREATED);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    /**
     * Trigger the moment.
     *
     * @param \Gitamin\Models\Project $project
     * @param int                     $action
     *
    */
    protected function trigger(Project &$project, $action)
    {
        $data = [
            'target_type' => 'Project',
            'target_id'   => $project->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'action'      => $action,
            'author_id'   => $project->creator_id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'project_id'  => $project->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        ];
        $moment = Moment::create($data);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}


Pull Request — master (#58)

SendProjectMomentHandler::trigger() A

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

Available Fixes

1			<?php
2
3			/*
4			* This file is part of Gitamin.
5			*
6			* Copyright (C) 2015-2016 The Gitamin Team
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Gitamin\Handlers\Events\Project;
13
14			use Illuminate\Foundation\Bus\DispatchesJobs;
15			use Gitamin\Events\Project\ProjectEventInterface;
16			use Gitamin\Events\Project\ProjectWasAddedEvent;
17			use Gitamin\Events\Project\ProjectWasUpdatedEvent;
18			use Gitamin\Events\Project\ProjectWasRemovedEvent;
19			use Gitamin\Handlers\Commands\Moment\AddMomentCommandHandler;
20			use Gitamin\Commands\Moment\AddMomentCommand;
21			use Gitamin\Models\Project;
22			use Gitamin\Models\Moment;
23
24			class SendProjectMomentHandler
25			{
26
27			use DispatchesJobs;
28
29			/**
30			* Handle the project updated moment.
31			*/
32			public function handle(ProjectEventInterface $event)
33			{
34			if($event instanceof ProjectWasUpdateEvent) {
			0 ignored issues – show Bug introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report The class `Gitamin\Handlers\Events\...t\ProjectWasUpdateEvent` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
35			$action = Moment::UPDATED;
			0 ignored issues – show Unused Code introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report `$action` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
36			} else if ($event instanceof ProjectWasRemovedEvent) {
37			$action = Moment::CLOSED;
			0 ignored issues – show Unused Code introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report `$action` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
38			} else {
39			$action = Moment::CREATED;
			0 ignored issues – show Unused Code introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report `$action` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
40			}
41
42			$this->trigger($event->project, Moment::CREATED);
			0 ignored issues – show Bug introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report Accessing `project` on the interface `Gitamin\Events\Project\ProjectEventInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
43			}
44
45			/**
46			* Trigger the moment.
47			*
48			* @param \Gitamin\Models\Project $project
49			* @param int $action
50			*
51			*/
52			protected function trigger(Project &$project, $action)
53			{
54			$data = [
55			'target_type' => 'Project',
56			'target_id' => $project->id,
			0 ignored issues – show Documentation introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Gitamin\Models\Project>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
57			'action' => $action,
58			'author_id' => $project->creator_id,
			0 ignored issues – show Documentation introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report The property `creator_id` does not exist on `object<Gitamin\Models\Project>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
59			'project_id' => $project->id,
			0 ignored issues – show Documentation introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Gitamin\Models\Project>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
60			];
61			$moment = Moment::create($data);
			0 ignored issues – show Unused Code introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report `$moment` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
62			}
63			}
64

gitaminhq / Gitamin

Pull Request — master (#58)

SendProjectMomentHandler::trigger() A

Complexity

Size

Duplication

Importance

1. Missing dependencies

2. Missing use statement

Available Fixes

Duplication Side-by-Side

Filter issues like