AddMomentCommandHandler::handle() - Code Metrics - Inspection of "Dev moments" - gitaminhq/Gitamin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#58)

by Phecho

created 2015-12-10 08:13 UTC

AddMomentCommandHandler::handle() B

↳ Parent: AddMomentCommandHandler

Complexity

Conditions	6
Paths	32

Size

Total Lines	32
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	32
rs	8.439
cc	6
eloc	16
nc	32
nop	1

<?php

/*
 * This file is part of Gitamin.
 * 
 * Copyright (C) 2015-2016 The Gitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gitamin\Handlers\Commands\Moment;

use Gitamin\Commands\Moment\AddMomentCommand;
use Gitamin\Dates\DateFactory;
//use Gitamin\Events\Moment\MomentWasAddedEvent;
use Gitamin\Models\Moment;

class AddMomentCommandHandler
{
    /**
     * The date factory instance.
     *
     * @var \Gitamin\Dates\DateFactory
     */
    protected $dates;

    /**
     * Create a new report moment command handler instance.
     *
     * @param \Gitamin\Dates\DateFactory $dates
     *
     * @return void

     */
    public function __construct(DateFactory $dates)
    {
        $this->dates = $dates;
    }

    /**
     * Handle the report moment command.
     *
     * @param \Gitamin\Commands\Moment\AddMomentCommand $command
     *
     * @return \Gitamin\Models\Moment
     */
    public function handle(AddMomentCommand $command)
    {
        $data = [
            'action'    => $command->action,
            'author_id' => $command->author_id,
        ];

        if($command->title) {
            $data['title'] = $command->title;
        }
        if($command->data) {
            $data['data'] = $command->data;
        }
        // Link with the target.
        if ($command->target_type) {
            $data['target_type'] = $command->target_type;
        }
        if ($command->target_id) {
            $data['target_id'] = $command->target_id;
        }
        // Link with the project.
        if ($command->project_id) {
            $data['project_id'] = $command->project_id;
        }

        // Create the moment
        $moment = Moment::create($data);

        //event(new MomentWasAddedEvent($moment));


        return $moment;
    }
}


1			<?php
2
3			/*
4			* This file is part of Gitamin.
5			*
6			* Copyright (C) 2015-2016 The Gitamin Team
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Gitamin\Handlers\Commands\Moment;
13
14			use Gitamin\Commands\Moment\AddMomentCommand;
15			use Gitamin\Dates\DateFactory;
16			//use Gitamin\Events\Moment\MomentWasAddedEvent;
17			use Gitamin\Models\Moment;
18
19			class AddMomentCommandHandler
20			{
21			/**
22			* The date factory instance.
23			*
24			* @var \Gitamin\Dates\DateFactory
25			*/
26			protected $dates;
27
28			/**
29			* Create a new report moment command handler instance.
30			*
31			* @param \Gitamin\Dates\DateFactory $dates
32			*
33			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
34			*/
35			public function __construct(DateFactory $dates)
36			{
37			$this->dates = $dates;
38			}
39
40			/**
41			* Handle the report moment command.
42			*
43			* @param \Gitamin\Commands\Moment\AddMomentCommand $command
44			*
45			* @return \Gitamin\Models\Moment
46			*/
47			public function handle(AddMomentCommand $command)
48			{
49			$data = [
50			'action' => $command->action,
51			'author_id' => $command->author_id,
52			];
53
54			if($command->title) {
55			$data['title'] = $command->title;
56			}
57			if($command->data) {
58			$data['data'] = $command->data;
59			}
60			// Link with the target.
61			if ($command->target_type) {
62			$data['target_type'] = $command->target_type;
63			}
64			if ($command->target_id) {
65			$data['target_id'] = $command->target_id;
66			}
67			// Link with the project.
68			if ($command->project_id) {
69			$data['project_id'] = $command->project_id;
70			}
71
72			// Create the moment
73			$moment = Moment::create($data);
74
75			//event(new MomentWasAddedEvent($moment));
			0 ignored issues – show Unused Code Comprehensibility introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
76
77			return $moment;
78			}
79			}
80

gitaminhq / Gitamin

Pull Request — master (#58)

AddMomentCommandHandler::handle() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like