ProjectsController - Code Metrics - Inspection of "Dev moments" - gitaminhq/Gitamin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#58)

by Phecho

created 2015-12-10 08:13 UTC

ProjectsController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	137
Duplicated Lines	28.47 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes	5
Bugs	2	Features	2

Metric	Value
wmc	8
c	5
b	2
f	2
lcom	0
cbo	5
dl	39
loc	137
rs	10

6 Methods

Rating	Name	Duplication	Size	Complexity
A	indexAction()	0	5	1
A	newAction()	0	7	1
B	createAction()	29	29	2
A	showAction()	0	15	1
A	editAction()	10	10	1
B	updateAction()	0	24	2

How to fix Duplicated Code

<?php

/*
 * This file is part of Gitamin.
 * 
 * Copyright (C) 2015-2016 The Gitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gitamin\Http\Controllers;

use AltThree\Validator\ValidationException;
use Gitamin\Commands\Project\AddProjectCommand;
use Gitamin\Commands\Project\UpdateProjectCommand;
use Gitamin\Models\Group;
use Gitamin\Models\Owner;
use Gitamin\Models\Project;
use Gitamin\Models\Tag;
use GrahamCampbell\Binput\Facades\Binput;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Redirect;
use Illuminate\Support\Facades\View;

class ProjectsController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function indexAction()
    {
        //
        echo 'In projects controller';
    }

    /**
     * Show the form or adding a new resource.
     *
     * return \Illuminate\Http\Response
     */
    public function newAction()
    {
        return View::make('projects.new')
            ->withPageTitle(trans('dashboard.projects.new.title').' - '.trans('dashboard.dashboard'))
            ->withGroupId('')
            ->withOwners(Owner::where('user_id', '=', Auth::user()->id)->get());
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function createAction()

    {
        //
        $projectData = Binput::get('project');
        $tags = array_pull($projectData, 'tags');

        try {
            $projectData['creator_id'] = Auth::user()->id;
            $project = $this->dispatchFromArray(AddProjectCommand::class, $projectData);
        } catch (ValidationException $e) {
            return Redirect::route('projects.new')
                ->withInput(Binput::all())
                ->withTitle(sprintf('%s %s', trans('dashboard.notifications.whoops'), trans('dashboard.projects.new.failure')))
                ->withErrors($e->getMessageBag());
        }

        // The project was added successfully, so now let's deal with the tags.
        $tags = preg_split('/ ?, ?/', $tags);

        // For every tag, do we need to create it?
        $projectTags = array_map(function ($taggable) use ($project) {
            return Tag::firstOrCreate(['name' => $taggable])->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }, $tags);

        $project->tags()->sync($projectTags);

        return Redirect::route('dashboard.projects.index')
            ->withSuccess(sprintf('%s %s', trans('dashboard.notifications.awesome'), trans('dashboard.projects.new.success')));
    }

    /**
     * Display the specified resource.
     *
     * @param string $owner
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $project_path
     *
     * @return \Illuminate\Http\Response
     */
    public function showAction($owner_path, $project_path)
    {
        $project = Project::findByPath($owner_path, $project_path);

        return View::make('projects.show')
            ->withPageTitle($project->name)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->withActiveItem('project_show')
            ->withProject($project)
            ->withRepo('')
            ->withRepository('')
            ->withCurrentBranch('master')
            ->withBranches([])
            ->withParentPath('')
            ->withFiles([]);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param string $owner_path
     * @param string $project_path
     *
     * @return \Illuminate\Http\Response
     */
    public function editAction($owner_path, $project_path)

    {
        $project = Project::findByPath($owner_path, $project_path);

        return View::make('projects.edit')
            ->withPageTitle(trans('dashboard.projects.new.title').' - '.trans('dashboard.dashboard'))
            ->withProject($project)
            ->withGroupId('')
            ->withGroups(Group::all());
    }

    /**
     * Update the specified resource in storage.
     *
     * @param string $namespace
     * @param string $project_path
     *
     * @return \Illuminate\Http\Response
     */
    public function updateAction($namespace, $project_path)

    {
        $projectData = Binput::get('project');
        $tags = array_pull($projectData, 'tags');
        $project = Project::find($projectData['id']);
        $projectData['namespace_id'] = $project->namespace_id;

        try {
            $projectData['project'] = $project;
            $projectData['creator_id'] = Auth::user()->id;
            $projectData['owner_id'] = $project->owner->id;
            $project = $this->dispatchFromArray(UpdateProjectCommand::class, $projectData);
        } catch (ValidationException $e) {
            return Redirect::route('projects.project_edit', ['namespace' => $project->namespace, 'project' => $project->path])
                ->withInput(Binput::all())
                ->withTitle(sprintf('%s %s', trans('dashboard.notifications.whoops'), trans('dashboard.projects.edit.failure')))
                ->withErrors($e->getMessageBag());
        }
        // The project was updated successfully, so now let's deal with the tags.
        $tags = preg_split('/ ?, ?/', $tags);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        return Redirect::route('projects.project_edit', ['owner' => $project->owner_path, 'project' => $project->path])
            ->withSuccess(sprintf('%s %s', trans('dashboard.notifications.awesome'), trans('dashboard.projects.edit.success')));
    }
}


1		<?php
2
3		/*
4		* This file is part of Gitamin.
5		*
6		* Copyright (C) 2015-2016 The Gitamin Team
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Gitamin\Http\Controllers;
13
14		use AltThree\Validator\ValidationException;
15		use Gitamin\Commands\Project\AddProjectCommand;
16		use Gitamin\Commands\Project\UpdateProjectCommand;
17		use Gitamin\Models\Group;
18		use Gitamin\Models\Owner;
19		use Gitamin\Models\Project;
20		use Gitamin\Models\Tag;
21		use GrahamCampbell\Binput\Facades\Binput;
22		use Illuminate\Support\Facades\Auth;
23		use Illuminate\Support\Facades\Redirect;
24		use Illuminate\Support\Facades\View;
25
26		class ProjectsController extends Controller
27		{
28		/**
29		* Display a listing of the resource.
30		*
31		* @return \Illuminate\Http\Response
32		*/
33		public function indexAction()
34		{
35		//
36		echo 'In projects controller';
37		}
38
39		/**
40		* Show the form or adding a new resource.
41		*
42		* return \Illuminate\Http\Response
43		*/
44		public function newAction()
45		{
46		return View::make('projects.new')
47		->withPageTitle(trans('dashboard.projects.new.title').' - '.trans('dashboard.dashboard'))
48		->withGroupId('')
49		->withOwners(Owner::where('user_id', '=', Auth::user()->id)->get());
50		}
51
52		/**
53		* Show the form for creating a new resource.
54		*
55		* @return \Illuminate\Http\Response
56		*/
57	View Code Duplication	public function createAction()
		0 ignored issues – show Duplication introduced 2015-12-07 07:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		{
59		//
60		$projectData = Binput::get('project');
61		$tags = array_pull($projectData, 'tags');
62
63		try {
64		$projectData['creator_id'] = Auth::user()->id;
65		$project = $this->dispatchFromArray(AddProjectCommand::class, $projectData);
66		} catch (ValidationException $e) {
67		return Redirect::route('projects.new')
68		->withInput(Binput::all())
69		->withTitle(sprintf('%s %s', trans('dashboard.notifications.whoops'), trans('dashboard.projects.new.failure')))
70		->withErrors($e->getMessageBag());
71		}
72
73		// The project was added successfully, so now let's deal with the tags.
74		$tags = preg_split('/ ?, ?/', $tags);
75
76		// For every tag, do we need to create it?
77		$projectTags = array_map(function ($taggable) use ($project) {
78		return Tag::firstOrCreate(['name' => $taggable])->id;
		0 ignored issues – show Documentation introduced 2015-12-03 14:28 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Gitamin\Models\Tag>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
79		}, $tags);
80
81		$project->tags()->sync($projectTags);
82
83		return Redirect::route('dashboard.projects.index')
84		->withSuccess(sprintf('%s %s', trans('dashboard.notifications.awesome'), trans('dashboard.projects.new.success')));
85		}
86
87		/**
88		* Display the specified resource.
89		*
90		* @param string $owner
		0 ignored issues – show Bug introduced 2015-12-08 12:36 UTC by Report Bug Copy Issue Report There is no parameter named `$owner`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
91		* @param string $project_path
92		*
93		* @return \Illuminate\Http\Response
94		*/
95		public function showAction($owner_path, $project_path)
96		{
97		$project = Project::findByPath($owner_path, $project_path);
98
99		return View::make('projects.show')
100		->withPageTitle($project->name)
		0 ignored issues – show Documentation introduced 2015-12-08 12:36 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<Gitamin\Models\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
101		->withActiveItem('project_show')
102		->withProject($project)
103		->withRepo('')
104		->withRepository('')
105		->withCurrentBranch('master')
106		->withBranches([])
107		->withParentPath('')
108		->withFiles([]);
109		}
110
111		/**
112		* Show the form for editing the specified resource.
113		*
114		* @param string $owner_path
115		* @param string $project_path
116		*
117		* @return \Illuminate\Http\Response
118		*/
119	View Code Duplication	public function editAction($owner_path, $project_path)
		0 ignored issues – show Duplication introduced 2015-12-08 12:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
120		{
121		$project = Project::findByPath($owner_path, $project_path);
122
123		return View::make('projects.edit')
124		->withPageTitle(trans('dashboard.projects.new.title').' - '.trans('dashboard.dashboard'))
125		->withProject($project)
126		->withGroupId('')
127		->withGroups(Group::all());
128		}
129
130		/**
131		* Update the specified resource in storage.
132		*
133		* @param string $namespace
134		* @param string $project_path
135		*
136		* @return \Illuminate\Http\Response
137		*/
138		public function updateAction($namespace, $project_path)
		0 ignored issues – show Unused Code introduced 2015-12-03 14:28 UTC by Report Bug Copy Issue Report The parameter `$namespace` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2015-12-03 14:28 UTC by Report Bug Copy Issue Report The parameter `$project_path` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
139		{
140		$projectData = Binput::get('project');
141		$tags = array_pull($projectData, 'tags');
142		$project = Project::find($projectData['id']);
143		$projectData['namespace_id'] = $project->namespace_id;
144
145		try {
146		$projectData['project'] = $project;
147		$projectData['creator_id'] = Auth::user()->id;
148		$projectData['owner_id'] = $project->owner->id;
149		$project = $this->dispatchFromArray(UpdateProjectCommand::class, $projectData);
150		} catch (ValidationException $e) {
151		return Redirect::route('projects.project_edit', ['namespace' => $project->namespace, 'project' => $project->path])
152		->withInput(Binput::all())
153		->withTitle(sprintf('%s %s', trans('dashboard.notifications.whoops'), trans('dashboard.projects.edit.failure')))
154		->withErrors($e->getMessageBag());
155		}
156		// The project was updated successfully, so now let's deal with the tags.
157		$tags = preg_split('/ ?, ?/', $tags);
		0 ignored issues – show Unused Code introduced 2015-12-03 14:28 UTC by Report Bug Copy Issue Report `$tags` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
158
159		return Redirect::route('projects.project_edit', ['owner' => $project->owner_path, 'project' => $project->path])
160		->withSuccess(sprintf('%s %s', trans('dashboard.notifications.awesome'), trans('dashboard.projects.edit.success')));
161		}
162		}
163

gitaminhq / Gitamin

Pull Request — master (#58)

ProjectsController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like