DashboardController::__construct() - Code Metrics - Inspection of "Added admin control panel stuff" - gitaminhq/Gitamin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#82)

by Phecho

created 2015-12-12 04:02 UTC

DashboardController::__construct() B

↳ Parent: DashboardController

Complexity

Conditions	1
Paths	1

Size

Total Lines	46
Code Lines	35

Duplication

Lines	46
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	46
loc	46
rs	8.9412
cc	1
eloc	35
nc	1
nop	0

<?php

/*
 * This file is part of Gitamin.
 * 
 * Copyright (C) 2015-2016 The Gitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gitamin\Http\Controllers\Admin;

use Gitamin\Models\Project;
use Illuminate\Routing\Controller;
use Illuminate\Support\Facades\Session;
use Illuminate\Support\Facades\View;

class DashboardController extends Controller
{
    /**
     * Creates a new settings controller instance.
     *
     * @return void

     */
    public function __construct()

    {
        $this->subMenu = [
class MyClass { }

$x = new MyClass();
$x->foo = true;
            'overview' => [
                'title'  => 'Overview',
                'url'    => route('admin.index'),
                'icon'   => 'fa fa-wrench',
                'active' => false,
            ],
            'general' => [
                'title'  => trans('admin.settings.general.general'),
                'url'    => route('admin.settings.general'),
                'icon'   => 'fa fa-gear',
                'active' => false,
            ],
            'theme' => [
                'title'  => trans('admin.settings.theme.theme'),
                'url'    => route('admin.settings.theme'),
                'icon'   => 'fa fa-list-alt',
                'active' => false,
            ],
            'stylesheet' => [
                'title'  => trans('admin.settings.stylesheet.stylesheet'),
                'url'    => route('admin.settings.stylesheet'),
                'icon'   => 'fa fa-magic',
                'active' => false,
            ],
            'localization' => [
                'title'  => trans('admin.settings.localization.localization'),
                'url'    => route('admin.settings.localization'),
                'icon'   => 'fa fa-language',
                'active' => false,
            ],
            'timezone' => [
                'title'  => trans('admin.settings.timezone.timezone'),
                'url'    => route('admin.settings.timezone'),
                'icon'   => 'fa fa-calendar',
                'active' => false,
            ],
        ];

        View::share([
            'sub_title' => trans('admin.admin'),
            'sub_menu'  => $this->subMenu,
        ]);
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function indexAction()
    {
        $this->subMenu['overview']['active'] = true;

        Session::flash('redirect_to', $this->subMenu['general']['url']);

        $projects = Project::orderBy('created_at')->get();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $projects = Project::get();
        $issues = [];
        $subscribers = [];

        return View::make('admin.index')
            ->withPageTitle(trans('admin.admin'))
            ->withProjects($projects)
            ->withIssues($issues)
            ->withSubscribers($subscribers)
            ->withSubMenu($this->subMenu);
    }
}


1		<?php
2
3		/*
4		* This file is part of Gitamin.
5		*
6		* Copyright (C) 2015-2016 The Gitamin Team
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Gitamin\Http\Controllers\Admin;
13
14		use Gitamin\Models\Project;
15		use Illuminate\Routing\Controller;
16		use Illuminate\Support\Facades\Session;
17		use Illuminate\Support\Facades\View;
18
19		class DashboardController extends Controller
20		{
21		/**
22		* Creates a new settings controller instance.
23		*
24		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2015-12-12 03:59 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
25		*/
26	View Code Duplication	public function __construct()
		0 ignored issues – show Duplication introduced 2015-12-12 03:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		{
28		$this->subMenu = [
		0 ignored issues – show Bug introduced 2015-12-12 03:59 UTC by Report Bug Copy Issue Report The property `subMenu` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29		'overview' => [
30		'title' => 'Overview',
31		'url' => route('admin.index'),
32		'icon' => 'fa fa-wrench',
33		'active' => false,
34		],
35		'general' => [
36		'title' => trans('admin.settings.general.general'),
37		'url' => route('admin.settings.general'),
38		'icon' => 'fa fa-gear',
39		'active' => false,
40		],
41		'theme' => [
42		'title' => trans('admin.settings.theme.theme'),
43		'url' => route('admin.settings.theme'),
44		'icon' => 'fa fa-list-alt',
45		'active' => false,
46		],
47		'stylesheet' => [
48		'title' => trans('admin.settings.stylesheet.stylesheet'),
49		'url' => route('admin.settings.stylesheet'),
50		'icon' => 'fa fa-magic',
51		'active' => false,
52		],
53		'localization' => [
54		'title' => trans('admin.settings.localization.localization'),
55		'url' => route('admin.settings.localization'),
56		'icon' => 'fa fa-language',
57		'active' => false,
58		],
59		'timezone' => [
60		'title' => trans('admin.settings.timezone.timezone'),
61		'url' => route('admin.settings.timezone'),
62		'icon' => 'fa fa-calendar',
63		'active' => false,
64		],
65		];
66
67		View::share([
68		'sub_title' => trans('admin.admin'),
69		'sub_menu' => $this->subMenu,
70		]);
71		}
72
73		/**
74		* Display a listing of the resource.
75		*
76		* @return \Illuminate\Http\Response
77		*/
78		public function indexAction()
79		{
80		$this->subMenu['overview']['active'] = true;
81
82		Session::flash('redirect_to', $this->subMenu['general']['url']);
83
84		$projects = Project::orderBy('created_at')->get();
		0 ignored issues – show Unused Code introduced 2015-12-12 03:59 UTC by Report Bug Copy Issue Report `$projects` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
85
86		$projects = Project::get();
87		$issues = [];
88		$subscribers = [];
89
90		return View::make('admin.index')
91		->withPageTitle(trans('admin.admin'))
92		->withProjects($projects)
93		->withIssues($issues)
94		->withSubscribers($subscribers)
95		->withSubMenu($this->subMenu);
96		}
97		}
98

gitaminhq / Gitamin

Pull Request — master (#82)

DashboardController::__construct() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like