IssuesController - Code Metrics - Inspection of "Added moments stuff" - gitaminhq/Gitamin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#63)

by Phecho

created 2015-12-10 13:44 UTC

IssuesController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	66
Duplicated Lines	72.73 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	5
Bugs	2	Features	3

Metric	Value
wmc	5
c	5
b	2
f	3
lcom	1
cbo	2
dl	48
loc	66
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	10	10	1
A	showAction()	10	10	1
A	add()	9	9	1
A	create()	19	19	2

How to fix Duplicated Code

<?php

/*
 * This file is part of Gitamin.
 * 
 * Copyright (C) 2015-2016 The Gitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gitamin\Http\Controllers\Projects;

use Gitamin\Commands\Issue\AddIssueCommand;
use Gitamin\Http\Controllers\Controller;
use Gitamin\Models\Issue;
use Gitamin\Models\Project;
use GrahamCampbell\Binput\Facades\Binput;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Redirect;
use Illuminate\Support\Facades\View;

class IssuesController extends Controller
{
    protected $active_item = 'issues';

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index($namespace, $project_path)

    {
        $project = Project::findByPath($namespace, $project_path);

        return View::make('projects.issues.index')
            ->withProject($project)
            ->withIssues($project->issues)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->withActiveItem($this->active_item)
            ->withPageTitle(sprintf('%s - %s', trans('dashboard.issues.issues'), $project->name));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function showAction($owner_path, $project_path, $issue)

    {
        $project = Project::findByPath($owner_path, $project_path);

        return View::make('projects.issues.show')
            ->withProject($project)
            ->withIssue($issue)
            ->withPageTitle(sprintf('%s - %s', trans('dashboard.issues.issues'), $project->name))
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->withActiveItem($this->active_item);
    }

    public function add($namespace, $project_path)

    {
        $project = Project::findByPath($namespace, $project_path);

        return View::make('projects.issues.add')
            ->withProject($project)
            ->withPageTitle(sprintf('%s - %s', trans('dashboard.issues.issues'), $project->name))
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->withActiveItem($this->active_item);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create($namespace, $project_path)

    {
        $project = Project::findByPath($namespace, $project_path);
        $issueData = Binput::get('issue');

        try {
            $issueData['author_id'] = Auth::user()->id;
            $issueData['project_id'] = $project->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $issue = $this->dispatchFromArray(AddIssueCommand::class, $issueData);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (ValidationException $e) {

            return Redirect::route('projects.issue_new')
                ->withInput(Binput::all())
                ->withTitle(sprintf('%s %s', trans('dashboard.notifications.whoops'), trans('dashboard.issues.new.failure')))
                ->withErrors($e->getMessageBag());
        }

        return Redirect::route('projects.issue_index', ['namespace' => $namespace, 'project' => $project_path])
            ->withSuccess(sprintf('%s %s', trans('dashboard.notifications.awesome'), trans('dashboard.issues.new.success')));
    }
}


1		<?php
2
3		/*
4		* This file is part of Gitamin.
5		*
6		* Copyright (C) 2015-2016 The Gitamin Team
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Gitamin\Http\Controllers\Projects;
13
14		use Gitamin\Commands\Issue\AddIssueCommand;
15		use Gitamin\Http\Controllers\Controller;
16		use Gitamin\Models\Issue;
17		use Gitamin\Models\Project;
18		use GrahamCampbell\Binput\Facades\Binput;
19		use Illuminate\Support\Facades\Auth;
20		use Illuminate\Support\Facades\Redirect;
21		use Illuminate\Support\Facades\View;
22
23		class IssuesController extends Controller
24		{
25		protected $active_item = 'issues';
26
27		/**
28		* Display a listing of the resource.
29		*
30		* @return \Illuminate\Http\Response
31		*/
32	View Code Duplication	public function index($namespace, $project_path)
		0 ignored issues – show Duplication introduced 2015-12-07 07:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34		$project = Project::findByPath($namespace, $project_path);
35
36		return View::make('projects.issues.index')
37		->withProject($project)
38		->withIssues($project->issues)
		0 ignored issues – show Documentation introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report The property `issues` does not exist on `object<Gitamin\Models\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
39		->withActiveItem($this->active_item)
40		->withPageTitle(sprintf('%s - %s', trans('dashboard.issues.issues'), $project->name));
		0 ignored issues – show Documentation introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<Gitamin\Models\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
41		}
42
43	View Code Duplication	public function showAction($owner_path, $project_path, $issue)
		0 ignored issues – show Duplication introduced 2015-12-10 13:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		{
45		$project = Project::findByPath($owner_path, $project_path);
46
47		return View::make('projects.issues.show')
48		->withProject($project)
49		->withIssue($issue)
50		->withPageTitle(sprintf('%s - %s', trans('dashboard.issues.issues'), $project->name))
		0 ignored issues – show Documentation introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<Gitamin\Models\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
51		->withActiveItem($this->active_item);
52		}
53
54	View Code Duplication	public function add($namespace, $project_path)
		0 ignored issues – show Duplication introduced 2015-12-07 07:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		{
56		$project = Project::findByPath($namespace, $project_path);
57
58		return View::make('projects.issues.add')
59		->withProject($project)
60		->withPageTitle(sprintf('%s - %s', trans('dashboard.issues.issues'), $project->name))
		0 ignored issues – show Documentation introduced 2015-12-10 13:48 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<Gitamin\Models\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
61		->withActiveItem($this->active_item);
62		}
63
64		/**
65		* Show the form for creating a new resource.
66		*
67		* @return \Illuminate\Http\Response
68		*/
69	View Code Duplication	public function create($namespace, $project_path)
		0 ignored issues – show Duplication introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70		{
71		$project = Project::findByPath($namespace, $project_path);
72		$issueData = Binput::get('issue');
73
74		try {
75		$issueData['author_id'] = Auth::user()->id;
76		$issueData['project_id'] = $project->id;
		0 ignored issues – show Documentation introduced 2015-12-10 08:16 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Gitamin\Models\User>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
77		$issue = $this->dispatchFromArray(AddIssueCommand::class, $issueData);
		0 ignored issues – show Unused Code introduced 2015-12-04 08:30 UTC by Report Bug Copy Issue Report `$issue` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
78		} catch (ValidationException $e) {
		0 ignored issues – show Bug introduced 2015-12-04 08:30 UTC by Report Bug Copy Issue Report The class `Gitamin\Http\Controllers...cts\ValidationException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
79		return Redirect::route('projects.issue_new')
80		->withInput(Binput::all())
81		->withTitle(sprintf('%s %s', trans('dashboard.notifications.whoops'), trans('dashboard.issues.new.failure')))
82		->withErrors($e->getMessageBag());
83		}
84
85		return Redirect::route('projects.issue_index', ['namespace' => $namespace, 'project' => $project_path])
86		->withSuccess(sprintf('%s %s', trans('dashboard.notifications.awesome'), trans('dashboard.issues.new.success')));
87		}
88		}
89

gitaminhq / Gitamin

Pull Request — master (#63)

IssuesController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like