ApiAuthenticate::handle() - Code Metrics - gitaminhq/Gitamin - Measure and Improve Code Quality continuously with Scrutinizer

ApiAuthenticate::handle() B
last analyzed 2015-12-17 14:45 UTC

↳ Parent: ApiAuthenticate

Complexity

Conditions	6
Paths	6

Size

Total Lines	20
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	20
rs	8.8571
cc	6
eloc	13
nc	6
nop	2

<?php

/*
 * This file is part of Gitamin.
 *
 * Copyright (C) 2015-2016 The Gitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gitamin\Http\Middleware;

use Closure;
use Gitamin\Models\User;
use Illuminate\Contracts\Auth\Guard;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Symfony\Component\HttpKernel\Exception\HttpException;

class ApiAuthenticate
{
    /**
     * The authentication guard instance.
     *
     * @var \Illuminate\Contracts\Auth\Guard
     */
    protected $auth;

    /**
     * Create a new api authenticate middleware instance.
     *
     * @param \Illuminate\Contracts\Auth\Guard $auth
     */
    public function __construct(Guard $auth)
    {
        $this->auth = $auth;
    }

    /**
     * Handle an incoming request.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure                 $next
     *
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        if ($this->auth->guest()) {
            if ($apiToken = $request->header('X-Gitamin-Token')) {
                try {
                    $this->auth->onceUsingId(User::findByApiToken($apiToken)->id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                } catch (ModelNotFoundException $e) {
                    throw new HttpException(401);
                }
            } elseif ($request->getUser()) {
                if ($this->auth->onceBasic() !== null) {
                    throw new HttpException(401);
                }
            } else {
                throw new HttpException(401);
            }
        }

        return $next($request);
    }
}


1			<?php
2
3			/*
4			* This file is part of Gitamin.
5			*
6			* Copyright (C) 2015-2016 The Gitamin Team
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Gitamin\Http\Middleware;
13
14			use Closure;
15			use Gitamin\Models\User;
16			use Illuminate\Contracts\Auth\Guard;
17			use Illuminate\Database\Eloquent\ModelNotFoundException;
18			use Symfony\Component\HttpKernel\Exception\HttpException;
19
20			class ApiAuthenticate
21			{
22			/**
23			* The authentication guard instance.
24			*
25			* @var \Illuminate\Contracts\Auth\Guard
26			*/
27			protected $auth;
28
29			/**
30			* Create a new api authenticate middleware instance.
31			*
32			* @param \Illuminate\Contracts\Auth\Guard $auth
33			*/
34			public function __construct(Guard $auth)
35			{
36			$this->auth = $auth;
37			}
38
39			/**
40			* Handle an incoming request.
41			*
42			* @param \Illuminate\Http\Request $request
43			* @param \Closure $next
44			*
45			* @return mixed
46			*/
47			public function handle($request, Closure $next)
48			{
49			if ($this->auth->guest()) {
50			if ($apiToken = $request->header('X-Gitamin-Token')) {
51			try {
52			$this->auth->onceUsingId(User::findByApiToken($apiToken)->id);
			0 ignored issues – show Documentation introduced 2015-11-30 08:43 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Gitamin\Models\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2015-12-13 12:17 UTC by Report Bug Copy Issue Report It seems like `$apiToken` defined by `$request->header('X-Gitamin-Token')` on line `50` can also be of type `array`; however, `Gitamin\Models\User::findByApiToken()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
53			} catch (ModelNotFoundException $e) {
54			throw new HttpException(401);
55			}
56			} elseif ($request->getUser()) {
57			if ($this->auth->onceBasic() !== null) {
58			throw new HttpException(401);
59			}
60			} else {
61			throw new HttpException(401);
62			}
63			}
64
65			return $next($request);
66			}
67			}
68

gitaminhq / Gitamin

ApiAuthenticate::handle() B last analyzed 2015-12-17 14:45 UTC

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like

ApiAuthenticate::handle() B
last analyzed 2015-12-17 14:45 UTC