DashboardController - Code Metrics - gitaminhq/Gitamin - Measure and Improve Code Quality continuously with Scrutinizer

DashboardController A
last analyzed 2015-12-17 14:45 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	118
Duplicated Lines	44.07 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
wmc	9
c	2
b	0
f	2
lcom	1
cbo	2
dl	52
loc	118
rs	10

5 Methods

Rating	Name	Duplication	Size	Complexity
A	indexAction()	0	12	1
A	__construct()	0	5	1
A	showNotifications()	0	5	1
B	getIssues()	26	26	3
B	getSubscribers()	26	26	3

How to fix Duplicated Code

<?php

/*
 * This file is part of Gitamin.
 *
 * Copyright (C) 2015-2016 The Gitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gitamin\Http\Controllers;

use Gitamin\Facades\Setting;
use Gitamin\Models\Issue;
use Gitamin\Models\Project;
use Gitamin\Models\Subscriber;
use Illuminate\Support\Facades\View;
use Jenssegers\Date\Date;

class DashboardController extends Controller
{
    /**
     * Start date.
     *
     * @var \Jenssegers\Date\Date
     */
    protected $startDate;

    /**
     * The timezone the system is running in.
     *
     * @var string
     */
    protected $timeZone;

    /**
     * Creates a new dashboard controller.
     */
    public function __construct()
    {
        $this->startDate = new Date();
        $this->dateTimeZone = Setting::get('app_timezone');

    }

    /**
     * Shows the dashboard view.
     *
     * @return \Illuminate\View\View
     */
    public function indexAction()
    {
        $projects = Project::get();
        $issues = $this->getIssues();
        $subscribers = $this->getSubscribers();

        return View::make('dashboard.index')
            ->withPageTitle(trans('dashboard.dashboard'))
            ->withProjects($projects)
            ->withIssues($issues)
            ->withSubscribers($subscribers);
    }

    /**
     * Shows the notifications view.
     *
     * @return \Illuminate\View\View
     */
    public function showNotifications()
    {
        return View::make('dashboard.notifications.index')
            ->withPageTitle(trans('dashboard.notifications.notifications').' '.trans('dashboard.dashboard'));
    }

    /**
     * Fetches all of the issues over the last 30 days.
     *
     * @return \Illuminate\Support\Collection
     */
    protected function getIssues()

    {
        $allIssues = Issue::whereBetween('created_at', [
            $this->startDate->copy()->subDays(30)->format('Y-m-d').' 00:00:00',
            $this->startDate->format('Y-m-d').' 23:59:59',
        ])->orderBy('created_at', 'desc')->get()->groupBy(function (Issue $issue) {
            return (new Date($issue->created_at))
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                ->setTimezone($this->dateTimeZone)->toDateString();

        });

        // Add in days that have no issues
        foreach (range(0, 30) as $i) {
            $date = (new Date($this->startDate))->setTimezone($this->dateTimeZone)->subDays($i);


            if (! isset($allIssues[$date->toDateString()])) {
                $allIssues[$date->toDateString()] = [];
            }
        }

        // Sort the array so it takes into account the added days
        $allIssues = $allIssues->sortBy(function ($value, $key) {
            return strtotime($key);
        }, SORT_REGULAR, false);

        return $allIssues;
    }

    /**
     * Fetches all of the subscribers over the last 30 days.
     *
     * @return \Illuminate\Support\Collection
     */
    protected function getSubscribers()

    {
        $allSubscribers = Subscriber::whereBetween('created_at', [
            $this->startDate->copy()->subDays(30)->format('Y-m-d').' 00:00:00',
            $this->startDate->format('Y-m-d').' 23:59:59',
        ])->orderBy('created_at', 'desc')->get()->groupBy(function (Subscriber $issue) {
            return (new Date($issue->created_at))
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                ->setTimezone($this->dateTimeZone)->toDateString();

        });

        // Add in days that have no issues
        foreach (range(0, 30) as $i) {
            $date = (new Date($this->startDate))->setTimezone($this->dateTimeZone)->subDays($i);


            if (! isset($allSubscribers[$date->toDateString()])) {
                $allSubscribers[$date->toDateString()] = [];
            }
        }

        // Sort the array so it takes into account the added days
        $allSubscribers = $allSubscribers->sortBy(function ($value, $key) {
            return strtotime($key);
        }, SORT_REGULAR, false);

        return $allSubscribers;
    }
}


1		<?php
2
3		/*
4		* This file is part of Gitamin.
5		*
6		* Copyright (C) 2015-2016 The Gitamin Team
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Gitamin\Http\Controllers;
13
14		use Gitamin\Facades\Setting;
15		use Gitamin\Models\Issue;
16		use Gitamin\Models\Project;
17		use Gitamin\Models\Subscriber;
18		use Illuminate\Support\Facades\View;
19		use Jenssegers\Date\Date;
20
21		class DashboardController extends Controller
22		{
23		/**
24		* Start date.
25		*
26		* @var \Jenssegers\Date\Date
27		*/
28		protected $startDate;
29
30		/**
31		* The timezone the system is running in.
32		*
33		* @var string
34		*/
35		protected $timeZone;
36
37		/**
38		* Creates a new dashboard controller.
39		*/
40		public function __construct()
41		{
42		$this->startDate = new Date();
43		$this->dateTimeZone = Setting::get('app_timezone');
		0 ignored issues – show Bug introduced 2015-12-02 13:46 UTC by Report Bug Copy Issue Report The property `dateTimeZone` does not seem to exist. Did you mean `timeZone`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
44		}
45
46		/**
47		* Shows the dashboard view.
48		*
49		* @return \Illuminate\View\View
50		*/
51		public function indexAction()
52		{
53		$projects = Project::get();
54		$issues = $this->getIssues();
55		$subscribers = $this->getSubscribers();
56
57		return View::make('dashboard.index')
58		->withPageTitle(trans('dashboard.dashboard'))
59		->withProjects($projects)
60		->withIssues($issues)
61		->withSubscribers($subscribers);
62		}
63
64		/**
65		* Shows the notifications view.
66		*
67		* @return \Illuminate\View\View
68		*/
69		public function showNotifications()
70		{
71		return View::make('dashboard.notifications.index')
72		->withPageTitle(trans('dashboard.notifications.notifications').' '.trans('dashboard.dashboard'));
73		}
74
75		/**
76		* Fetches all of the issues over the last 30 days.
77		*
78		* @return \Illuminate\Support\Collection
79		*/
80	View Code Duplication	protected function getIssues()
		0 ignored issues – show Duplication introduced 2015-12-02 13:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
81		{
82		$allIssues = Issue::whereBetween('created_at', [
83		$this->startDate->copy()->subDays(30)->format('Y-m-d').' 00:00:00',
84		$this->startDate->format('Y-m-d').' 23:59:59',
85		])->orderBy('created_at', 'desc')->get()->groupBy(function (Issue $issue) {
86		return (new Date($issue->created_at))
		0 ignored issues – show Documentation introduced 2015-12-02 13:46 UTC by Report Bug Copy Issue Report The property `created_at` does not exist on `object<Gitamin\Models\Issue>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
87		->setTimezone($this->dateTimeZone)->toDateString();
		0 ignored issues – show Bug introduced 2015-12-13 12:17 UTC by Report Bug Copy Issue Report The property `dateTimeZone` does not seem to exist. Did you mean `timeZone`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
88		});
89
90		// Add in days that have no issues
91		foreach (range(0, 30) as $i) {
92		$date = (new Date($this->startDate))->setTimezone($this->dateTimeZone)->subDays($i);
		0 ignored issues – show Bug introduced 2015-12-02 13:46 UTC by Report Bug Copy Issue Report The property `dateTimeZone` does not seem to exist. Did you mean `timeZone`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
93
94		if (! isset($allIssues[$date->toDateString()])) {
95		$allIssues[$date->toDateString()] = [];
96		}
97		}
98
99		// Sort the array so it takes into account the added days
100		$allIssues = $allIssues->sortBy(function ($value, $key) {
101		return strtotime($key);
102		}, SORT_REGULAR, false);
103
104		return $allIssues;
105		}
106
107		/**
108		* Fetches all of the subscribers over the last 30 days.
109		*
110		* @return \Illuminate\Support\Collection
111		*/
112	View Code Duplication	protected function getSubscribers()
		0 ignored issues – show Duplication introduced 2015-12-02 13:46 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
113		{
114		$allSubscribers = Subscriber::whereBetween('created_at', [
115		$this->startDate->copy()->subDays(30)->format('Y-m-d').' 00:00:00',
116		$this->startDate->format('Y-m-d').' 23:59:59',
117		])->orderBy('created_at', 'desc')->get()->groupBy(function (Subscriber $issue) {
118		return (new Date($issue->created_at))
		0 ignored issues – show Documentation introduced 2015-12-02 13:46 UTC by Report Bug Copy Issue Report The property `created_at` does not exist on `object<Gitamin\Models\Subscriber>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
119		->setTimezone($this->dateTimeZone)->toDateString();
		0 ignored issues – show Bug introduced 2015-12-13 12:17 UTC by Report Bug Copy Issue Report The property `dateTimeZone` does not seem to exist. Did you mean `timeZone`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
120		});
121
122		// Add in days that have no issues
123		foreach (range(0, 30) as $i) {
124		$date = (new Date($this->startDate))->setTimezone($this->dateTimeZone)->subDays($i);
		0 ignored issues – show Bug introduced 2015-12-02 13:46 UTC by Report Bug Copy Issue Report The property `dateTimeZone` does not seem to exist. Did you mean `timeZone`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
125
126		if (! isset($allSubscribers[$date->toDateString()])) {
127		$allSubscribers[$date->toDateString()] = [];
128		}
129		}
130
131		// Sort the array so it takes into account the added days
132		$allSubscribers = $allSubscribers->sortBy(function ($value, $key) {
133		return strtotime($key);
134		}, SORT_REGULAR, false);
135
136		return $allSubscribers;
137		}
138		}
139

gitaminhq / Gitamin

DashboardController A last analyzed 2015-12-17 14:45 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

DashboardController A
last analyzed 2015-12-17 14:45 UTC