Gitamin\Http\Controllers\Api\CommentController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	90
Duplicated Lines	14.44 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	4
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getComments()	0	6	1
A	getComment()	0	4	1
A	putComment()	13	13	2
A	deleteComment()	0	6	1
A	postComments()	0	16	2

<?php

/*
 * This file is part of Gitamin.
 *
 * Copyright (C) 2015-2016 The Gitamin Team
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Gitamin\Http\Controllers\Api;

use Gitamin\Commands\Comment\AddCommentCommand;
use Gitamin\Commands\Comment\RemoveCommentCommand;
use Gitamin\Commands\Comment\UpdateCommentCommand;
use Gitamin\Models\Comment;
use Illuminate\Contracts\Auth\Guard;
use Illuminate\Database\QueryException;
use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Http\Request;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;

class CommentController extends AbstractApiController
{
    use DispatchesJobs;

    /**
     * Get all comments.
     *
     * @param \Symfony\Component\HttpFoundation\Request $request
     * @param \Illuminate\Contracts\Auth\Guard          $auth
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function getComments(Request $request, Guard $auth)

The parameter $auth is not used and could be removed.

    {
        $comments = Comment::paginate($request->input('per_page', 20));

        return $this->paginator($comments, $request);
    }

    /**
     * Get a single comment.
     *
     * @param \Gitamin\Models\Comment $comment
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function getComment(Comment $comment)
    {
        return $this->item($comment);
    }

    /**
     * Create a new comment.
     *
     * @param \Illuminate\Contracts\Auth\Guard $auth
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function postComments(Request $request, Guard $auth)

The parameter $auth is not used and could be removed.

    {
        try {
            $comment = $this->dispatch(new AddCommentCommand(
                $request->input('message'),

It seems like $request->input('message') targeting Illuminate\Http\Request::input() can also be of type array; however, Gitamin\Commands\Comment\AddCommentCommand::__construct() does only seem to accept string, maybe add an additional type check?

                $request->input('target_type'),

It seems like $request->input('target_type') targeting Illuminate\Http\Request::input() can also be of type array; however, Gitamin\Commands\Comment\AddCommentCommand::__construct() does only seem to accept string, maybe add an additional type check?

                $request->input('target_id'),

$request->input('target_id') is of type string|array, but the function expects a integer.

                $request->input('author_id'),

$request->input('author_id') is of type string|array, but the function expects a integer.

                $request->input('project_id')

$request->input('project_id') is of type string|array, but the function expects a integer.

            ));
        } catch (QueryException $e) {
            throw new BadRequestHttpException();
        }

        return $this->item($comment);
    }

    /**
     * Update an existing comment.
     *
     * @param \Gitamin\Models\Inicdent $comment
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function putComment(Request $request, Comment $comment)

This method seems to be duplicated in your project.

    {
        try {
            $comment = $this->dispatch(new UpdateCommentCommand(
                $comment,
                $request->input('message')

It seems like $request->input('message') targeting Illuminate\Http\Request::input() can also be of type array; however, Gitamin\Commands\Comment\UpdateCommentCommand::__construct() does only seem to accept string, maybe add an additional type check?

            ));
        } catch (QueryException $e) {
            throw new BadRequestHttpException();
        }

        return $this->item($comment);
    }

    /**
     * Delete an existing comment.
     *
     * @param \Gitamin\Models\Comment $comment
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function deleteComment(Comment $comment)
    {
        $this->dispatch(new RemoveCommentCommand($comment));

        return $this->noContent();
    }
}