gitaminhq /
Gitamin
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 16 | View Code Duplication | final class UpdateOwnerCommand |
|
|
|
|||
| 17 | { |
||
| 18 | /** |
||
| 19 | * The project owner instance. |
||
| 20 | * |
||
| 21 | * @var \Gitamin\Models\Owner |
||
| 22 | */ |
||
| 23 | public $owner; |
||
| 24 | |||
| 25 | /** |
||
| 26 | * The project owner name. |
||
| 27 | * |
||
| 28 | * @var string |
||
| 29 | */ |
||
| 30 | public $name; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * The project owner path. |
||
| 34 | * |
||
| 35 | * @var string |
||
| 36 | */ |
||
| 37 | public $path; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * The project owner user_id. |
||
| 41 | * |
||
| 42 | * @var int |
||
| 43 | */ |
||
| 44 | public $user_id; |
||
| 45 | |||
| 46 | /** |
||
| 47 | * The project owner description. |
||
| 48 | * |
||
| 49 | * @var string |
||
| 50 | */ |
||
| 51 | public $description; |
||
| 52 | |||
| 53 | /** |
||
| 54 | * The validation rules. |
||
| 55 | * |
||
| 56 | * @var string[] |
||
| 57 | */ |
||
| 58 | public $rules = [ |
||
| 59 | 'name' => 'string', |
||
| 60 | 'path' => 'string', |
||
| 61 | 'user_id' => 'int', |
||
| 62 | 'description' => 'string', |
||
| 63 | ]; |
||
| 64 | |||
| 65 | /** |
||
| 66 | * Create an add project owner command instance. |
||
| 67 | * |
||
| 68 | * @param \Gitamin\Models\ProjectNamepsace $owner |
||
| 69 | * @param string $name |
||
| 70 | * @param string $path |
||
| 71 | * @param int $user_id |
||
| 72 | * @param string $description |
||
| 73 | */ |
||
| 74 | public function __construct($owner, $name, $path, $user_id, $description) |
||
| 82 | } |
||
| 83 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.