gitaminhq /
Gitamin
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 16 | View Code Duplication | final class UpdateIssueCommand |
|
|
|
|||
| 17 | { |
||
| 18 | /** |
||
| 19 | * The issue to update. |
||
| 20 | * |
||
| 21 | * @var \Gitamin\Models\Issue |
||
| 22 | */ |
||
| 23 | public $issue; |
||
| 24 | |||
| 25 | /** |
||
| 26 | * The issue title. |
||
| 27 | * |
||
| 28 | * @var string |
||
| 29 | */ |
||
| 30 | public $title; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * The issue description. |
||
| 34 | * |
||
| 35 | * @var string |
||
| 36 | */ |
||
| 37 | public $description; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * The issue author. |
||
| 41 | * |
||
| 42 | * @var int |
||
| 43 | */ |
||
| 44 | public $author_id; |
||
| 45 | |||
| 46 | /** |
||
| 47 | * The issue project. |
||
| 48 | * |
||
| 49 | * @var int |
||
| 50 | */ |
||
| 51 | public $project_id; |
||
| 52 | |||
| 53 | /** |
||
| 54 | * The validation rules. |
||
| 55 | * |
||
| 56 | * @var string[] |
||
| 57 | */ |
||
| 58 | public $rules = [ |
||
| 59 | 'title' => 'string', |
||
| 60 | 'description' => 'string', |
||
| 61 | 'author_id' => 'int', |
||
| 62 | 'project_id' => 'int', |
||
| 63 | ]; |
||
| 64 | |||
| 65 | /** |
||
| 66 | * Create a new update issue command instance. |
||
| 67 | * |
||
| 68 | * @param \Gitamin\Models\Issue $issue |
||
| 69 | * @param string $title |
||
| 70 | * @param string $description |
||
| 71 | * @param int $author_id |
||
| 72 | * @param int $project_id |
||
| 73 | */ |
||
| 74 | public function __construct(Issue $issue, $title, $description, $author_id, $project_id) |
||
| 82 | } |
||
| 83 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.