Hab\MeModule\Fetch2::fetch()

Complexity

Conditions	5
Paths	5

Size

Total Lines	30
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	25
CRAP Score	5

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function fetch(String $method, String $url, Array $params = [], Array $data = [])

The parameter $params is not used and could be removed.

    {
        $curl = curl_init();
        $url = str_replace(array_keys($this->sweChars), $this->sweChars, $url);;
        switch ($method) {
            case "GET":
                break;
            case "POST":
                curl_setopt($curl, CURLOPT_POSTFIELDS, $data);

It seems like $curl can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

                curl_setopt($curl, CURLOPT_POST, true);
                break;    
            case "PUT":
                curl_setopt($curl, CURLOPT_POSTFIELDS, $data);
                curl_setopt($curl, CURLOPT_CUSTOMREQUEST, "PUT");
                break;    
            case "DELETE":
                curl_setopt($curl, CURLOPT_POSTFIELDS, $data);
                curl_setopt($curl, CURLOPT_CUSTOMREQUEST, "DELETE");
                break;    
            default:
                curl_close($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

                return false;
                // break;
            }
        curl_setopt($curl, CURLOPT_URL, $url);
        curl_setopt($curl, CURLOPT_RETURNTRANSFER, 1);
        $res = curl_exec($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        curl_close($curl);

        return $res;
    }