VersionComparator::compareNumericParts() - Code Metrics - Inspection of "Moves Comparator methods to dedicated class" - git-pull-request/php-semver - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Julien

created 2016-05-26 18:15 UTC

VersionComparator::compareNumericParts() A

↳ Parent: VersionComparator

Complexity

Conditions	4
Paths	4

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.2
c	0
b	0
f	0
cc	4
eloc	11
nc	4
nop	2

<?php

/*
 * This file is part of semver/semver.
 *
 * (c) SemVer <https://github.com/git-pull-request>
 *
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 */

declare(strict_types=1);

namespace SemVer\SemVer;

abstract class VersionComparator
{
    /**
     * @param Version $version1
     * @param Version $version2
     *
     * @return int
     */
    public static function compare(Version $version1, Version $version2) : int
    {
        $compare = self::compareNumericParts($version1, $version2);
        if (0 !== $compare) {
            return $compare;
        }

        return PreReleaseComparator::compare($version1, $version2);
    }

    /**
     * @param Version $version1
     * @param Version $version2
     *
     * @return int
     */
    private static function compareNumericParts(Version $version1, Version $version2) : int
    {
        $compare = $version1->getMajor() <=> $version2->getMajor();
        if (0 !== $compare) {
            return $compare;
        }
        $compare = $version1->getMinor() <=> $version2->getMinor();
        if (0 !== $compare) {
            return $compare;
        }
        $compare = $version1->getPatch() <=> $version2->getPatch();
        if (0 !== $compare) {
            return $compare;
        }

        return 0;
    }
}


1			<?php
2
3			/*
4			* This file is part of semver/semver.
5			*
6			* (c) SemVer <https://github.com/git-pull-request>
7			*
8			* For the full copyright and license information, please view
9			* the LICENSE file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace SemVer\SemVer;
15
16			abstract class VersionComparator
17			{
18			/**
19			* @param Version $version1
20			* @param Version $version2
21			*
22			* @return int
23			*/
24			public static function compare(Version $version1, Version $version2) : int
25			{
26			$compare = self::compareNumericParts($version1, $version2);
27			if (0 !== $compare) {
28			return $compare;
29			}
30
31			return PreReleaseComparator::compare($version1, $version2);
32			}
33
34			/**
35			* @param Version $version1
36			* @param Version $version2
37			*
38			* @return int
39			*/
40			private static function compareNumericParts(Version $version1, Version $version2) : int
41			{
42			$compare = $version1->getMajor() <=> $version2->getMajor();
43			if (0 !== $compare) {
44			return $compare;
45			}
46			$compare = $version1->getMinor() <=> $version2->getMinor();
47			if (0 !== $compare) {
48			return $compare;
49			}
50			$compare = $version1->getPatch() <=> $version2->getPatch();
51			if (0 !== $compare) {
52			return $compare;
53			}
54
55			return 0;
56			}
57			}
58

git-pull-request / php-semver

Pull Request — master (#2)

VersionComparator::compareNumericParts() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like