Complex classes like PhoneMetadata often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use PhoneMetadata, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 10 | class PhoneMetadata |
||
| 11 | { |
||
| 12 | /** |
||
| 13 | * @var string |
||
| 14 | */ |
||
| 15 | protected $id = null; |
||
| 16 | /** |
||
| 17 | * @var int |
||
| 18 | */ |
||
| 19 | protected $countryCode = null; |
||
| 20 | protected $leadingDigits = null; |
||
| 21 | protected $internationalPrefix = null; |
||
| 22 | protected $preferredInternationalPrefix = null; |
||
| 23 | protected $nationalPrefixForParsing = null; |
||
| 24 | protected $nationalPrefixTransformRule = null; |
||
| 25 | protected $nationalPrefix = null; |
||
| 26 | protected $preferredExtnPrefix = null; |
||
| 27 | protected $mainCountryForCode = false; |
||
| 28 | protected $leadingZeroPossible = false; |
||
| 29 | protected $mobileNumberPortableRegion = false; |
||
| 30 | protected $generalDesc = null; |
||
| 31 | /** |
||
| 32 | * @var PhoneNumberDesc |
||
| 33 | */ |
||
| 34 | protected $mobile = null; |
||
| 35 | protected $premiumRate = null; |
||
| 36 | protected $fixedLine = null; |
||
| 37 | protected $sameMobileAndFixedLinePattern = false; |
||
| 38 | protected $numberFormat = array(); |
||
| 39 | protected $tollFree = null; |
||
| 40 | protected $sharedCost = null; |
||
| 41 | protected $personalNumber; |
||
| 42 | protected $voip; |
||
| 43 | protected $pager; |
||
| 44 | protected $uan; |
||
| 45 | protected $emergency; |
||
| 46 | protected $voicemail; |
||
| 47 | /** |
||
| 48 | * @var PhoneNumberDesc |
||
| 49 | */ |
||
| 50 | protected $short_code; |
||
| 51 | /** |
||
| 52 | * @var PhoneNumberDesc |
||
| 53 | */ |
||
| 54 | protected $standard_rate; |
||
| 55 | /** |
||
| 56 | * @var PhoneNumberDesc |
||
| 57 | */ |
||
| 58 | protected $carrierSpecific; |
||
| 59 | /** |
||
| 60 | * @var PhoneNumberDesc |
||
| 61 | */ |
||
| 62 | protected $noInternationalDialling = null; |
||
| 63 | /** |
||
| 64 | * |
||
| 65 | * @var NumberFormat[] |
||
| 66 | */ |
||
| 67 | protected $intlNumberFormat = array(); |
||
| 68 | |||
| 69 | /** |
||
| 70 | * @return boolean |
||
| 71 | */ |
||
| 72 | public function hasId() |
||
| 76 | |||
| 77 | /** |
||
| 78 | * @return boolean |
||
| 79 | */ |
||
| 80 | 482 | public function hasCountryCode() |
|
| 84 | |||
| 85 | 482 | public function hasInternationalPrefix() |
|
| 89 | |||
| 90 | public function hasMainCountryForCode() |
||
| 94 | |||
| 95 | 2 | public function isMainCountryForCode() |
|
| 99 | |||
| 100 | 482 | public function getMainCountryForCode() |
|
| 104 | |||
| 105 | 1569 | public function setMainCountryForCode($value) |
|
| 110 | |||
| 111 | 1 | public function clearMainCountryForCode() |
|
| 116 | |||
| 117 | 482 | public function hasLeadingZeroPossible() |
|
| 121 | |||
| 122 | 482 | public function hasMobileNumberPortableRegion() |
|
| 126 | |||
| 127 | 482 | public function hasSameMobileAndFixedLinePattern() |
|
| 131 | |||
| 132 | 2 | public function numberFormatSize() |
|
| 136 | |||
| 137 | /** |
||
| 138 | * @param int $index |
||
| 139 | * @return NumberFormat |
||
| 140 | */ |
||
| 141 | 11 | public function getNumberFormat($index) |
|
| 145 | |||
| 146 | 27 | public function intlNumberFormatSize() |
|
| 147 | { |
||
| 148 | 27 | return count($this->intlNumberFormat); |
|
| 149 | } |
||
| 150 | |||
| 151 | 6 | public function getIntlNumberFormat($index) |
|
| 155 | |||
| 156 | 7 | public function clearIntlNumberFormat() |
|
| 161 | |||
| 162 | 482 | public function toArray() |
|
| 293 | |||
| 294 | 485 | public function hasGeneralDesc() |
|
| 298 | |||
| 299 | /** |
||
| 300 | * @return PhoneNumberDesc |
||
| 301 | */ |
||
| 302 | 3510 | public function getGeneralDesc() |
|
| 306 | |||
| 307 | 1577 | public function setGeneralDesc(PhoneNumberDesc $value) |
|
| 312 | |||
| 313 | 485 | public function hasFixedLine() |
|
| 317 | |||
| 318 | /** |
||
| 319 | * @return PhoneNumberDesc |
||
| 320 | */ |
||
| 321 | 1860 | public function getFixedLine() |
|
| 325 | |||
| 326 | 1084 | public function setFixedLine(PhoneNumberDesc $value) |
|
| 331 | |||
| 332 | 485 | public function hasMobile() |
|
| 336 | |||
| 337 | /** |
||
| 338 | * @return PhoneNumberDesc |
||
| 339 | */ |
||
| 340 | 1472 | public function getMobile() |
|
| 344 | |||
| 345 | 1084 | public function setMobile(PhoneNumberDesc $value) |
|
| 350 | |||
| 351 | 485 | public function hasTollFree() |
|
| 355 | |||
| 356 | /** |
||
| 357 | * @return PhoneNumberDesc |
||
| 358 | */ |
||
| 359 | 2728 | public function getTollFree() |
|
| 363 | |||
| 364 | 1574 | public function setTollFree(PhoneNumberDesc $value) |
|
| 369 | |||
| 370 | 485 | public function hasPremiumRate() |
|
| 374 | |||
| 375 | /** |
||
| 376 | * @return PhoneNumberDesc |
||
| 377 | */ |
||
| 378 | 2976 | public function getPremiumRate() |
|
| 382 | |||
| 383 | 1574 | public function setPremiumRate(PhoneNumberDesc $value) |
|
| 388 | |||
| 389 | 485 | public function hasSharedCost() |
|
| 393 | |||
| 394 | /** |
||
| 395 | * @return PhoneNumberDesc |
||
| 396 | */ |
||
| 397 | 1938 | public function getSharedCost() |
|
| 401 | |||
| 402 | 1084 | public function setSharedCost(PhoneNumberDesc $value) |
|
| 407 | |||
| 408 | 485 | public function hasPersonalNumber() |
|
| 412 | |||
| 413 | /** |
||
| 414 | * @return PhoneNumberDesc |
||
| 415 | */ |
||
| 416 | 1790 | public function getPersonalNumber() |
|
| 420 | |||
| 421 | 1084 | public function setPersonalNumber(PhoneNumberDesc $value) |
|
| 426 | |||
| 427 | 485 | public function hasVoip() |
|
| 431 | |||
| 432 | /** |
||
| 433 | * @return PhoneNumberDesc |
||
| 434 | */ |
||
| 435 | 1855 | public function getVoip() |
|
| 439 | |||
| 440 | 1084 | public function setVoip(PhoneNumberDesc $value) |
|
| 445 | |||
| 446 | 485 | public function hasPager() |
|
| 450 | |||
| 451 | /** |
||
| 452 | * @return PhoneNumberDesc |
||
| 453 | */ |
||
| 454 | 1764 | public function getPager() |
|
| 458 | |||
| 459 | 1084 | public function setPager(PhoneNumberDesc $value) |
|
| 464 | |||
| 465 | 485 | public function hasUan() |
|
| 469 | |||
| 470 | /** |
||
| 471 | * @return PhoneNumberDesc |
||
| 472 | */ |
||
| 473 | 1717 | public function getUan() |
|
| 477 | |||
| 478 | 1084 | public function setUan(PhoneNumberDesc $value) |
|
| 483 | |||
| 484 | 745 | public function hasEmergency() |
|
| 488 | |||
| 489 | /** |
||
| 490 | * @return PhoneNumberDesc |
||
| 491 | */ |
||
| 492 | 499 | public function getEmergency() |
|
| 496 | |||
| 497 | 498 | public function setEmergency(PhoneNumberDesc $value) |
|
| 502 | |||
| 503 | 485 | public function hasVoicemail() |
|
| 507 | |||
| 508 | /** |
||
| 509 | * @return PhoneNumberDesc |
||
| 510 | */ |
||
| 511 | 1703 | public function getVoicemail() |
|
| 515 | |||
| 516 | 1084 | public function setVoicemail(PhoneNumberDesc $value) |
|
| 521 | |||
| 522 | 485 | public function hasShortCode() |
|
| 526 | |||
| 527 | 484 | public function getShortCode() |
|
| 531 | |||
| 532 | 498 | public function setShortCode(PhoneNumberDesc $value) |
|
| 537 | |||
| 538 | 485 | public function hasStandardRate() |
|
| 542 | |||
| 543 | 769 | public function getStandardRate() |
|
| 547 | |||
| 548 | 498 | public function setStandardRate(PhoneNumberDesc $value) |
|
| 553 | |||
| 554 | 485 | public function hasCarrierSpecific() |
|
| 558 | |||
| 559 | 478 | public function getCarrierSpecific() |
|
| 563 | |||
| 564 | 498 | public function setCarrierSpecific(PhoneNumberDesc $value) |
|
| 569 | |||
| 570 | 485 | public function hasNoInternationalDialling() |
|
| 574 | |||
| 575 | 493 | public function getNoInternationalDialling() |
|
| 579 | |||
| 580 | 1084 | public function setNoInternationalDialling(PhoneNumberDesc $value) |
|
| 585 | |||
| 586 | /** |
||
| 587 | * @return string |
||
| 588 | */ |
||
| 589 | 497 | public function getId() |
|
| 593 | |||
| 594 | /** |
||
| 595 | * @param string $value |
||
| 596 | * @return PhoneMetadata |
||
| 597 | */ |
||
| 598 | 1578 | public function setId($value) |
|
| 603 | |||
| 604 | /** |
||
| 605 | * @return int |
||
| 606 | */ |
||
| 607 | 3478 | public function getCountryCode() |
|
| 611 | |||
| 612 | /** |
||
| 613 | * @param int $value |
||
| 614 | * @return PhoneMetadata |
||
| 615 | */ |
||
| 616 | 1578 | public function setCountryCode($value) |
|
| 621 | |||
| 622 | 3476 | public function getInternationalPrefix() |
|
| 626 | |||
| 627 | 1578 | public function setInternationalPrefix($value) |
|
| 632 | |||
| 633 | 485 | public function hasPreferredInternationalPrefix() |
|
| 637 | |||
| 638 | 27 | public function getPreferredInternationalPrefix() |
|
| 642 | |||
| 643 | 91 | public function setPreferredInternationalPrefix($value) |
|
| 648 | |||
| 649 | 1 | public function clearPreferredInternationalPrefix() |
|
| 654 | |||
| 655 | 515 | public function hasNationalPrefix() |
|
| 659 | |||
| 660 | 179 | public function getNationalPrefix() |
|
| 664 | |||
| 665 | 755 | public function setNationalPrefix($value) |
|
| 670 | |||
| 671 | public function clearNationalPrefix() |
||
| 676 | |||
| 677 | 485 | public function hasPreferredExtnPrefix() |
|
| 681 | |||
| 682 | 11 | public function getPreferredExtnPrefix() |
|
| 686 | |||
| 687 | 201 | public function setPreferredExtnPrefix($value) |
|
| 692 | |||
| 693 | 1 | public function clearPreferredExtnPrefix() |
|
| 698 | |||
| 699 | 511 | public function hasNationalPrefixForParsing() |
|
| 703 | |||
| 704 | 3148 | public function getNationalPrefixForParsing() |
|
| 708 | |||
| 709 | 772 | public function setNationalPrefixForParsing($value) |
|
| 714 | |||
| 715 | 482 | public function hasNationalPrefixTransformRule() |
|
| 719 | |||
| 720 | 147 | public function getNationalPrefixTransformRule() |
|
| 724 | |||
| 725 | 52 | public function setNationalPrefixTransformRule($value) |
|
| 730 | |||
| 731 | 1 | public function clearNationalPrefixTransformRule() |
|
| 736 | |||
| 737 | 1685 | public function getSameMobileAndFixedLinePattern() |
|
| 738 | { |
||
| 739 | 1685 | return $this->sameMobileAndFixedLinePattern; |
|
| 740 | } |
||
| 741 | |||
| 742 | 5 | public function setSameMobileAndFixedLinePattern($value) |
|
| 747 | |||
| 748 | 1 | public function clearSameMobileAndFixedLinePattern() |
|
| 753 | |||
| 754 | /** |
||
| 755 | * @return NumberFormat[] |
||
| 756 | */ |
||
| 757 | 632 | public function numberFormats() |
|
| 761 | |||
| 762 | 589 | public function intlNumberFormats() |
|
| 766 | |||
| 767 | /** |
||
| 768 | * @return bool |
||
| 769 | */ |
||
| 770 | 1078 | public function hasLeadingDigits() |
|
| 774 | |||
| 775 | 201 | public function getLeadingDigits() |
|
| 779 | |||
| 780 | 80 | public function setLeadingDigits($value) |
|
| 785 | |||
| 786 | 486 | public function isLeadingZeroPossible() |
|
| 790 | |||
| 791 | 1569 | public function setLeadingZeroPossible($value) |
|
| 796 | |||
| 797 | 1 | public function clearLeadingZeroPossible() |
|
| 802 | |||
| 803 | 487 | public function isMobileNumberPortableRegion() |
|
| 807 | |||
| 808 | 1569 | public function setMobileNumberPortableRegion($value) |
|
| 813 | |||
| 814 | 1 | public function clearMobileNumberPortableRegion() |
|
| 819 | |||
| 820 | /** |
||
| 821 | * @param array $input |
||
| 822 | * @return PhoneMetadata |
||
| 823 | */ |
||
| 824 | 1568 | public function fromArray(array $input) |
|
| 960 | |||
| 961 | 983 | public function addNumberFormat(NumberFormat $value) |
|
| 966 | |||
| 967 | 275 | public function addIntlNumberFormat(NumberFormat $value) |
|
| 972 | } |
||
| 973 |