Complex classes like ShortNumberInfo often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ShortNumberInfo, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
14 | class ShortNumberInfo |
||
15 | { |
||
16 | const META_DATA_FILE_PREFIX = 'ShortNumberMetadata'; |
||
17 | /** |
||
18 | * @var ShortNumberInfo |
||
19 | */ |
||
20 | protected static $instance = null; |
||
21 | /** |
||
22 | * @var MatcherAPIInterface |
||
23 | */ |
||
24 | protected $matcherAPI; |
||
25 | protected $currentFilePrefix; |
||
26 | protected $regionToMetadataMap = array(); |
||
27 | protected $countryCallingCodeToRegionCodeMap = array(); |
||
28 | protected $countryCodeToNonGeographicalMetadataMap = array(); |
||
29 | protected static $regionsWhereEmergencyNumbersMustBeExact = array( |
||
30 | 'BR', |
||
31 | 'CL', |
||
32 | 'NI', |
||
33 | ); |
||
34 | |||
35 | 28 | protected function __construct(MatcherAPIInterface $matcherAPI) |
|
47 | |||
48 | /** |
||
49 | * Returns the singleton instance of ShortNumberInfo |
||
50 | * |
||
51 | * @return \libphonenumber\ShortNumberInfo |
||
52 | */ |
||
53 | 5154 | public static function getInstance() |
|
61 | |||
62 | 27 | public static function resetInstance() |
|
66 | |||
67 | /** |
||
68 | * Returns a list with teh region codes that match the specific country calling code. For |
||
69 | * non-geographical country calling codes, the region code 001 is returned. Also, in the case |
||
70 | * of no region code being found, an empty list is returned. |
||
71 | * |
||
72 | * @param int $countryCallingCode |
||
73 | * @return array |
||
74 | */ |
||
75 | 583 | protected function getRegionCodesForCountryCode($countryCallingCode) |
|
85 | |||
86 | /** |
||
87 | * Helper method to check that the country calling code of the number matches the region it's |
||
88 | * being dialed from. |
||
89 | * @param PhoneNumber $number |
||
90 | * @param string $regionDialingFrom |
||
91 | * @return bool |
||
92 | */ |
||
93 | 582 | protected function regionDialingFromMatchesNumber(PhoneNumber $number, $regionDialingFrom) |
|
99 | |||
100 | public function getSupportedRegions() |
||
104 | |||
105 | /** |
||
106 | * Gets a valid short number for the specified region. |
||
107 | * |
||
108 | * @param $regionCode String the region for which an example short number is needed |
||
109 | * @return string a valid short number for the specified region. Returns an empty string when the |
||
110 | * metadata does not contain such information. |
||
111 | */ |
||
112 | 239 | public function getExampleShortNumber($regionCode) |
|
126 | |||
127 | /** |
||
128 | * @param $regionCode |
||
129 | * @return PhoneMetadata|null |
||
130 | */ |
||
131 | 1709 | public function getMetadataForRegion($regionCode) |
|
145 | |||
146 | 262 | protected function loadMetadataFromFile($filePrefix, $regionCode, $countryCallingCode) |
|
163 | |||
164 | /** |
||
165 | * Gets a valid short number for the specified cost category. |
||
166 | * |
||
167 | * @param string $regionCode the region for which an example short number is needed |
||
168 | * @param int $cost the cost category of number that is needed |
||
169 | * @return string a valid short number for the specified region and cost category. Returns an empty string |
||
170 | * when the metadata does not contain such information, or the cost is UNKNOWN_COST. |
||
171 | */ |
||
172 | 954 | public function getExampleShortNumberForCost($regionCode, $cost) |
|
202 | |||
203 | /** |
||
204 | * Returns true if the given number, exactly as dialed, might be used to connect to an emergency |
||
205 | * service in the given region. |
||
206 | * <p> |
||
207 | * This method accepts a string, rather than a PhoneNumber, because it needs to distinguish |
||
208 | * cases such as "+1 911" and "911", where the former may not connect to an emergency service in |
||
209 | * all cases but the latter would. This method takes into account cases where the number might |
||
210 | * contain formatting, or might have additional digits appended (when it is okay to do that in |
||
211 | * the specified region). |
||
212 | * |
||
213 | * @param string $number the phone number to test |
||
214 | * @param string $regionCode the region where the phone number if being dialled |
||
215 | * @return boolean whether the number might be used to connect to an emergency service in the given region |
||
216 | */ |
||
217 | 18 | public function connectsToEmergencyNumber($number, $regionCode) |
|
221 | |||
222 | /** |
||
223 | * @param string $number |
||
224 | * @param string $regionCode |
||
225 | * @param bool $allowPrefixMatch |
||
226 | * @return bool |
||
227 | */ |
||
228 | 278 | protected function matchesEmergencyNumberHelper($number, $regionCode, $allowPrefixMatch) |
|
253 | |||
254 | /** |
||
255 | * Given a valid short number, determines whether it is carrier-specific (however, nothing is |
||
256 | * implied about its validity). If it is important that the number is valid, then its validity |
||
257 | * must first be checked using {@link isValidShortNumber} or |
||
258 | * {@link #isValidShortNumberForRegion}. |
||
259 | * |
||
260 | * @param PhoneNumber $number the valid short number to check |
||
261 | * @return boolean whether the short number is carrier-specific (assuming the input was a valid short |
||
262 | * number). |
||
263 | */ |
||
264 | 27 | public function isCarrierSpecific(PhoneNumber $number) |
|
276 | |||
277 | /** |
||
278 | * Helper method to get the region code for a given phone number, from a list of possible region |
||
279 | * codes. If the list contains more than one region, the first region for which the number is |
||
280 | * valid is returned. |
||
281 | * |
||
282 | * @param PhoneNumber $number |
||
283 | * @param $regionCodes |
||
284 | * @return String|null Region Code (or null if none are found) |
||
285 | */ |
||
286 | 269 | protected function getRegionCodeForShortNumberFromRegionList(PhoneNumber $number, $regionCodes) |
|
307 | |||
308 | /** |
||
309 | * Check whether a short number is a possible number. If a country calling code is shared by |
||
310 | * multiple regions, this returns true if it's possible in any of them. This provides a more |
||
311 | * lenient check than {@link #isValidShortNumber}. See {@link |
||
312 | * #IsPossibleShortNumberForRegion(PhoneNumber, String)} for details. |
||
313 | * |
||
314 | * @param $number PhoneNumber the short number to check |
||
315 | * @return boolean whether the number is a possible short number |
||
316 | */ |
||
317 | 2 | public function isPossibleShortNumber(PhoneNumber $number) |
|
336 | |||
337 | /** |
||
338 | * Check whether a short number is a possible number when dialled from a region, given the number |
||
339 | * in the form of a string, and the region where the number is dialled from. This provides a more |
||
340 | * lenient check than {@link #isValidShortNumber}. |
||
341 | * |
||
342 | * @param PhoneNumber|string $shortNumber The short number to check |
||
343 | * @param string $regionDialingFrom Region dialing From |
||
344 | * @return boolean whether the number is a possible short number |
||
345 | */ |
||
346 | 267 | public function isPossibleShortNumberForRegion($shortNumber, $regionDialingFrom) |
|
376 | |||
377 | /** |
||
378 | * Tests whether a short number matches a valid pattern. If a country calling code is shared by |
||
379 | * multiple regions, this returns true if it's valid in any of them. Note that this doesn't verify |
||
380 | * the number is actually in use, which is impossible to tell by just looking at the number |
||
381 | * itself. See {@link #isValidShortNumberForRegion(PhoneNumber, String)} for details. |
||
382 | * |
||
383 | * @param $number PhoneNumber the short number for which we want to test the validity |
||
384 | * @return boolean whether the short number matches a valid pattern |
||
385 | */ |
||
386 | 242 | public function isValidShortNumber(PhoneNumber $number) |
|
398 | |||
399 | /** |
||
400 | * Tests whether a short number matches a valid pattern in a region. Note that this doesn't verify |
||
401 | * the number is actually in use, which is impossible to tell by just looking at the number |
||
402 | * itself. |
||
403 | * |
||
404 | * @param PhoneNumber|string $number The Short number for which we want to test the validity |
||
405 | * @param string $regionDialingFrom the region from which the number is dialed |
||
406 | * @return boolean whether the short number matches a valid pattern |
||
407 | */ |
||
408 | 243 | public function isValidShortNumberForRegion($number, $regionDialingFrom) |
|
444 | |||
445 | /** |
||
446 | * Gets the expected cost category of a short number when dialled from a region (however, nothing is |
||
447 | * implied about its validity). If it is important that the number is valid, then its validity |
||
448 | * must first be checked using {@link isValidShortNumberForRegion}. Note that emergency numbers |
||
449 | * are always considered toll-free. |
||
450 | * Example usage: |
||
451 | * <pre>{@code |
||
452 | * $shortInfo = ShortNumberInfo::getInstance(); |
||
453 | * $shortNumber = "110"; |
||
454 | * $regionCode = "FR"; |
||
455 | * if ($shortInfo->isValidShortNumberForRegion($shortNumber, $regionCode)) { |
||
456 | * $cost = $shortInfo->getExpectedCostForRegion($shortNumber, $regionCode); |
||
457 | * // Do something with the cost information here. |
||
458 | * }}</pre> |
||
459 | * |
||
460 | * @param PhoneNumber|string $number the short number for which we want to know the expected cost category, |
||
461 | * as a string |
||
462 | * @param string $regionDialingFrom the region from which the number is dialed |
||
463 | * @return int the expected cost category for that region of the short number. Returns UNKNOWN_COST if |
||
464 | * the number does not match a cost category. Note that an invalid number may match any cost |
||
465 | * category. |
||
466 | */ |
||
467 | 314 | public function getExpectedCostForRegion($number, $regionDialingFrom) |
|
514 | |||
515 | /** |
||
516 | * Gets the expected cost category of a short number (however, nothing is implied about its |
||
517 | * validity). If the country calling code is unique to a region, this method behaves exactly the |
||
518 | * same as {@link #getExpectedCostForRegion(PhoneNumber, String)}. However, if the country calling |
||
519 | * code is shared by multiple regions, then it returns the highest cost in the sequence |
||
520 | * PREMIUM_RATE, UNKNOWN_COST, STANDARD_RATE, TOLL_FREE. The reason for the position of |
||
521 | * UNKNOWN_COST in this order is that if a number is UNKNOWN_COST in one region but STANDARD_RATE |
||
522 | * or TOLL_FREE in another, its expected cost cannot be estimated as one of the latter since it |
||
523 | * might be a PREMIUM_RATE number. |
||
524 | * |
||
525 | * <p> |
||
526 | * For example, if a number is STANDARD_RATE in the US, but TOLL_FREE in Canada, the expected |
||
527 | * cost returned by this method will be STANDARD_RATE, since the NANPA countries share the same |
||
528 | * country calling code. |
||
529 | * </p> |
||
530 | * |
||
531 | * Note: If the region from which the number is dialed is known, it is highly preferable to call |
||
532 | * {@link #getExpectedCostForRegion(PhoneNumber, String)} instead. |
||
533 | * |
||
534 | * @param PhoneNumber $number the short number for which we want to know the expected cost category |
||
535 | * @return int the highest expected cost category of the short number in the region(s) with the given |
||
536 | * country calling code |
||
537 | */ |
||
538 | 3 | public function getExpectedCost(PhoneNumber $number) |
|
570 | |||
571 | /** |
||
572 | * Returns true if the given number exactly matches an emergency service number in the given |
||
573 | * region. |
||
574 | * <p> |
||
575 | * This method takes into account cases where the number might contain formatting, but doesn't |
||
576 | * allow additional digits to be appended. Note that {@code isEmergencyNumber(number, region)} |
||
577 | * implies {@code connectsToEmergencyNumber(number, region)}. |
||
578 | * |
||
579 | * @param string $number the phone number to test |
||
580 | * @param string $regionCode the region where the phone number is being dialled |
||
581 | * @return boolean whether the number exactly matches an emergency services number in the given region |
||
582 | */ |
||
583 | 260 | public function isEmergencyNumber($number, $regionCode) |
|
587 | |||
588 | /** |
||
589 | * Gets the national significant number of the a phone number. Note a national significant number |
||
590 | * doesn't contain a national prefix or any formatting. |
||
591 | * <p> |
||
592 | * This is a temporary duplicate of the {@code getNationalSignificantNumber} method from |
||
593 | * {@code PhoneNumberUtil}. Ultimately a canonical static version should exist in a separate |
||
594 | * utility class (to prevent {@code ShortNumberInfo} needing to depend on PhoneNumberUtil). |
||
595 | * |
||
596 | * @param PhoneNumber $number the phone number for which the national significant number is needed |
||
597 | * @return string the national significant number of the PhoneNumber object passed in |
||
598 | */ |
||
599 | 582 | protected function getNationalSignificantNumber(PhoneNumber $number) |
|
612 | |||
613 | /** |
||
614 | * // TODO: Once we have benchmarked ShortnumberInfo, consider if it is worth keeping |
||
615 | * this performance optimization, and if so move this into the matcher implementation |
||
616 | * @param string $number |
||
617 | * @param PhoneNumberDesc $numberDesc |
||
618 | * @return bool |
||
619 | */ |
||
620 | 579 | protected function matchesPossibleNumberAndNationalNumber($number, PhoneNumberDesc $numberDesc) |
|
625 | } |
||
626 |