CachingIterator::next() - Code Metrics - Inspection of "Refactor a bit." - gielfeldt/iterators - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0c8b13...b1ee3a )

by Thomas

created 2017-04-27 22:25 UTC

CachingIterator::next() A

↳ Parent: CachingIterator

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	0

<?php

namespace Gielfeldt\Iterators;

class CachingIterator extends \ArrayIterator
{
    const CLONE_KEY = 1;
    const CLONE_CURRENT = 2;

    private $uncachedIterator;
    private $uncachedIteratorCount;
    private $modified = false;
    private $finished = false;
    private $flags;

    public function __construct(\Traversable $iterator, int $flags = self::CLONE_KEY | self::CLONE_CURRENT)
    {
        $this->flags = $flags;
        $this->uncachedIteratorCount = $iterator instanceof \Countable ? count($iterator) : null;
        $this->uncachedIterator = new TraversableIterator($iterator);
        parent::__construct();
    }

    private function setupInnerIterator()
    {
        if ($this->uncachedIterator->getIndex() === null) {
            $this->uncachedIterator->rewind();
            parent::rewind();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            $this->collect();
        }
    }

    public function count()
    {
        if (!$this->finished && !$this->modified && $this->uncachedIteratorCount !== null) {
            return $this->uncachedIteratorCount;
        }
        $this->collectRest();
        return parent::count();
    }

    public function getIndex()
    {
        return $this->index;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function rewind()
    {
        $this->index = 0;
        $this->setupInnerIterator();
        parent::rewind();
    }

    public function next()
    {
        $this->index++;
        parent::next();
        if (!parent::valid()) {
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            $this->collect();
        }
    }

    public function offsetSet($offset, $value)
    {
        $this->collectRest();
        $this->modified = true;
        return parent::offsetSet($offset, $value);
    }

    public function collectRest($until = null)
    {
        if ($this->finished) {
            return;
        }

        $this->setupInnerIterator();

        while (!$this->finished && ($until == null || $until >= $this->uncachedIterator->getIndex())) {
            $this->collect();
        }
    }

    public function collect()
    {
        if ($this->uncachedIterator->valid()) {
            $key = $this->uncachedIterator->key();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            $key = ($this->flags & self::CLONE_KEY) && is_object($key) ? clone $key : $key;
            $current = $this->uncachedIterator->current();
            $current = ($this->flags & self::CLONE_CURRENT) && is_object($current) ? clone $current : $current;
            parent::offsetSet($key, $current);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            $this->uncachedIterator->next();
        } else {
            $this->finished = true;
        }
    }

    public function prev()
    {
        $this->seek($this->index - 1);
    }

    // Ensure entire inner iterator is collected before applying the follwing.
    public function seek($pos)
    {
        if ($pos >= $this->uncachedIterator->getIndex()) {
            $this->collectRest($pos);
        }
        $this->index = $pos;
        return parent::seek($pos);
    }

    public function offsetGet($offset)
    {
        $this->collectRest();
        return parent::offsetGet($offset);
    }

    public function offsetExists($offset)
    {
        $this->collectRest();
        return parent::offsetExists($offset);
    }

    public function offsetUnset($offset)
    {
        $this->collectRest();
        $this->modified = true;
        return parent::offsetUnset($offset);
    }

    public function getArrayCopy()
    {
        $this->collectRest();
        return iterator_to_array($this);
    }

    public function ksort()
    {
        $this->collectRest();
        return parent::ksort();
    }
    public function natcasesort()
    {
        $this->collectRest();
        return parent::natcasesort();
    }
    public function natsort()
    {
        $this->collectRest();
        return parent::natsort();
    }
    public function uasort($cmp)
    {
        $this->collectRest();
        return parent::uasort($cmp);
    }
    public function uksort($cmp)
    {
        $this->collectRest();
        return parent::uksort($cmp);
    }
    public function serialize()
    {
        $this->collectRest();
        $serialized = "x:i:0;";
        $serialized .= serialize($this->getArrayCopy()) . ";";
        $serialized .= "m:a:0:{}";
        return $serialized;
    }
    public function unserialize($serialized)
    {
        $this->finished = true;
        $this->modified = false;
        $this->uncachedIterator = new TraversableIterator(new \ArrayIterator());
        $this->uncachedIteratorCount = null;
        return parent::unserialize($serialized);
    }
}


1			<?php
2
3			namespace Gielfeldt\Iterators;
4
5			class CachingIterator extends \ArrayIterator
6			{
7			const CLONE_KEY = 1;
8			const CLONE_CURRENT = 2;
9
10			private $uncachedIterator;
11			private $uncachedIteratorCount;
12			private $modified = false;
13			private $finished = false;
14			private $flags;
15
16			public function __construct(\Traversable $iterator, int $flags = self::CLONE_KEY \| self::CLONE_CURRENT)
17			{
18			$this->flags = $flags;
19			$this->uncachedIteratorCount = $iterator instanceof \Countable ? count($iterator) : null;
20			$this->uncachedIterator = new TraversableIterator($iterator);
21			parent::__construct();
22			}
23
24			private function setupInnerIterator()
25			{
26			if ($this->uncachedIterator->getIndex() === null) {
27			$this->uncachedIterator->rewind();
28			parent::rewind();
			0 ignored issues – show Comprehensibility Bug introduced 2017-04-26 05:14 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`rewind()` instead of `setupInnerIterator()`). Are you sure this is correct? If so, you might want to change this to `$this->rewind()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
29			$this->collect();
30			}
31			}
32
33			public function count()
34			{
35			if (!$this->finished && !$this->modified && $this->uncachedIteratorCount !== null) {
36			return $this->uncachedIteratorCount;
37			}
38			$this->collectRest();
39			return parent::count();
40			}
41
42			public function getIndex()
43			{
44			return $this->index;
			0 ignored issues – show Bug introduced 2017-04-27 22:27 UTC by Report Bug Copy Issue Report The property `index` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
45			}
46
47			public function rewind()
48			{
49			$this->index = 0;
50			$this->setupInnerIterator();
51			parent::rewind();
52			}
53
54			public function next()
55			{
56			$this->index++;
57			parent::next();
58			if (!parent::valid()) {
			0 ignored issues – show Comprehensibility Bug introduced 2017-04-23 08:41 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`valid()` instead of `next()`). Are you sure this is correct? If so, you might want to change this to `$this->valid()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
59			$this->collect();
60			}
61			}
62
63			public function offsetSet($offset, $value)
64			{
65			$this->collectRest();
66			$this->modified = true;
67			return parent::offsetSet($offset, $value);
68			}
69
70			public function collectRest($until = null)
71			{
72			if ($this->finished) {
73			return;
74			}
75
76			$this->setupInnerIterator();
77
78			while (!$this->finished && ($until == null \|\| $until >= $this->uncachedIterator->getIndex())) {
79			$this->collect();
80			}
81			}
82
83			public function collect()
84			{
85			if ($this->uncachedIterator->valid()) {
86			$key = $this->uncachedIterator->key();
			0 ignored issues – show Bug introduced 2017-04-26 05:14 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$key` is correct as `$this->uncachedIterator->key()` (which targets `IteratorIterator::key()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
87			$key = ($this->flags & self::CLONE_KEY) && is_object($key) ? clone $key : $key;
88			$current = $this->uncachedIterator->current();
89			$current = ($this->flags & self::CLONE_CURRENT) && is_object($current) ? clone $current : $current;
90			parent::offsetSet($key, $current);
			0 ignored issues – show Comprehensibility Bug introduced 2017-04-26 05:14 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`offsetSet()` instead of `collect()`). Are you sure this is correct? If so, you might want to change this to `$this->offsetSet()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
91			$this->uncachedIterator->next();
92			} else {
93			$this->finished = true;
94			}
95			}
96
97			public function prev()
98			{
99			$this->seek($this->index - 1);
100			}
101
102			// Ensure entire inner iterator is collected before applying the follwing.
103			public function seek($pos)
104			{
105			if ($pos >= $this->uncachedIterator->getIndex()) {
106			$this->collectRest($pos);
107			}
108			$this->index = $pos;
109			return parent::seek($pos);
110			}
111
112			public function offsetGet($offset)
113			{
114			$this->collectRest();
115			return parent::offsetGet($offset);
116			}
117
118			public function offsetExists($offset)
119			{
120			$this->collectRest();
121			return parent::offsetExists($offset);
122			}
123
124			public function offsetUnset($offset)
125			{
126			$this->collectRest();
127			$this->modified = true;
128			return parent::offsetUnset($offset);
129			}
130
131			public function getArrayCopy()
132			{
133			$this->collectRest();
134			return iterator_to_array($this);
135			}
136
137			public function ksort()
138			{
139			$this->collectRest();
140			return parent::ksort();
141			}
142			public function natcasesort()
143			{
144			$this->collectRest();
145			return parent::natcasesort();
146			}
147			public function natsort()
148			{
149			$this->collectRest();
150			return parent::natsort();
151			}
152			public function uasort($cmp)
153			{
154			$this->collectRest();
155			return parent::uasort($cmp);
156			}
157			public function uksort($cmp)
158			{
159			$this->collectRest();
160			return parent::uksort($cmp);
161			}
162			public function serialize()
163			{
164			$this->collectRest();
165			$serialized = "x:i:0;";
166			$serialized .= serialize($this->getArrayCopy()) . ";";
167			$serialized .= "m:a:0:{}";
168			return $serialized;
169			}
170			public function unserialize($serialized)
171			{
172			$this->finished = true;
173			$this->modified = false;
174			$this->uncachedIterator = new TraversableIterator(new \ArrayIterator());
175			$this->uncachedIteratorCount = null;
176			return parent::unserialize($serialized);
177			}
178			}
179

gielfeldt / iterators

GitHub Access Token became invalid

Push — master ( 0c8b13...b1ee3a )

CachingIterator::next() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like