RepeatIterator::valid() - Code Metrics - Inspection of "Refactor quite a bit." - gielfeldt/iterators - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fc5653...e1c659 )

by Thomas

created 2017-04-23 08:17 UTC

RepeatIterator::valid() A

↳ Parent: RepeatIterator

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	2
eloc	2
nc	2
nop	0

<?php

namespace Gielfeldt\Iterators;

class RepeatIterator extends IteratorIterator implements \Countable
{
    protected $count;
    protected $currentIteration = 0;
    protected $innerCount;

    public function __construct(\Traversable $iterator, int $count)
    {
        if ($count < 0) {
            throw new \InvalidArgumentException('Count cannot be less than 0.');
        }

        $this->count = $count;
        parent::__construct($iterator);
    }

    public function count()
    {
        if (!isset($this->innerCount)) {
            $this->innerCount = count(new CountableIterator($this->getInnerIterator()));
        }
        return $this->innerCount * $this->count;
    }

    public function getIterationCount()
    {
        return $this->count;
    }

    public function getCurrentIteration()
    {
        return $this->currentIteration;
    }

    public function rewind()
    {
        $this->currentIteration = 0;
        return parent::rewind();
    }

    public function next()
    {
        parent::next();
        if (!parent::valid()) {
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            $this->currentIteration++;
            parent::rewind();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        }
    }

    public function valid()
    {
        return $this->currentIteration < $this->count && parent::valid();
    }
}


1			<?php
2
3			namespace Gielfeldt\Iterators;
4
5			class RepeatIterator extends IteratorIterator implements \Countable
6			{
7			protected $count;
8			protected $currentIteration = 0;
9			protected $innerCount;
10
11			public function __construct(\Traversable $iterator, int $count)
12			{
13			if ($count < 0) {
14			throw new \InvalidArgumentException('Count cannot be less than 0.');
15			}
16
17			$this->count = $count;
18			parent::__construct($iterator);
19			}
20
21			public function count()
22			{
23			if (!isset($this->innerCount)) {
24			$this->innerCount = count(new CountableIterator($this->getInnerIterator()));
25			}
26			return $this->innerCount * $this->count;
27			}
28
29			public function getIterationCount()
30			{
31			return $this->count;
32			}
33
34			public function getCurrentIteration()
35			{
36			return $this->currentIteration;
37			}
38
39			public function rewind()
40			{
41			$this->currentIteration = 0;
42			return parent::rewind();
43			}
44
45			public function next()
46			{
47			parent::next();
48			if (!parent::valid()) {
			0 ignored issues – show Comprehensibility Bug introduced 2017-04-23 08:41 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`valid()` instead of `next()`). Are you sure this is correct? If so, you might want to change this to `$this->valid()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
49			$this->currentIteration++;
50			parent::rewind();
			0 ignored issues – show Comprehensibility Bug introduced 2017-04-23 08:41 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`rewind()` instead of `next()`). Are you sure this is correct? If so, you might want to change this to `$this->rewind()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
51			}
52			}
53
54			public function valid()
55			{
56			return $this->currentIteration < $this->count && parent::valid();
57			}
58			}
59

gielfeldt / iterators

GitHub Access Token became invalid

Push — master ( fc5653...e1c659 )

RepeatIterator::valid() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like