Gielfeldt\Iterators\ShuffleIterator

Complexity

Total Complexity

16

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	getShuffledIterator()	0	17	5
A	generateElement()	0	4	1
A	key()	0	4	1
A	current()	0	4	1
A	count()	0	4	1
A	first()	0	5	2
A	last()	0	5	2
A	min()	0	4	1
A	max()	0	4	1

<?php

namespace Gielfeldt\Iterators;

class ShuffleIterator extends IteratorIterator implements \Countable
{
    protected $min = INF;
    protected $max = -INF;

    public function __construct(\Traversable $iterator)
    {
        parent::__construct($this->getShuffledIterator($iterator));
    }

    public function getShuffledIterator($iterator)
    {
        $sortedIterator = new \ArrayIterator();
        $sorted = [];
        foreach ($iterator as $key => $value) {
            $sorted[] = $this->generateElement($key, $value, $iterator);
            $this->min = $this->min < $value ? $this->min : $value;
            $this->max = $this->max > $value ? $this->max : $value;
        }

        shuffle($sorted);

        foreach ($sorted as $data) {
            $sortedIterator->append($data);
        }
        return $sortedIterator;
    }

    protected function generateElement($key, $value, $iterator)

The parameter $iterator is not used and could be removed.

    {
        return (object) ['key' => $key, 'current' => $value];
    }

    public function key()
    {
        return $this->getInnerIterator()->current()->key ?? null;
    }

    public function current()
    {
        return $this->getInnerIterator()->current()->current ?? null;
    }

    public function count()
    {
        return $this->getInnerIterator()->count();

It seems like you code against a concrete implementation and not the interface Iterator as the method count() does only exist in the following implementations of said interface: ArrayIterator, CachingIterator, DoctrineTest\InstantiatorTestAsset\PharAsset, Gielfeldt\Iterators\CountableIterator, Gielfeldt\Iterators\CsvFileObject, Gielfeldt\Iterators\GlobIterator, Gielfeldt\Iterators\RecursiveSortIterator, Gielfeldt\Iterators\RepeatIterator, Gielfeldt\Iterators\ShuffleIterator, Gielfeldt\Iterators\SortIterator, GlobIterator, HttpMessage, HttpRequestPool, Issue523, MongoCursor, MongoGridFSCursor, PHP_Token_Stream, Phar, PharData, RecursiveArrayIterator, RecursiveCachingIterator, SQLiteResult, SimpleXMLIterator, SplDoublyLinkedList, SplFixedArray, SplHeap, SplMaxHeap, SplMinHeap, SplObjectStorage, SplPriorityQueue, SplQueue, SplStack, TheSeer\Tokenizer\TokenCollection.

    }

    public function first()
    {
        $count = $this->getInnerIterator()->count();

It seems like you code against a concrete implementation and not the interface Iterator as the method count() does only exist in the following implementations of said interface: ArrayIterator, CachingIterator, DoctrineTest\InstantiatorTestAsset\PharAsset, Gielfeldt\Iterators\CountableIterator, Gielfeldt\Iterators\CsvFileObject, Gielfeldt\Iterators\GlobIterator, Gielfeldt\Iterators\RecursiveSortIterator, Gielfeldt\Iterators\RepeatIterator, Gielfeldt\Iterators\ShuffleIterator, Gielfeldt\Iterators\SortIterator, GlobIterator, HttpMessage, HttpRequestPool, Issue523, MongoCursor, MongoGridFSCursor, PHP_Token_Stream, Phar, PharData, RecursiveArrayIterator, RecursiveCachingIterator, SQLiteResult, SimpleXMLIterator, SplDoublyLinkedList, SplFixedArray, SplHeap, SplMaxHeap, SplMinHeap, SplObjectStorage, SplPriorityQueue, SplQueue, SplStack, TheSeer\Tokenizer\TokenCollection.

        return $count ? $this->getInnerIterator()[0]->current : null;
    }

    public function last()
    {
        $count = $this->getInnerIterator()->count();

It seems like you code against a concrete implementation and not the interface Iterator as the method count() does only exist in the following implementations of said interface: ArrayIterator, CachingIterator, DoctrineTest\InstantiatorTestAsset\PharAsset, Gielfeldt\Iterators\CountableIterator, Gielfeldt\Iterators\CsvFileObject, Gielfeldt\Iterators\GlobIterator, Gielfeldt\Iterators\RecursiveSortIterator, Gielfeldt\Iterators\RepeatIterator, Gielfeldt\Iterators\ShuffleIterator, Gielfeldt\Iterators\SortIterator, GlobIterator, HttpMessage, HttpRequestPool, Issue523, MongoCursor, MongoGridFSCursor, PHP_Token_Stream, Phar, PharData, RecursiveArrayIterator, RecursiveCachingIterator, SQLiteResult, SimpleXMLIterator, SplDoublyLinkedList, SplFixedArray, SplHeap, SplMaxHeap, SplMinHeap, SplObjectStorage, SplPriorityQueue, SplQueue, SplStack, TheSeer\Tokenizer\TokenCollection.

        return $count ? $this->getInnerIterator()[$count - 1]->current : null;
    }

    public function min()
    {
        return $this->min;
    }

    public function max()
    {
        return $this->max;
    }
}