IndexIterator::__construct() - Code Metrics - gielfeldt/iterators - Measure and Improve Code Quality continuously with Scrutinizer

IndexIterator::__construct() A
last analyzed 2018-11-04 00:57 UTC

↳ Parent: IndexIterator

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
ccs	8
cts	8
cp	1
cc	3
nc	4
nop	2
crap	3

<?php

namespace Gielfeldt\Iterators;

class IndexIterator extends TraversableIterator implements \Countable
{
    private $indexingIterator;
    private $valid;

    public function __construct(\Traversable $iterator, iterable $indexes)
    {
        if ($indexes instanceof \Traversable) {
            $indexes = iterator_to_array(new \IteratorIterator($indexes), false);
        }
        sort($indexes);
        $this->indexingIterator = new \ArrayIterator($indexes);

        $iterator = $iterator instanceof \Countable ? $iterator : new CountableIterator($iterator, CountableIterator::CACHE_COUNT);
        parent::__construct($iterator);
    }

    public function count()
    {
        return min(count($this->getInnerIterator()), count($this->indexingIterator));
    }

    public function rewind()
    {
        parent::rewind();
        $this->indexingIterator->rewind();
        $this->next();
    }

    public function next()
    {
        $this->valid = $this->indexingIterator->valid();
        $index = $this->indexingIterator->current();
        while (parent::valid() && $this->getIndex() < $index) {
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            parent::next();
        }
        $this->indexingIterator->next();
    }

    public function valid()
    {
        return $this->valid && parent::valid();
    }
}


1		<?php
2
3		namespace Gielfeldt\Iterators;
4
5		class IndexIterator extends TraversableIterator implements \Countable
6		{
7		private $indexingIterator;
8		private $valid;
9
10	3	public function __construct(\Traversable $iterator, iterable $indexes)
11		{
12	3	if ($indexes instanceof \Traversable) {
13	3	$indexes = iterator_to_array(new \IteratorIterator($indexes), false);
14	3	}
15		sort($indexes);
16	3	$this->indexingIterator = new \ArrayIterator($indexes);
17
18	3	$iterator = $iterator instanceof \Countable ? $iterator : new CountableIterator($iterator, CountableIterator::CACHE_COUNT);
19	3	parent::__construct($iterator);
20	3	}
21	3
22		public function count()
23	3	{
24		return min(count($this->getInnerIterator()), count($this->indexingIterator));
25	3	}
26	3
27	3	public function rewind()
28	3	{
29		parent::rewind();
30	3	$this->indexingIterator->rewind();
31	3	$this->next();
32		}
33	3
34		public function next()
35	3	{
36		$this->valid = $this->indexingIterator->valid();
37		$index = $this->indexingIterator->current();
38		while (parent::valid() && $this->getIndex() < $index) {
		0 ignored issues – show Comprehensibility Bug introduced 2017-04-23 08:41 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`valid()` instead of `next()`). Are you sure this is correct? If so, you might want to change this to `$this->valid()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
39		parent::next();
40		}
41		$this->indexingIterator->next();
42		}
43
44		public function valid()
45		{
46		return $this->valid && parent::valid();
47		}
48		}
49

gielfeldt / iterators

GitHub Access Token became invalid

IndexIterator::__construct() A last analyzed 2018-11-04 00:57 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

IndexIterator::__construct() A
last analyzed 2018-11-04 00:57 UTC