Gielfeldt\Iterators\SortIterator

Complexity

Total Complexity

20

Size/Duplication

Total Lines	98
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	2
A	getSortedIterator()	0	15	3
A	generateElement()	0	4	1
A	key()	0	7	2
A	current()	0	4	1
A	count()	0	4	1
A	first()	0	5	2
A	last()	0	5	2
A	min()	0	4	2
A	max()	0	4	2
A	sortCurrent()	0	4	1
A	sortKey()	0	4	1

<?php

namespace Gielfeldt\Iterators;

class SortIterator extends TraversableIterator implements \Countable
{
    const SORT_CURRENT = [__CLASS__, 'sortCurrent'];
    const SORT_KEY = [__CLASS__, 'sortKey'];
    const SORT_ASC = 1;
    const SORT_DESC = 2;
    const SORT_REINDEX = 4;

    protected $direction;
    protected $flags;
    protected $callback;
    protected $realCallback;

    public function __construct(\Traversable $iterator, int $direction = self::SORT_ASC, int $flags = 0, callable $callback = self::SORT_CURRENT)
    {
        $this->direction = $direction;
        $this->flags = $flags;
        $this->callback = \Closure::fromCallable($callback);
        $this->realCallback = $direction == self::SORT_ASC ? $this->callback : function ($cmpA, $cmpB) {
            return ($this->callback)($cmpB, $cmpA);
        };
        parent::__construct($this->getSortedIterator($iterator));
    }

    /**
     * @param \Traversable $iterator
     */
    public function getSortedIterator($iterator)
    {
        $sortedIterator = new \ArrayIterator();
        $sorted = [];
        foreach ($iterator as $key => $value) {
            $sorted[] = $this->generateElement($key, $value, $iterator);
        }

        usort($sorted, $this->realCallback);

        foreach ($sorted as $data) {
            $sortedIterator->append($data);
        }
        return $sortedIterator;
    }

    protected function generateElement($key, $value, $iterator)

The parameter $iterator is not used and could be removed.

    {
        return (object) ['key' => $key, 'current' => $value];
    }

    public function key()
    {
        if ($this->flags & self::SORT_REINDEX) {
            return $this->getInnerIterator()->key();
        }
        return $this->getInnerIterator()->current()->key ?? null;
    }

    public function current()
    {
        return $this->getInnerIterator()->current()->current ?? null;
    }

    public function count()
    {
        return $this->getInnerIterator()->count();

It seems like you code against a concrete implementation and not the interface Iterator as the method count() does only exist in the following implementations of said interface: ArrayIterator, CachingIterator, Gielfeldt\Iterators\CachingIterator, Gielfeldt\Iterators\CountableIterator, Gielfeldt\Iterators\CsvFileObject, Gielfeldt\Iterators\GlobIterator, Gielfeldt\Iterators\IndexIterator, Gielfeldt\Iterators\OrderedInterleaveIterator, Gielfeldt\Iterators\RecursiveSortIterator, Gielfeldt\Iterators\RepeatIterator, Gielfeldt\Iterators\ShuffleIterator, Gielfeldt\Iterators\SortIterator, GlobIterator, HttpMessage, HttpRequestPool, Issue523, MongoCursor, MongoGridFSCursor, PHP_CodeSniffer\Files\FileList, PHP_Token_Stream, Phar, PharData, Predis\Response\Iterator\MultiBulk, Predis\Response\Iterator\MultiBulkIterator, Predis\Response\Iterator\MultiBulkTuple, RecursiveArrayIterator, RecursiveCachingIterator, SQLiteResult, SimpleXMLIterator, SplDoublyLinkedList, SplFixedArray, SplHeap, SplMaxHeap, SplMinHeap, SplObjectStorage, SplPriorityQueue, SplQueue, SplStack, TheSeer\Tokenizer\TokenCollection.

    }

    public function first()
    {
        $count = $this->getInnerIterator()->count();

It seems like you code against a concrete implementation and not the interface Iterator as the method count() does only exist in the following implementations of said interface: ArrayIterator, CachingIterator, Gielfeldt\Iterators\CachingIterator, Gielfeldt\Iterators\CountableIterator, Gielfeldt\Iterators\CsvFileObject, Gielfeldt\Iterators\GlobIterator, Gielfeldt\Iterators\IndexIterator, Gielfeldt\Iterators\OrderedInterleaveIterator, Gielfeldt\Iterators\RecursiveSortIterator, Gielfeldt\Iterators\RepeatIterator, Gielfeldt\Iterators\ShuffleIterator, Gielfeldt\Iterators\SortIterator, GlobIterator, HttpMessage, HttpRequestPool, Issue523, MongoCursor, MongoGridFSCursor, PHP_CodeSniffer\Files\FileList, PHP_Token_Stream, Phar, PharData, Predis\Response\Iterator\MultiBulk, Predis\Response\Iterator\MultiBulkIterator, Predis\Response\Iterator\MultiBulkTuple, RecursiveArrayIterator, RecursiveCachingIterator, SQLiteResult, SimpleXMLIterator, SplDoublyLinkedList, SplFixedArray, SplHeap, SplMaxHeap, SplMinHeap, SplObjectStorage, SplPriorityQueue, SplQueue, SplStack, TheSeer\Tokenizer\TokenCollection.

        return $count ? $this->getInnerIterator()[0]->current : null;
    }

    public function last()
    {
        $count = $this->getInnerIterator()->count();

It seems like you code against a concrete implementation and not the interface Iterator as the method count() does only exist in the following implementations of said interface: ArrayIterator, CachingIterator, Gielfeldt\Iterators\CachingIterator, Gielfeldt\Iterators\CountableIterator, Gielfeldt\Iterators\CsvFileObject, Gielfeldt\Iterators\GlobIterator, Gielfeldt\Iterators\IndexIterator, Gielfeldt\Iterators\OrderedInterleaveIterator, Gielfeldt\Iterators\RecursiveSortIterator, Gielfeldt\Iterators\RepeatIterator, Gielfeldt\Iterators\ShuffleIterator, Gielfeldt\Iterators\SortIterator, GlobIterator, HttpMessage, HttpRequestPool, Issue523, MongoCursor, MongoGridFSCursor, PHP_CodeSniffer\Files\FileList, PHP_Token_Stream, Phar, PharData, Predis\Response\Iterator\MultiBulk, Predis\Response\Iterator\MultiBulkIterator, Predis\Response\Iterator\MultiBulkTuple, RecursiveArrayIterator, RecursiveCachingIterator, SQLiteResult, SimpleXMLIterator, SplDoublyLinkedList, SplFixedArray, SplHeap, SplMaxHeap, SplMinHeap, SplObjectStorage, SplPriorityQueue, SplQueue, SplStack, TheSeer\Tokenizer\TokenCollection.

        return $count ? $this->getInnerIterator()[$count - 1]->current : null;
    }

    public function min()
    {
        return $this->direction == self::SORT_ASC ? $this->first() : $this->last();
    }

    public function max()
    {
        return $this->direction == self::SORT_ASC ? $this->last() : $this->first();
    }

    public static function sortCurrent($cmpA, $cmpB)
    {
        return $cmpA->current <=> $cmpB->current;
    }

    public static function sortKey($cmpA, $cmpB)
    {
        return $cmpA->key <=> $cmpB->key;
    }
}