Gielfeldt\Iterators\ShuffleIterator

Complexity

Total Complexity

14

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	rewind()	0	17	5
A	generateElement()	0	4	1
A	count()	0	4	1
A	first()	0	5	2
A	last()	0	5	2
A	min()	0	4	1
A	max()	0	4	1

<?php

namespace Gielfeldt\Iterators;

class ShuffleIterator extends ReplaceableIterator implements \Countable
{
    private $min = INF;
    private $max = -INF;
    private $innerIterator;

    public function __construct(\Traversable $iterator)
    {
        $this->innerIterator = $iterator;
        parent::__construct(new \ArrayIterator());
    }

    public function rewind()
    {
        $shuffledIterator = new \ArrayIterator();
        $items = [];
        foreach ($this->innerIterator as $key => $value) {
            $items[] = $this->generateElement($key, $value, $this->innerIterator);
            $this->min = $this->min < $value ? $this->min : $value;
            $this->max = $this->max > $value ? $this->max : $value;
        }

        shuffle($items);

        foreach ($items as $data) {
            $shuffledIterator[$data->key] = $data->current;
        }
        $this->setInnerIterator($shuffledIterator);
    }

    /**
     * @param \Traversable $iterator
     */
    protected function generateElement($key, $value, $iterator)

The parameter $iterator is not used and could be removed.

    {
        return (object) ['key' => $key, 'current' => $value];
    }

    public function count()
    {
        return $this->getInnerIterator()->count();

It seems like you code against a concrete implementation and not the interface Iterator as the method count() does only exist in the following implementations of said interface: ArrayIterator, CachingIterator, Gielfeldt\Iterators\CachingIterator, Gielfeldt\Iterators\CountableIterator, Gielfeldt\Iterators\CsvFileObject, Gielfeldt\Iterators\GlobIterator, Gielfeldt\Iterators\IndexIterator, Gielfeldt\Iterators\OrderedInterleaveIterator, Gielfeldt\Iterators\RecursiveSortIterator, Gielfeldt\Iterators\RepeatIterator, Gielfeldt\Iterators\ShuffleIterator, Gielfeldt\Iterators\SortIterator, GlobIterator, HttpMessage, HttpRequestPool, Issue523, MongoCursor, MongoGridFSCursor, PHP_CodeSniffer\Files\FileList, PHP_Token_Stream, Phar, PharData, Predis\Response\Iterator\MultiBulk, Predis\Response\Iterator\MultiBulkIterator, Predis\Response\Iterator\MultiBulkTuple, RecursiveArrayIterator, RecursiveCachingIterator, SQLiteResult, SimpleXMLIterator, SplDoublyLinkedList, SplFixedArray, SplHeap, SplMaxHeap, SplMinHeap, SplObjectStorage, SplPriorityQueue, SplQueue, SplStack, TheSeer\Tokenizer\TokenCollection.

    }

    public function first()
    {
        $count = $this->getInnerIterator()->count();

It seems like you code against a concrete implementation and not the interface Iterator as the method count() does only exist in the following implementations of said interface: ArrayIterator, CachingIterator, Gielfeldt\Iterators\CachingIterator, Gielfeldt\Iterators\CountableIterator, Gielfeldt\Iterators\CsvFileObject, Gielfeldt\Iterators\GlobIterator, Gielfeldt\Iterators\IndexIterator, Gielfeldt\Iterators\OrderedInterleaveIterator, Gielfeldt\Iterators\RecursiveSortIterator, Gielfeldt\Iterators\RepeatIterator, Gielfeldt\Iterators\ShuffleIterator, Gielfeldt\Iterators\SortIterator, GlobIterator, HttpMessage, HttpRequestPool, Issue523, MongoCursor, MongoGridFSCursor, PHP_CodeSniffer\Files\FileList, PHP_Token_Stream, Phar, PharData, Predis\Response\Iterator\MultiBulk, Predis\Response\Iterator\MultiBulkIterator, Predis\Response\Iterator\MultiBulkTuple, RecursiveArrayIterator, RecursiveCachingIterator, SQLiteResult, SimpleXMLIterator, SplDoublyLinkedList, SplFixedArray, SplHeap, SplMaxHeap, SplMinHeap, SplObjectStorage, SplPriorityQueue, SplQueue, SplStack, TheSeer\Tokenizer\TokenCollection.

        return $count ? $this->getInnerIterator()[0] : null;
    }

    public function last()
    {
        $count = $this->getInnerIterator()->count();

It seems like you code against a concrete implementation and not the interface Iterator as the method count() does only exist in the following implementations of said interface: ArrayIterator, CachingIterator, Gielfeldt\Iterators\CachingIterator, Gielfeldt\Iterators\CountableIterator, Gielfeldt\Iterators\CsvFileObject, Gielfeldt\Iterators\GlobIterator, Gielfeldt\Iterators\IndexIterator, Gielfeldt\Iterators\OrderedInterleaveIterator, Gielfeldt\Iterators\RecursiveSortIterator, Gielfeldt\Iterators\RepeatIterator, Gielfeldt\Iterators\ShuffleIterator, Gielfeldt\Iterators\SortIterator, GlobIterator, HttpMessage, HttpRequestPool, Issue523, MongoCursor, MongoGridFSCursor, PHP_CodeSniffer\Files\FileList, PHP_Token_Stream, Phar, PharData, Predis\Response\Iterator\MultiBulk, Predis\Response\Iterator\MultiBulkIterator, Predis\Response\Iterator\MultiBulkTuple, RecursiveArrayIterator, RecursiveCachingIterator, SQLiteResult, SimpleXMLIterator, SplDoublyLinkedList, SplFixedArray, SplHeap, SplMaxHeap, SplMinHeap, SplObjectStorage, SplPriorityQueue, SplQueue, SplStack, TheSeer\Tokenizer\TokenCollection.

        return $count ? $this->getInnerIterator()[$count - 1] : null;
    }

    public function min()
    {
        return $this->min;
    }

    public function max()
    {
        return $this->max;
    }
}