Complex classes like Invoice often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Invoice, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
18 | class Invoice |
||
19 | { |
||
20 | use InvoiceValidator; |
||
21 | |||
22 | /** |
||
23 | * Tipo operacion (Catálogo 17). |
||
24 | * @var string |
||
25 | */ |
||
26 | private $tipoOperacion; |
||
27 | |||
28 | /** |
||
29 | * @Assert\NotBlank() |
||
30 | * @Assert\Length(max="2") |
||
31 | * @var string |
||
32 | */ |
||
33 | private $tipoDoc; |
||
34 | |||
35 | /** |
||
36 | * @Assert\NotBlank() |
||
37 | * @Assert\Length(max="4") |
||
38 | * @var string |
||
39 | */ |
||
40 | private $serie; |
||
41 | |||
42 | /** |
||
43 | * @Assert\NotBlank() |
||
44 | * @Assert\Length(max="8") |
||
45 | * @var string |
||
46 | */ |
||
47 | private $correlativo; |
||
48 | |||
49 | /** |
||
50 | * @Assert\Date() |
||
51 | * @var \DateTime |
||
52 | */ |
||
53 | private $fechaEmision; |
||
54 | |||
55 | /** |
||
56 | * @Assert\NotBlank() |
||
57 | * @Assert\Length(max="1") |
||
58 | * @var string |
||
59 | */ |
||
60 | private $tipoDocUsuario; |
||
61 | |||
62 | /** |
||
63 | * @Assert\NotBlank() |
||
64 | * @Assert\Length(max="15") |
||
65 | * @var string |
||
66 | */ |
||
67 | private $numDocUsuario; |
||
68 | |||
69 | /** |
||
70 | * @Assert\NotBlank() |
||
71 | * @Assert\Length(max="100") |
||
72 | * @var string |
||
73 | */ |
||
74 | private $rznSocialUsuario; |
||
75 | |||
76 | /** |
||
77 | * @Assert\Length(max="100") |
||
78 | * @var string |
||
79 | */ |
||
80 | private $direccionUsuario; |
||
81 | /** |
||
82 | * @Assert\NotBlank() |
||
83 | * @Assert\Length(max="3") |
||
84 | * @var string |
||
85 | */ |
||
86 | private $tipoMoneda; |
||
87 | |||
88 | /** |
||
89 | * @var float |
||
90 | */ |
||
91 | private $sumDsctoGlobal; |
||
92 | |||
93 | /** |
||
94 | * @var float |
||
95 | */ |
||
96 | private $sumOtrosCargos; |
||
97 | |||
98 | /** |
||
99 | * @var float |
||
100 | */ |
||
101 | private $mtoDescuentos; |
||
102 | |||
103 | /** |
||
104 | * @Assert\NotBlank() |
||
105 | * @var float |
||
106 | */ |
||
107 | private $mtoOperGravadas; |
||
108 | |||
109 | /** |
||
110 | * @Assert\NotBlank() |
||
111 | * @var float |
||
112 | */ |
||
113 | private $mtoOperInafectas; |
||
114 | |||
115 | /** |
||
116 | * @Assert\NotBlank() |
||
117 | * @var float |
||
118 | */ |
||
119 | private $mtoOperExoneradas; |
||
120 | |||
121 | /** |
||
122 | * @var float |
||
123 | */ |
||
124 | private $mtoOperGratuitas; |
||
125 | |||
126 | /** |
||
127 | * @var float |
||
128 | */ |
||
129 | private $mtoIGV; |
||
130 | |||
131 | /** |
||
132 | * @var float |
||
133 | */ |
||
134 | private $mtoISC; |
||
135 | |||
136 | /** |
||
137 | * @var float |
||
138 | */ |
||
139 | private $mtoOtrosTributos; |
||
140 | |||
141 | /** |
||
142 | * Importe total de la venta, cesión en uso o del servicio prestado. |
||
143 | * |
||
144 | * @Assert\NotBlank() |
||
145 | * @var float |
||
146 | */ |
||
147 | private $mtoImpVenta; |
||
148 | |||
149 | /** |
||
150 | * @var string |
||
151 | */ |
||
152 | private $codRegPercepcion; |
||
153 | |||
154 | /** |
||
155 | * @var float |
||
156 | */ |
||
157 | private $mtoBaseImponiblePercepcion; |
||
158 | |||
159 | /** |
||
160 | * @var float |
||
161 | */ |
||
162 | private $mtoPercepcion; |
||
163 | |||
164 | /** |
||
165 | * @var float |
||
166 | */ |
||
167 | private $mtoTotalIncPercepcion; |
||
168 | |||
169 | private $TipoDocGuia; |
||
170 | |||
171 | private $NumDocGuia; |
||
172 | |||
173 | /** |
||
174 | * @Assert\Valid() |
||
175 | * @var SaleDetail[] |
||
176 | */ |
||
177 | private $details; |
||
178 | |||
179 | /** |
||
180 | * @return string |
||
181 | */ |
||
182 | 2 | public function getTipoOperacion() |
|
183 | { |
||
184 | 2 | return $this->tipoOperacion; |
|
185 | } |
||
186 | |||
187 | /** |
||
188 | * @param string $tipoOperacion |
||
189 | * @return Invoice |
||
190 | */ |
||
191 | public function setTipoOperacion($tipoOperacion) |
||
196 | |||
197 | /** |
||
198 | * @return string |
||
199 | */ |
||
200 | 2 | public function getTipoDoc() |
|
204 | |||
205 | /** |
||
206 | * @param string $tipoDoc |
||
207 | * @return Invoice |
||
208 | */ |
||
209 | 4 | public function setTipoDoc($tipoDoc) |
|
214 | |||
215 | /** |
||
216 | * @return string |
||
217 | */ |
||
218 | 2 | public function getSerie() |
|
222 | |||
223 | /** |
||
224 | * @param string $serie |
||
225 | * @return Invoice |
||
226 | */ |
||
227 | 4 | public function setSerie($serie) |
|
232 | |||
233 | /** |
||
234 | * @return string |
||
235 | */ |
||
236 | 2 | public function getCorrelativo() |
|
240 | |||
241 | /** |
||
242 | * @param string $correlativo |
||
243 | * @return Invoice |
||
244 | */ |
||
245 | 4 | public function setCorrelativo($correlativo) |
|
250 | |||
251 | /** |
||
252 | * @return \DateTime |
||
253 | */ |
||
254 | 2 | public function getFechaEmision() |
|
258 | |||
259 | /** |
||
260 | * @param \DateTime $fechaEmision |
||
261 | * @return Invoice |
||
262 | */ |
||
263 | public function setFechaEmision($fechaEmision) |
||
268 | |||
269 | /** |
||
270 | * @return string |
||
271 | */ |
||
272 | 2 | public function getTipoDocUsuario() |
|
276 | |||
277 | /** |
||
278 | * @param string $tipoDocUsuario |
||
279 | * @return Invoice |
||
280 | */ |
||
281 | 4 | public function setTipoDocUsuario($tipoDocUsuario) |
|
286 | |||
287 | /** |
||
288 | * @return string |
||
289 | */ |
||
290 | 2 | public function getNumDocUsuario() |
|
294 | |||
295 | /** |
||
296 | * @param string $numDocUsuario |
||
297 | * @return Invoice |
||
298 | */ |
||
299 | 4 | public function setNumDocUsuario($numDocUsuario) |
|
304 | |||
305 | /** |
||
306 | * @return string |
||
307 | */ |
||
308 | 2 | public function getRznSocialUsuario() |
|
312 | |||
313 | /** |
||
314 | * @param string $rznSocialUsuario |
||
315 | * @return Invoice |
||
316 | */ |
||
317 | 4 | public function setRznSocialUsuario($rznSocialUsuario) |
|
322 | |||
323 | /** |
||
324 | * @return string |
||
325 | */ |
||
326 | 2 | public function getDireccionUsuario() |
|
330 | |||
331 | /** |
||
332 | * @param string $direccionUsuario |
||
333 | * @return Invoice |
||
334 | */ |
||
335 | public function setDireccionUsuario($direccionUsuario) |
||
340 | |||
341 | /** |
||
342 | * @return mixed |
||
343 | */ |
||
344 | 2 | public function getTipoMoneda() |
|
348 | |||
349 | /** |
||
350 | * @param mixed $tipoMoneda |
||
351 | * @return Invoice |
||
352 | */ |
||
353 | 4 | public function setTipoMoneda($tipoMoneda) |
|
358 | |||
359 | /** |
||
360 | * @return float |
||
361 | */ |
||
362 | 2 | public function getSumDsctoGlobal() |
|
366 | |||
367 | /** |
||
368 | * @param float $sumDsctoGlobal |
||
369 | * @return Invoice |
||
370 | */ |
||
371 | public function setSumDsctoGlobal($sumDsctoGlobal) |
||
376 | |||
377 | /** |
||
378 | * @return float |
||
379 | */ |
||
380 | 2 | public function getSumOtrosCargos() |
|
384 | |||
385 | /** |
||
386 | * @param float $sumOtrosCargos |
||
387 | * @return Invoice |
||
388 | */ |
||
389 | public function setSumOtrosCargos($sumOtrosCargos) |
||
394 | |||
395 | /** |
||
396 | * @return mixed |
||
397 | */ |
||
398 | 2 | public function getMtoDescuentos() |
|
402 | |||
403 | /** |
||
404 | * @param mixed $mtoDescuentos |
||
405 | * @return Invoice |
||
406 | */ |
||
407 | public function setMtoDescuentos($mtoDescuentos) |
||
412 | |||
413 | /** |
||
414 | * @return float |
||
415 | */ |
||
416 | 2 | public function getMtoOperGravadas() |
|
420 | |||
421 | /** |
||
422 | * @param float $mtoOperGravadas |
||
423 | * @return Invoice |
||
424 | */ |
||
425 | 4 | public function setMtoOperGravadas($mtoOperGravadas) |
|
430 | |||
431 | /** |
||
432 | * @return float |
||
433 | */ |
||
434 | 2 | public function getMtoOperInafectas() |
|
438 | |||
439 | /** |
||
440 | * @param float $mtoOperInafectas |
||
441 | * @return Invoice |
||
442 | */ |
||
443 | 4 | public function setMtoOperInafectas($mtoOperInafectas) |
|
448 | |||
449 | /** |
||
450 | * @return mixed |
||
451 | */ |
||
452 | 2 | public function getMtoOperExoneradas() |
|
456 | |||
457 | /** |
||
458 | * @param mixed $mtoOperExoneradas |
||
459 | * @return Invoice |
||
460 | */ |
||
461 | 4 | public function setMtoOperExoneradas($mtoOperExoneradas) |
|
466 | |||
467 | /** |
||
468 | * @return float |
||
469 | */ |
||
470 | 2 | public function getMtoOperGratuitas() |
|
474 | |||
475 | /** |
||
476 | * @param float $mtoOperGratuitas |
||
477 | * @return Invoice |
||
478 | */ |
||
479 | public function setMtoOperGratuitas($mtoOperGratuitas) |
||
484 | |||
485 | /** |
||
486 | * @return float |
||
487 | */ |
||
488 | 2 | public function getMtoIGV() |
|
492 | |||
493 | /** |
||
494 | * @param float $mtoIGV |
||
495 | * @return Invoice |
||
496 | */ |
||
497 | 4 | public function setMtoIGV($mtoIGV) |
|
502 | |||
503 | /** |
||
504 | * @return float |
||
505 | */ |
||
506 | 2 | public function getMtoISC() |
|
510 | |||
511 | /** |
||
512 | * @param float $mtoISC |
||
513 | * @return Invoice |
||
514 | */ |
||
515 | public function setMtoISC($mtoISC) |
||
520 | |||
521 | /** |
||
522 | * @return float |
||
523 | */ |
||
524 | 2 | public function getMtoOtrosTributos() |
|
528 | |||
529 | /** |
||
530 | * @param float $mtoOtrosTributos |
||
531 | * @return Invoice |
||
532 | */ |
||
533 | public function setMtoOtrosTributos($mtoOtrosTributos) |
||
538 | |||
539 | /** |
||
540 | * @return float |
||
541 | */ |
||
542 | 2 | public function getMtoImpVenta() |
|
546 | |||
547 | /** |
||
548 | * @param float $mtoImpVenta |
||
549 | * @return Invoice |
||
550 | */ |
||
551 | 4 | public function setMtoImpVenta($mtoImpVenta) |
|
556 | |||
557 | /** |
||
558 | * @return string |
||
559 | */ |
||
560 | public function getCodRegPercepcion() |
||
564 | |||
565 | /** |
||
566 | * @param string $codRegPercepcion |
||
567 | * @return Invoice |
||
568 | */ |
||
569 | public function setCodRegPercepcion($codRegPercepcion) |
||
574 | |||
575 | /** |
||
576 | * @return float |
||
577 | */ |
||
578 | 2 | public function getMtoBaseImponiblePercepcion() |
|
582 | |||
583 | /** |
||
584 | * @param float $mtoBaseImponiblePercepcion |
||
585 | * @return Invoice |
||
586 | */ |
||
587 | public function setMtoBaseImponiblePercepcion($mtoBaseImponiblePercepcion) |
||
592 | |||
593 | /** |
||
594 | * @return float |
||
595 | */ |
||
596 | public function getMtoPercepcion() |
||
600 | |||
601 | /** |
||
602 | * @param float $mtoPercepcion |
||
603 | * @return Invoice |
||
604 | */ |
||
605 | public function setMtoPercepcion($mtoPercepcion) |
||
610 | |||
611 | /** |
||
612 | * @return float |
||
613 | */ |
||
614 | public function getMtoTotalIncPercepcion() |
||
618 | |||
619 | /** |
||
620 | * @param float $mtoTotalIncPercepcion |
||
621 | * @return Invoice |
||
622 | */ |
||
623 | public function setMtoTotalIncPercepcion($mtoTotalIncPercepcion) |
||
628 | |||
629 | /** |
||
630 | * @return mixed |
||
631 | */ |
||
632 | public function getTipoDocGuia() |
||
636 | |||
637 | /** |
||
638 | * @param mixed $TipoDocGuia |
||
639 | * @return Invoice |
||
640 | */ |
||
641 | public function setTipoDocGuia($TipoDocGuia) |
||
646 | |||
647 | /** |
||
648 | * @return mixed |
||
649 | */ |
||
650 | public function getNumDocGuia() |
||
654 | |||
655 | /** |
||
656 | * @param mixed $NumDocGuia |
||
657 | * @return Invoice |
||
658 | */ |
||
659 | public function setNumDocGuia($NumDocGuia) |
||
664 | |||
665 | /** |
||
666 | * @return SaleDetail[] |
||
667 | */ |
||
668 | 2 | public function getDetails() |
|
672 | |||
673 | /** |
||
674 | * @param SaleDetail[] $details |
||
675 | * @return Invoice |
||
676 | */ |
||
677 | 4 | public function setDetails($details) |
|
682 | |||
683 | } |