XmlErrorReader::getMessageByCode() - Code Metrics - Inspection of "update phpunit + Remove unused namespaces" - giansalex/greenter - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( a47c2b...4d6576 )

by Giancarlos

created 2017-10-04 20:11 UTC

XmlErrorReader::getMessageByCode() A

↳ Parent: XmlErrorReader

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2.0078

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	7
cts	8
cp	0.875
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	8
nc	2
nop	1
crap	2.0078

<?php
/**
 * Created by PhpStorm.
 * User: Giansalex
 * Date: 22/07/2017
 * Time: 16:09
 */

namespace Greenter\Ws\Reader;

/**
 * Class XmlCodeErrorReader
 * @package Greenter\Ws\Reader
 */
class XmlErrorReader implements ErrorReader
{
    private $xmlErrorFile = __DIR__ . '/../../Resources/CodeErrors.xml';

    /**
     * Get Error Message by code.
     * @param string $code
     * @return string
     */
    public function getMessageByCode($code)
    {
        $doc = new \DOMDocument();
        $doc->load($this->xmlErrorFile);
        $xpath = new \DOMXPath($doc);
        $nodes = $xpath->query("/errors/error[@code='$code']");

        if ($nodes->length !== 1) {
            return '';
        }

        return $nodes[0]->nodeValue;
    }

    /**
     * Cambia el archivo de busqueda de errores por defecto.
     *
     * @param $xmlErrorFile
     * @return $this
     * @throws \Exception
     */
    public function setXmlErrorFile($xmlErrorFile)
    {
        if (!file_exists($xmlErrorFile)) {
            throw new \Exception("Archivo de errores no existe");
        }
        $this->xmlErrorFile = $xmlErrorFile;
        return $this;
    }
}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: Giansalex
5		* Date: 22/07/2017
6		* Time: 16:09
7		*/
8
9		namespace Greenter\Ws\Reader;
10
11		/**
12		* Class XmlCodeErrorReader
13		* @package Greenter\Ws\Reader
14		*/
15		class XmlErrorReader implements ErrorReader
16		{
17		private $xmlErrorFile = __DIR__ . '/../../Resources/CodeErrors.xml';
18
19		/**
20		* Get Error Message by code.
21		* @param string $code
22		* @return string
23		*/
24	14	public function getMessageByCode($code)
25		{
26	14	$doc = new \DOMDocument();
27	14	$doc->load($this->xmlErrorFile);
28	14	$xpath = new \DOMXPath($doc);
29	14	$nodes = $xpath->query("/errors/error[@code='$code']");
30
31	14	if ($nodes->length !== 1) {
32		return '';
33		}
34
35	14	return $nodes[0]->nodeValue;
36		}
37
38		/**
39		* Cambia el archivo de busqueda de errores por defecto.
40		*
41		* @param $xmlErrorFile
42		* @return $this
43		* @throws \Exception
44		*/
45		public function setXmlErrorFile($xmlErrorFile)
46		{
47		if (!file_exists($xmlErrorFile)) {
48		throw new \Exception("Archivo de errores no existe");
49		}
50		$this->xmlErrorFile = $xmlErrorFile;
51		return $this;
52		}
53		}

giansalex / greenter

Push — master ( a47c2b...4d6576 )

XmlErrorReader::getMessageByCode() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like