Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 23 | class CeFactory extends BaseFactory implements CeFactoryInterface |
||
| 24 | { |
||
| 25 | /** |
||
| 26 | * @var CeBuilderInterface |
||
| 27 | */ |
||
| 28 | private $builder; |
||
| 29 | |||
| 30 | /** |
||
| 31 | * @var bool |
||
| 32 | */ |
||
| 33 | private $isProd; |
||
| 34 | |||
| 35 | /** |
||
| 36 | * CeFactory constructor. |
||
| 37 | */ |
||
| 38 | 20 | public function __construct() |
|
| 43 | |||
| 44 | /** |
||
| 45 | * Envia una Guia de Remision. |
||
| 46 | * |
||
| 47 | * @param Despatch $despatch |
||
| 48 | * @return BillResult |
||
| 49 | */ |
||
| 50 | 4 | View Code Duplication | public function sendDispatch(Despatch $despatch) |
| 58 | |||
| 59 | /** |
||
| 60 | * Envia una Retencion. |
||
| 61 | * |
||
| 62 | * @param Retention $retention |
||
| 63 | * @return BillResult |
||
| 64 | */ |
||
| 65 | 4 | View Code Duplication | public function sendRetention(Retention $retention) |
| 73 | |||
| 74 | /** |
||
| 75 | * Envia una Percepcion. |
||
| 76 | * |
||
| 77 | * @param Perception $perception |
||
| 78 | * @return BillResult |
||
| 79 | */ |
||
| 80 | 6 | View Code Duplication | public function sendPerception(Perception $perception) |
| 88 | |||
| 89 | /** |
||
| 90 | * Envia una Resumen de Reversiones. |
||
| 91 | * |
||
| 92 | * @param Reversion $reversion |
||
| 93 | * @return SummaryResult |
||
| 94 | */ |
||
| 95 | 4 | View Code Duplication | public function sendReversion(Reversion $reversion) |
| 103 | |||
| 104 | /** |
||
| 105 | * Get Status by Ticket. |
||
| 106 | * |
||
| 107 | * @param string $ticket |
||
| 108 | * @return StatusResult |
||
| 109 | */ |
||
| 110 | 2 | public function getStatus($ticket) |
|
| 115 | |||
| 116 | /** |
||
| 117 | * Get Last XML Signed. |
||
| 118 | * |
||
| 119 | * @return string |
||
| 120 | */ |
||
| 121 | public function getLastXml() |
||
| 125 | |||
| 126 | /** |
||
| 127 | * Set Company |
||
| 128 | * |
||
| 129 | * @param $company |
||
| 130 | * @return $this |
||
| 131 | */ |
||
| 132 | 20 | public function setCompany(Company $company) |
|
| 139 | |||
| 140 | /** |
||
| 141 | * @param array $params |
||
| 142 | */ |
||
| 143 | 20 | View Code Duplication | public function setParameters($params) |
| 155 | |||
| 156 | 12 | private function setService($isGuia = false) |
|
| 165 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.