VoidedDetailValidator::loadValidatorMetadata() - Code Metrics - Inspection of "Add voided Header & Detail + Validators" - giansalex/greenter - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 641a53...544fde )

by Giancarlos

created 2017-07-18 22:53 UTC

VoidedDetailValidator::loadValidatorMetadata() A

↳ Parent: VoidedDetailValidator

Complexity

Conditions	1
Paths	1

Size

Total Lines	22
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	22
ccs	0
cts	22
cp	0
rs	9.2
cc	1
eloc	15
nc	1
nop	1
crap	2

<?php
/**
 * Created by PhpStorm.
 * User: Administrador
 * Date: 18/07/2017
 * Time: 01:21 PM
 */

namespace Greenter\Xml\Validator;

use Symfony\Component\Validator\Mapping\ClassMetadata;
use Symfony\Component\Validator\Constraints as Assert;

/**
 * Trait VoidedDetailValidator
 * @package Greenter\Xml\Validator
 */
trait VoidedDetailValidator
{
    public static function loadValidatorMetadata(ClassMetadata $metadata)
    {
        $metadata->addPropertyConstraints('tipoDoc', [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            new Assert(),
            new Assert\Length([
                'min' => 2,
                'max' => 2,
            ]),
        ]);
        $metadata->addPropertyConstraints('serie', [
            new Assert\NotBlank(),
            new Assert\Length([ 'max' => 4]),
        ]);
        $metadata->addPropertyConstraints('correlativo', [
            new Assert\NotBlank(),
            new Assert\Length(['max' => 8]),
        ]);
        $metadata->addPropertyConstraints('desMotivoBaja', [
            new Assert\NotBlank(),
            new Assert\Length(['max' => 100]),
        ]);
    }
}

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: Administrador
5			* Date: 18/07/2017
6			* Time: 01:21 PM
7			*/
8
9			namespace Greenter\Xml\Validator;
10
11			use Symfony\Component\Validator\Mapping\ClassMetadata;
12			use Symfony\Component\Validator\Constraints as Assert;
13
14			/**
15			* Trait VoidedDetailValidator
16			* @package Greenter\Xml\Validator
17			*/
18			trait VoidedDetailValidator
19			{
20			public static function loadValidatorMetadata(ClassMetadata $metadata)
21			{
22			$metadata->addPropertyConstraints('tipoDoc', [
			0 ignored issues – show Documentation introduced 2017-07-18 22:55 UTC by Report Bug Copy Issue Report `array(new \Symfony\Compo...in' => 2, 'max' => 2)))` is of type `array<integer,object<Sym...Constraints\\Length>"}>`, but the function expects a `array<integer,object<Sym...\Validator\Constraint>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
23			new Assert(),
24			new Assert\Length([
25			'min' => 2,
26			'max' => 2,
27			]),
28			]);
29			$metadata->addPropertyConstraints('serie', [
30			new Assert\NotBlank(),
31			new Assert\Length([ 'max' => 4]),
32			]);
33			$metadata->addPropertyConstraints('correlativo', [
34			new Assert\NotBlank(),
35			new Assert\Length(['max' => 8]),
36			]);
37			$metadata->addPropertyConstraints('desMotivoBaja', [
38			new Assert\NotBlank(),
39			new Assert\Length(['max' => 100]),
40			]);
41			}
42			}

giansalex / greenter

Push — master ( 641a53...544fde )

VoidedDetailValidator::loadValidatorMetadata() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like