XmlUtils::getHashSignFromFile() - Code Metrics - Inspection of "fix get hash from signed xml" - giansalex/greenter-report - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c962a4...aa471d )

by Giancarlos

created 2018-01-25 22:14 UTC

XmlUtils::getHashSignFromFile() A

↳ Parent: XmlUtils

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	4
cts	4
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	1
crap	1

<?php
/**
 * Created by PhpStorm.
 * User: Administrador
 * Date: 04/10/2017
 * Time: 04:41 PM.
 */

namespace Greenter\Report;

/**
 * Class XmlUtils.
 */
final class XmlUtils
{
    const EXT_NAMESPACE = 'urn:oasis:names:specification:ubl:schema:xsd:CommonExtensionComponents-2';
    const DS_NAMESPACE = 'http://www.w3.org/2000/09/xmldsig#';

    /**
     * @param string $xml
     *
     * @return string
     */
    public function getHashSign($xml)
    {
        $doc = new \DOMDocument();
        @$doc->loadXML($xml);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        return $this->getHashSignFromDoc($doc);
    }

    /**
     * @param string $filename
     *
     * @return string
     */
    public function getHashSignFromFile($filename)
    {
        $doc = new \DOMDocument();
        @$doc->load($filename);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        return $this->getHashSignFromDoc($doc);
    }

    /**
     * @param \DOMDocument $document
     *
     * @return string
     */
    public function getHashSignFromDoc(\DOMDocument $document)
    {
        $xpt = $this->getXpath($document);

        $exts = $xpt->query('ext:UBLExtensions/ext:UBLExtension', $document->documentElement);
        if ($exts->length == 0) {
            return '';
        }

        return $this->getHash($exts, $xpt);
    }

    /**
     * @param \DOMDocument $document
     *
     * @return \DOMXPath
     */
    public function getXpath(\DOMDocument $document)
    {
        $xpt = new \DOMXPath($document);
        $xpt->registerNamespace('ext', self::EXT_NAMESPACE);
        $xpt->registerNamespace('ds', self::DS_NAMESPACE);

        return $xpt;
    }

    /**
     * @param \DOMNodeList $exts
     * @param \DOMXPath $xpt
     * @return string
     */
    public function getHash(\DOMNodeList $exts, \DOMXPath $xpt)
    {
        for ($i = $exts->length; $i-- > 0;) {
            $nodeSign = $exts->item($i);
            $hash = $xpt->query('ext:ExtensionContent/ds:Signature/ds:SignedInfo/ds:Reference/ds:DigestValue', $nodeSign);

            if ($hash->length == 0) {
                continue;
            }

            return $hash->item(0)->nodeValue;
        }

        return '';
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: Administrador
5		* Date: 04/10/2017
6		* Time: 04:41 PM.
7		*/
8
9		namespace Greenter\Report;
10
11		/**
12		* Class XmlUtils.
13		*/
14		final class XmlUtils
15		{
16		const EXT_NAMESPACE = 'urn:oasis:names:specification:ubl:schema:xsd:CommonExtensionComponents-2';
17		const DS_NAMESPACE = 'http://www.w3.org/2000/09/xmldsig#';
18
19		/**
20		* @param string $xml
21		*
22		* @return string
23		*/
24	8	public function getHashSign($xml)
25		{
26	8	$doc = new \DOMDocument();
27	8	@$doc->loadXML($xml);
		0 ignored issues – show Security Best Practice introduced 2018-01-25 22:17 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
28
29	8	return $this->getHashSignFromDoc($doc);
30		}
31
32		/**
33		* @param string $filename
34		*
35		* @return string
36		*/
37	8	public function getHashSignFromFile($filename)
38		{
39	8	$doc = new \DOMDocument();
40	8	@$doc->load($filename);
		0 ignored issues – show Security Best Practice introduced 2018-01-25 22:17 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
41
42	8	return $this->getHashSignFromDoc($doc);
43		}
44
45		/**
46		* @param \DOMDocument $document
47		*
48		* @return string
49		*/
50	22	public function getHashSignFromDoc(\DOMDocument $document)
51		{
52	22	$xpt = $this->getXpath($document);
53
54	22	$exts = $xpt->query('ext:UBLExtensions/ext:UBLExtension', $document->documentElement);
55	22	if ($exts->length == 0) {
56	2	return '';
57		}
58
59	20	return $this->getHash($exts, $xpt);
60		}
61
62		/**
63		* @param \DOMDocument $document
64		*
65		* @return \DOMXPath
66		*/
67	22	public function getXpath(\DOMDocument $document)
68		{
69	22	$xpt = new \DOMXPath($document);
70	22	$xpt->registerNamespace('ext', self::EXT_NAMESPACE);
71	22	$xpt->registerNamespace('ds', self::DS_NAMESPACE);
72
73	22	return $xpt;
74		}
75
76		/**
77		* @param \DOMNodeList $exts
78		* @param \DOMXPath $xpt
79		* @return string
80		*/
81	20	public function getHash(\DOMNodeList $exts, \DOMXPath $xpt)
82		{
83	20	for ($i = $exts->length; $i-- > 0;) {
84	20	$nodeSign = $exts->item($i);
85	20	$hash = $xpt->query('ext:ExtensionContent/ds:Signature/ds:SignedInfo/ds:Reference/ds:DigestValue', $nodeSign);
86
87	20	if ($hash->length == 0) {
88	8	continue;
89		}
90
91	18	return $hash->item(0)->nodeValue;
92		}
93
94	2	return '';
95		}
96		}
97

giansalex / greenter-report

Push — master ( c962a4...aa471d )

XmlUtils::getHashSignFromFile() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like