Greenter\Report\XmlUtils

Complexity

Total Complexity

8

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getHashSignFromFile()	0	6	1
A	getHash()	0	14	3
A	getXpath()	0	7	1
A	getHashSignFromDoc()	0	10	2
A	getHashSign()	0	6	1

<?php
/**
 * Created by PhpStorm.
 * User: Administrador
 * Date: 04/10/2017
 * Time: 04:41 PM.
 */

namespace Greenter\Report;

/**
 * Class XmlUtils.
 */
final class XmlUtils
{
    const EXT_NAMESPACE = 'urn:oasis:names:specification:ubl:schema:xsd:CommonExtensionComponents-2';
    const DS_NAMESPACE = 'http://www.w3.org/2000/09/xmldsig#';
    const DIGEST_QUERY = 'ext:ExtensionContent/ds:Signature/ds:SignedInfo/ds:Reference/ds:DigestValue';

    /**
     * @param string $xml
     *
     * @return string
     */
    public function getHashSign($xml)
    {
        $doc = new \DOMDocument();
        @$doc->loadXML($xml);

It seems like you do not handle an error condition for loadXML(). This can introduce security issues, and is generally not recommended.

        return $this->getHashSignFromDoc($doc);
    }

    /**
     * @param string $filename
     *
     * @return string
     */
    public function getHashSignFromFile($filename)
    {
        $doc = new \DOMDocument();
        @$doc->load($filename);

It seems like you do not handle an error condition for load(). This can introduce security issues, and is generally not recommended.

        return $this->getHashSignFromDoc($doc);
    }

    /**
     * @param \DOMDocument $document
     *
     * @return string
     */
    public function getHashSignFromDoc(\DOMDocument $document)
    {
        $xpt = $this->getXpath($document);

        $exts = $xpt->query('ext:UBLExtensions/ext:UBLExtension', $document->documentElement);
        if ($exts->length == 0) {
            return '';
        }

        return $this->getHash($exts, $xpt);

It seems like $exts can also be of type false; however, parameter $exts of Greenter\Report\XmlUtils::getHash() does only seem to accept DOMNodeList, maybe add an additional type check?

    }

    /**
     * @param \DOMDocument $document
     *
     * @return \DOMXPath
     */
    private function getXpath(\DOMDocument $document)
    {
        $xpt = new \DOMXPath($document);
        $xpt->registerNamespace('ext', self::EXT_NAMESPACE);
        $xpt->registerNamespace('ds', self::DS_NAMESPACE);

        return $xpt;
    }

    /**
     * @param \DOMNodeList $exts
     * @param \DOMXPath $xpt
     * @return string
     */
    private function getHash(\DOMNodeList $exts, \DOMXPath $xpt)
    {
        for ($i = $exts->length; $i-- > 0;) {
            $nodeSign = $exts->item($i);
            $hash = $xpt->query(self::DIGEST_QUERY, $nodeSign);

            if ($hash->length == 0) {
                continue;
            }

            return $hash->item(0)->nodeValue;
        }

        return '';
    }
}