View GitHub Repository console-skeleton-app

Schedule Inspection
Subscribe
Completed
Push — master ( 09d75e...7a4c9e )
by Gianluca
05:46 queued 01:44
created

Hello::run()   A

↳ Parent: Hello

Complexity

Conditions 1
Paths 1

Size

Total Lines 6
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Importance

Changes 2
Bugs 0 Features 0
Metric Value
cc 1
eloc 4
c 2
b 0
f 0
nc 1
nop 3
dl 0
loc 6
rs 9.4285
1 
<?php
2 
namespace App\Command;
3 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                
use ZF\Console\Route;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
use Zend\Console\Adapter\AdapterInterface;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
class Hello

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
{

            


            
                                                        
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
    public static function run(Route $route, AdapterInterface $console, $container)

            


            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
        $serviceManager = $container->get("service_manager");

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Unused Code
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
$serviceManager is not used, you could remove the assignment.
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check looks for variable assignements that are either overwritten by other
assignments or where the variable is not used subsequently.


$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}





Both the $myVar assignment in line 1 and the $higher assignment in line 2
are dead. The first because $myVar is never used and the second because
$higher is always overwritten for every possible time line.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
        $name = $route->getMatchedParam("name", "@gianarb");

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
        $console->writeLine("Hi {$name}, you have call me. Now this is an awesome day!");

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    16