ggoffy / wggithub

class/Github/exceptions.php

Indentation +114 added lines, -114 removed lines

@@ -8,169 +8,169 @@
  */
 
 namespace XoopsModules\Wggithub\Github\ {
-	/**
-	 * Marker interface.
-	 */
-	interface IException
-	{}
+    /**
+     * Marker interface.
+     */
+    interface IException
+    {}
 
 
-	/**
-	 * Wrong algorithm. API is used in wrong way. Application code should be changed.
-	 */
-	class LogicException extends \LogicException implements IException
-	{}
+    /**
+     * Wrong algorithm. API is used in wrong way. Application code should be changed.
+     */
+    class LogicException extends \LogicException implements IException
+    {}
 
 
-	/**
-	 * Substitution is used in URL path but corresponding parameter is missing.
-	 */
-	class MissingParameterException extends LogicException
-	{}
+    /**
+     * Substitution is used in URL path but corresponding parameter is missing.
+     */
+    class MissingParameterException extends LogicException
+    {}
 
 
-	/**
-	 * Unpredictable situation occurred.
-	 */
-	abstract class RuntimeException extends \RuntimeException implements IException
-	{}
+    /**
+     * Unpredictable situation occurred.
+     */
+    abstract class RuntimeException extends \RuntimeException implements IException
+    {}
 
 
-	/**
-	 * Github API returned a non-success HTTP code or data are somehow wrong. See all following descendants.
-	 *
-	 * @see Api::decode()
-	 * @see https://developer.github.com/v3/#client-errors
-	 */
-	abstract class ApiException extends RuntimeException
-	{
-		/** @var Http\Response|NULL */
-		private $response;
+    /**
+     * Github API returned a non-success HTTP code or data are somehow wrong. See all following descendants.
+     *
+     * @see Api::decode()
+     * @see https://developer.github.com/v3/#client-errors
+     */
+    abstract class ApiException extends RuntimeException
+    {
+        /** @var Http\Response|NULL */
+        private $response;
 
 
-		/**
-		 * @param string
-		 * @param int
-		 */
-		public function __construct($message = '', $code = 0, \Exception $previous = NULL, Http\Response $response = NULL)
-		{
-			parent::__construct($message, $code, $previous);
-			$this->response = clone $response;
-		}
+        /**
+         * @param string
+         * @param int
+         */
+        public function __construct($message = '', $code = 0, \Exception $previous = NULL, Http\Response $response = NULL)
+        {
+            parent::__construct($message, $code, $previous);
+            $this->response = clone $response;
+        }
 
 
-		/**
-		 * @return Http\Response|NULL
-		 */
-		final public function getResponse()
-		{
-			return $this->response;
-		}
+        /**
+         * @return Http\Response|NULL
+         */
+        final public function getResponse()
+        {
+            return $this->response;
+        }
 
-	}
+    }
 
 
-	/**
-	 * Invalid credentials (e.g. revoked token).
-	 */
-	class UnauthorizedException extends ApiException
-	{}
+    /**
+     * Invalid credentials (e.g. revoked token).
+     */
+    class UnauthorizedException extends ApiException
+    {}
 
 
-	/**
-	 * Invalid JSON sent to Github API.
-	 */
-	class BadRequestException extends ApiException
-	{}
+    /**
+     * Invalid JSON sent to Github API.
+     */
+    class BadRequestException extends ApiException
+    {}
 
 
-	/**
-	 * Invalid structure sent to Github API (e.g. some required fields are missing).
-	 */
-	class UnprocessableEntityException extends ApiException
-	{}
+    /**
+     * Invalid structure sent to Github API (e.g. some required fields are missing).
+     */
+    class UnprocessableEntityException extends ApiException
+    {}
 
 
-	/**
-	 * Access denied.
-	 * @see https://developer.github.com/v3/#authentication
-	 */
-	class ForbiddenException extends ApiException
-	{}
+    /**
+     * Access denied.
+     * @see https://developer.github.com/v3/#authentication
+     */
+    class ForbiddenException extends ApiException
+    {}
 
 
-	/**
-	 * Rate limit exceed.
-	 * @see https://developer.github.com/v3/#rate-limiting
-	 */
-	class RateLimitExceedException extends ForbiddenException
-	{}
+    /**
+     * Rate limit exceed.
+     * @see https://developer.github.com/v3/#rate-limiting
+     */
+    class RateLimitExceedException extends ForbiddenException
+    {}
 
 
-	/**
-	 * Resource not found.
-	 * @see https://developer.github.com/v3/#authentication
-	 */
-	class NotFoundException extends ApiException
-	{}
+    /**
+     * Resource not found.
+     * @see https://developer.github.com/v3/#authentication
+     */
+    class NotFoundException extends ApiException
+    {}
 
 
-	/**
-	 * Response cannot be classified.
-	 */
-	class UnexpectedResponseException extends ApiException
-	{}
+    /**
+     * Response cannot be classified.
+     */
+    class UnexpectedResponseException extends ApiException
+    {}
 
 
-	/**
-	 * Response from Github is somehow wrong (e.g. invalid JSON decoding).
-	 */
-	class InvalidResponseException extends ApiException
-	{}
+    /**
+     * Response from Github is somehow wrong (e.g. invalid JSON decoding).
+     */
+    class InvalidResponseException extends ApiException
+    {}
 
 
-	/**
-	 * JSON cannot be decoded, or value cannot be encoded to JSON.
-	 */
-	class JsonException extends RuntimeException
-	{
-	}
+    /**
+     * JSON cannot be decoded, or value cannot be encoded to JSON.
+     */
+    class JsonException extends RuntimeException
+    {
+    }
 
 }
 
 
 namespace XoopsModules\Wggithub\Github\Http {
-	use XoopsModules\Wggithub\Github;
+    use XoopsModules\Wggithub\Github;
 
 
-	/**
-	 * HTTP response is somehow wrong and cannot be processed.
-	 */
-	class BadResponseException extends Github\RuntimeException
-	{}
+    /**
+     * HTTP response is somehow wrong and cannot be processed.
+     */
+    class BadResponseException extends Github\RuntimeException
+    {}
 
 }
 
 
 namespace XoopsModules\Wggithub\Github\OAuth {
-	use XoopsModules\Wggithub\Github;
+    use XoopsModules\Wggithub\Github;
 
-	/**
-	 * Something fails during the token obtaining.
-	 */
-	class LoginException extends Github\RuntimeException
-	{}
+    /**
+     * Something fails during the token obtaining.
+     */
+    class LoginException extends Github\RuntimeException
+    {}
 
 }
 
 
 namespace XoopsModules\Wggithub\Github\Storages {
-	use XoopsModules\Wggithub\Github;
+    use XoopsModules\Wggithub\Github;
 
-	/**
-	 * Directory is missing and/or cannot be created.
-	 */
-	class MissingDirectoryException extends Github\RuntimeException
-	{}
+    /**
+     * Directory is missing and/or cannot be created.
+     */
+    class MissingDirectoryException extends Github\RuntimeException
+    {}
 
 }

class/Github/Http/CachedClient.php

Indentation +126 added lines, -126 removed lines

@@ -13,131 +13,131 @@
  */
 class CachedClient extends Github\Sanity implements IClient
 {
-	/** @var Storages\ICache|NULL */
-	private $cache;
-
-	/** @var IClient */
-	private $client;
-
-	/** @var bool */
-	private $forbidRecheck;
-
-	/** @var callable|NULL */
-	private $onResponse;
-
-
-	/**
-	 * @param Storages\ICache
-	 * @param IClient
-	 * @param bool  forbid checking Github for new data; more or less development purpose only
-	 */
-	public function __construct(Storages\ICache $cache, IClient $client = NULL, $forbidRecheck = FALSE)
-	{
-		$this->cache = $cache;
-		$this->client = $client ?: Github\Helpers::createDefaultClient();
-		$this->forbidRecheck = (bool) $forbidRecheck;
-	}
-
-
-	/**
-	 * @return IClient
-	 */
-	public function getInnerClient()
-	{
-		return $this->client;
-	}
-
-
-	/**
-	 * @return Response
-	 *
-	 * @throws BadResponseException
-	 */
-	public function request(Request $request)
-	{
-		$request = clone $request;
-
-		$cacheKey = implode('.', [
-			$request->getMethod(),
-			$request->getUrl(),
-
-			/** @todo This should depend on Vary: header */
-			$request->getHeader('Accept'),
-			$request->getHeader('Accept-Encoding'),
-			$request->getHeader('Authorization')
-		]);
-
-		if ($cached = $this->cache->load($cacheKey)) {
-			if ($this->forbidRecheck) {
-				$cached = clone $cached;
-				$this->onResponse && call_user_func($this->onResponse, $cached);
-				return $cached;
-			}
-
-			/** @var $cached Response */
-			if ($cached->hasHeader('Last-Modified')) {
-				$request->addHeader('If-Modified-Since', $cached->getHeader('Last-Modified'));
-			}
-			if ($cached->hasHeader('ETag')) {
-				$request->addHeader('If-None-Match', $cached->getHeader('ETag'));
-			}
-		}
-
-		$response = $this->client->request($request);
-
-		if ($this->isCacheable($response)) {
-			$this->cache->save($cacheKey, clone $response);
-		}
-
-		if (isset($cached) && $response->getCode() === Response::S304_NOT_MODIFIED) {
-			$cached = clone $cached;
-
-			/** @todo Should be responses somehow combined into one? */
-			$response = $cached->setPrevious($response);
-		}
-
-		$this->onResponse && call_user_func($this->onResponse, $response);
-
-		return $response;
-	}
-
-
-	/**
-	 * @param  callable|NULL function(Request $request)
-	 * @return self
-	 */
-	public function onRequest($callback)
-	{
-		$this->client->onRequest($callback);
-		return $this;
-	}
-
-
-	/**
-	 * @param  callable|NULL function(Response $response)
-	 * @return self
-	 */
-	public function onResponse($callback)
-	{
-		$this->client->onResponse(NULL);
-		$this->onResponse = $callback;
-		return $this;
-	}
-
-
-	/**
-	 * @return bool
-	 */
-	protected function isCacheable(Response $response)
-	{
-		/** @todo Do it properly. Vary:, Pragma:, TTL...  */
-		if (!$response->isCode(200)) {
-			return FALSE;
-		} elseif (preg_match('#max-age=0|must-revalidate#i', $response->getHeader('Cache-Control', ''))) {
-			return FALSE;
-		}
-
-		return $response->hasHeader('ETag') || $response->hasHeader('Last-Modified');
-	}
+    /** @var Storages\ICache|NULL */
+    private $cache;
+
+    /** @var IClient */
+    private $client;
+
+    /** @var bool */
+    private $forbidRecheck;
+
+    /** @var callable|NULL */
+    private $onResponse;
+
+
+    /**
+     * @param Storages\ICache
+     * @param IClient
+     * @param bool  forbid checking Github for new data; more or less development purpose only
+     */
+    public function __construct(Storages\ICache $cache, IClient $client = NULL, $forbidRecheck = FALSE)
+    {
+        $this->cache = $cache;
+        $this->client = $client ?: Github\Helpers::createDefaultClient();
+        $this->forbidRecheck = (bool) $forbidRecheck;
+    }
+
+
+    /**
+     * @return IClient
+     */
+    public function getInnerClient()
+    {
+        return $this->client;
+    }
+
+
+    /**
+     * @return Response
+     *
+     * @throws BadResponseException
+     */
+    public function request(Request $request)
+    {
+        $request = clone $request;
+
+        $cacheKey = implode('.', [
+            $request->getMethod(),
+            $request->getUrl(),
+
+            /** @todo This should depend on Vary: header */
+            $request->getHeader('Accept'),
+            $request->getHeader('Accept-Encoding'),
+            $request->getHeader('Authorization')
+        ]);
+
+        if ($cached = $this->cache->load($cacheKey)) {
+            if ($this->forbidRecheck) {
+                $cached = clone $cached;
+                $this->onResponse && call_user_func($this->onResponse, $cached);
+                return $cached;
+            }
+
+            /** @var $cached Response */
+            if ($cached->hasHeader('Last-Modified')) {
+                $request->addHeader('If-Modified-Since', $cached->getHeader('Last-Modified'));
+            }
+            if ($cached->hasHeader('ETag')) {
+                $request->addHeader('If-None-Match', $cached->getHeader('ETag'));
+            }
+        }
+
+        $response = $this->client->request($request);
+
+        if ($this->isCacheable($response)) {
+            $this->cache->save($cacheKey, clone $response);
+        }
+
+        if (isset($cached) && $response->getCode() === Response::S304_NOT_MODIFIED) {
+            $cached = clone $cached;
+
+            /** @todo Should be responses somehow combined into one? */
+            $response = $cached->setPrevious($response);
+        }
+
+        $this->onResponse && call_user_func($this->onResponse, $response);
+
+        return $response;
+    }
+
+
+    /**
+     * @param  callable|NULL function(Request $request)
+     * @return self
+     */
+    public function onRequest($callback)
+    {
+        $this->client->onRequest($callback);
+        return $this;
+    }
+
+
+    /**
+     * @param  callable|NULL function(Response $response)
+     * @return self
+     */
+    public function onResponse($callback)
+    {
+        $this->client->onResponse(NULL);
+        $this->onResponse = $callback;
+        return $this;
+    }
+
+
+    /**
+     * @return bool
+     */
+    protected function isCacheable(Response $response)
+    {
+        /** @todo Do it properly. Vary:, Pragma:, TTL...  */
+        if (!$response->isCode(200)) {
+            return FALSE;
+        } elseif (preg_match('#max-age=0|must-revalidate#i', $response->getHeader('Cache-Control', ''))) {
+            return FALSE;
+        }
+
+        return $response->hasHeader('ETag') || $response->hasHeader('Last-Modified');
+    }
 
 }

class/Github/Http/StreamClient.php

Indentation +103 added lines, -103 removed lines

@@ -10,108 +10,108 @@
  */
 class StreamClient extends AbstractClient
 {
-	/** @var array|NULL */
-	private $sslOptions;
-
-
-	/**
-	 * @param  array  SSL context options {@link http://php.net/manual/en/context.ssl.php}
-	 */
-	public function __construct(array $sslOptions = NULL)
-	{
-		$this->sslOptions = $sslOptions;
-	}
-
-
-	protected function setupRequest(Request $request)
-	{
-		parent::setupRequest($request);
-		$request->setHeader('Connection', 'close');
-	}
-
-
-	/**
-	 * @return Response
-	 *
-	 * @throws BadResponseException
-	 */
-	protected function process(Request $request)
-	{
-		$headerStr = [];
-		foreach ($request->getHeaders() as $name => $value) {
-			foreach ((array) $value as $v) {
-				$headerStr[] = "$name: $v";
-			}
-		}
-
-		$options = [
-			'http' => [
-				'method' => $request->getMethod(),
-				'header' => implode("\r\n", $headerStr) . "\r\n",
-				'follow_location' => 0,  # Github sets the Location header for 201 code too and redirection is not required for us
-				'protocol_version' => 1.1,
-				'ignore_errors' => TRUE,
-			],
-			'ssl' => [
-				'verify_peer' => TRUE,
-				'cafile' => realpath(__DIR__ . '/../../ca-chain.crt'),
-				'disable_compression' => TRUE,  # Effective since PHP 5.4.13
-			],
-		];
-
-		if (($content = $request->getContent()) !== NULL) {
-			$options['http']['content'] = $content;
-		}
-
-		if ($this->sslOptions) {
-			$options['ssl'] = $this->sslOptions + $options['ssl'];
-		}
-
-		list($code, $headers, $content) = $this->fileGetContents($request->getUrl(), $options);
-		return new Response($code, $headers, $content);
-	}
-
-
-	/**
-	 * @internal
-	 * @param  string
-	 * @param  array
-	 * @return array
-	 *
-	 * @throws BadResponseException
-	 */
-	protected function fileGetContents($url, array $contextOptions)
-	{
-		$context = stream_context_create($contextOptions);
-
-		$e = NULL;
-		set_error_handler(function($severity, $message, $file, $line) use (& $e) {
-			$e = new \ErrorException($message, 0, $severity, $file, $line, $e);
-		}, E_WARNING);
-
-		$content = file_get_contents($url, FALSE, $context);
-		restore_error_handler();
-
-		if (!isset($http_response_header)) {
-			throw new BadResponseException('Missing HTTP headers, request failed.', 0, $e);
-		}
-
-		if (!isset($http_response_header[0]) || !preg_match('~^HTTP/1[.]. (\d{3})~i', $http_response_header[0], $m)) {
-			throw new BadResponseException('HTTP status code is missing.', 0, $e);
-		}
-		unset($http_response_header[0]);
-
-		$headers = [];
-		foreach ($http_response_header as $header) {
-			if (in_array(substr($header, 0, 1), [' ', "\t"], TRUE)) {
-				$headers[$last] .= ' ' . trim($header);  # RFC2616, 2.2
-			} else {
-				list($name, $value) = explode(':', $header, 2) + [NULL, NULL];
-				$headers[$last = trim($name)] = trim($value);
-			}
-		}
-
-		return [$m[1], $headers, $content];
-	}
+    /** @var array|NULL */
+    private $sslOptions;
+
+
+    /**
+     * @param  array  SSL context options {@link http://php.net/manual/en/context.ssl.php}
+     */
+    public function __construct(array $sslOptions = NULL)
+    {
+        $this->sslOptions = $sslOptions;
+    }
+
+
+    protected function setupRequest(Request $request)
+    {
+        parent::setupRequest($request);
+        $request->setHeader('Connection', 'close');
+    }
+
+
+    /**
+     * @return Response
+     *
+     * @throws BadResponseException
+     */
+    protected function process(Request $request)
+    {
+        $headerStr = [];
+        foreach ($request->getHeaders() as $name => $value) {
+            foreach ((array) $value as $v) {
+                $headerStr[] = "$name: $v";
+            }
+        }
+
+        $options = [
+            'http' => [
+                'method' => $request->getMethod(),
+                'header' => implode("\r\n", $headerStr) . "\r\n",
+                'follow_location' => 0,  # Github sets the Location header for 201 code too and redirection is not required for us
+                'protocol_version' => 1.1,
+                'ignore_errors' => TRUE,
+            ],
+            'ssl' => [
+                'verify_peer' => TRUE,
+                'cafile' => realpath(__DIR__ . '/../../ca-chain.crt'),
+                'disable_compression' => TRUE,  # Effective since PHP 5.4.13
+            ],
+        ];
+
+        if (($content = $request->getContent()) !== NULL) {
+            $options['http']['content'] = $content;
+        }
+
+        if ($this->sslOptions) {
+            $options['ssl'] = $this->sslOptions + $options['ssl'];
+        }
+
+        list($code, $headers, $content) = $this->fileGetContents($request->getUrl(), $options);
+        return new Response($code, $headers, $content);
+    }
+
+
+    /**
+     * @internal
+     * @param  string
+     * @param  array
+     * @return array
+     *
+     * @throws BadResponseException
+     */
+    protected function fileGetContents($url, array $contextOptions)
+    {
+        $context = stream_context_create($contextOptions);
+
+        $e = NULL;
+        set_error_handler(function($severity, $message, $file, $line) use (& $e) {
+            $e = new \ErrorException($message, 0, $severity, $file, $line, $e);
+        }, E_WARNING);
+
+        $content = file_get_contents($url, FALSE, $context);
+        restore_error_handler();
+
+        if (!isset($http_response_header)) {
+            throw new BadResponseException('Missing HTTP headers, request failed.', 0, $e);
+        }
+
+        if (!isset($http_response_header[0]) || !preg_match('~^HTTP/1[.]. (\d{3})~i', $http_response_header[0], $m)) {
+            throw new BadResponseException('HTTP status code is missing.', 0, $e);
+        }
+        unset($http_response_header[0]);
+
+        $headers = [];
+        foreach ($http_response_header as $header) {
+            if (in_array(substr($header, 0, 1), [' ', "\t"], TRUE)) {
+                $headers[$last] .= ' ' . trim($header);  # RFC2616, 2.2
+            } else {
+                list($name, $value) = explode(':', $header, 2) + [NULL, NULL];
+                $headers[$last = trim($name)] = trim($value);
+            }
+        }
+
+        return [$m[1], $headers, $content];
+    }
 
 }

Spacing +5 added lines, -5 removed lines

@@ -47,15 +47,15 @@ 
 		$options = [
 			'http' => [
 				'method' => $request->getMethod(),
-				'header' => implode("\r\n", $headerStr) . "\r\n",
-				'follow_location' => 0,  # Github sets the Location header for 201 code too and redirection is not required for us
+				'header' => implode("\r\n", $headerStr)."\r\n",
+				'follow_location' => 0, # Github sets the Location header for 201 code too and redirection is not required for us
 				'protocol_version' => 1.1,
 				'ignore_errors' => TRUE,
 			],
 			'ssl' => [
 				'verify_peer' => TRUE,
-				'cafile' => realpath(__DIR__ . '/../../ca-chain.crt'),
-				'disable_compression' => TRUE,  # Effective since PHP 5.4.13
+				'cafile' => realpath(__DIR__.'/../../ca-chain.crt'),
+				'disable_compression' => TRUE, # Effective since PHP 5.4.13
 			],
 		];
 
@@ -104,7 +104,7 @@ 
 		$headers = [];
 		foreach ($http_response_header as $header) {
 			if (in_array(substr($header, 0, 1), [' ', "\t"], TRUE)) {
-				$headers[$last] .= ' ' . trim($header);  # RFC2616, 2.2
+				$headers[$last] .= ' '.trim($header); # RFC2616, 2.2
 			} else {
 				list($name, $value) = explode(':', $header, 2) + [NULL, NULL];
 				$headers[$last = trim($name)] = trim($value);

class/Github/Http/Request.php

Indentation +79 added lines, -79 removed lines

@@ -12,84 +12,84 @@
  */
 class Request extends Message
 {
-	/** HTTP request method */
-	const
-		DELETE = 'DELETE',
-		GET = 'GET',
-		HEAD = 'HEAD',
-		PATCH = 'PATCH',
-		POST = 'POST',
-		PUT = 'PUT';
-
-
-	/** @var string */
-	private $method;
-
-	/** @var string */
-	private $url;
-
-
-	/**
-	 * @param  string
-	 * @param  string
-	 * @param  array
-	 * @param  string|NULL
-	 */
-	public function __construct($method, $url, array $headers = [], $content = NULL)
-	{
-		$this->method = $method;
-		$this->url = $url;
-		parent::__construct($headers, $content);
-	}
-
-
-	/**
-	 * @param  string
-	 * @return bool
-	 */
-	public function isMethod($method)
-	{
-		return strcasecmp($this->method, $method) === 0;
-	}
-
-
-	/**
-	 * @return string
-	 */
-	public function getMethod()
-	{
-		return $this->method;
-	}
-
-
-	/**
-	 * @return string
-	 */
-	public function getUrl()
-	{
-		return $this->url;
-	}
-
-
-	/**
-	 * @param  string
-	 * @param  string
-	 * @return self
-	 */
-	public function addHeader($name, $value)
-	{
-		return parent::addHeader($name, $value);
-	}
-
-
-	/**
-	 * @param  string
-	 * @param  string|NULL
-	 * @return self
-	 */
-	public function setHeader($name, $value)
-	{
-		return parent::setHeader($name, $value);
-	}
+    /** HTTP request method */
+    const
+        DELETE = 'DELETE',
+        GET = 'GET',
+        HEAD = 'HEAD',
+        PATCH = 'PATCH',
+        POST = 'POST',
+        PUT = 'PUT';
+
+
+    /** @var string */
+    private $method;
+
+    /** @var string */
+    private $url;
+
+
+    /**
+     * @param  string
+     * @param  string
+     * @param  array
+     * @param  string|NULL
+     */
+    public function __construct($method, $url, array $headers = [], $content = NULL)
+    {
+        $this->method = $method;
+        $this->url = $url;
+        parent::__construct($headers, $content);
+    }
+
+
+    /**
+     * @param  string
+     * @return bool
+     */
+    public function isMethod($method)
+    {
+        return strcasecmp($this->method, $method) === 0;
+    }
+
+
+    /**
+     * @return string
+     */
+    public function getMethod()
+    {
+        return $this->method;
+    }
+
+
+    /**
+     * @return string
+     */
+    public function getUrl()
+    {
+        return $this->url;
+    }
+
+
+    /**
+     * @param  string
+     * @param  string
+     * @return self
+     */
+    public function addHeader($name, $value)
+    {
+        return parent::addHeader($name, $value);
+    }
+
+
+    /**
+     * @param  string
+     * @param  string|NULL
+     * @return self
+     */
+    public function setHeader($name, $value)
+    {
+        return parent::setHeader($name, $value);
+    }
 
 }

class/Github/Http/Message.php

Indentation +92 added lines, -92 removed lines

@@ -12,97 +12,97 @@
  */
 abstract class Message extends Github\Sanity
 {
-	/** @var array[name => value] */
-	private $headers = [];
-
-	/** @var string|NULL */
-	private $content;
-
-
-	/**
-	 * @param  array
-	 * @param  string|NULL
-	 */
-	public function __construct(array $headers = [], $content = NULL)
-	{
-		$this->headers = array_change_key_case($headers, CASE_LOWER);
-		$this->content = $content;
-	}
-
-
-	/**
-	 * @param  string
-	 * @return bool
-	 */
-	public function hasHeader($name)
-	{
-		return array_key_exists(strtolower($name), $this->headers);
-	}
-
-
-	/**
-	 * @param  string
-	 * @param  mixed
-	 * @return mixed
-	 */
-	public function getHeader($name, $default = NULL)
-	{
-		$name = strtolower($name);
-		return array_key_exists($name, $this->headers)
-			? $this->headers[$name]
-			: $default;
-	}
-
-
-	/**
-	 * @param  string
-	 * @param  string
-	 * @return self
-	 */
-	protected function addHeader($name, $value)
-	{
-		$name = strtolower($name);
-		if (!array_key_exists($name, $this->headers) && $value !== NULL) {
-			$this->headers[$name] = $value;
-		}
-
-		return $this;
-	}
-
-
-	/**
-	 * @param  string
-	 * @param  string|NULL
-	 * @return self
-	 */
-	protected function setHeader($name, $value)
-	{
-		$name = strtolower($name);
-		if ($value === NULL) {
-			unset($this->headers[$name]);
-		} else {
-			$this->headers[$name] = $value;
-		}
-
-		return $this;
-	}
-
-
-	/**
-	 * @return array
-	 */
-	public function getHeaders()
-	{
-		return $this->headers;
-	}
-
-
-	/**
-	 * @return string|NULL
-	 */
-	public function getContent()
-	{
-		return $this->content;
-	}
+    /** @var array[name => value] */
+    private $headers = [];
+
+    /** @var string|NULL */
+    private $content;
+
+
+    /**
+     * @param  array
+     * @param  string|NULL
+     */
+    public function __construct(array $headers = [], $content = NULL)
+    {
+        $this->headers = array_change_key_case($headers, CASE_LOWER);
+        $this->content = $content;
+    }
+
+
+    /**
+     * @param  string
+     * @return bool
+     */
+    public function hasHeader($name)
+    {
+        return array_key_exists(strtolower($name), $this->headers);
+    }
+
+
+    /**
+     * @param  string
+     * @param  mixed
+     * @return mixed
+     */
+    public function getHeader($name, $default = NULL)
+    {
+        $name = strtolower($name);
+        return array_key_exists($name, $this->headers)
+            ? $this->headers[$name]
+            : $default;
+    }
+
+
+    /**
+     * @param  string
+     * @param  string
+     * @return self
+     */
+    protected function addHeader($name, $value)
+    {
+        $name = strtolower($name);
+        if (!array_key_exists($name, $this->headers) && $value !== NULL) {
+            $this->headers[$name] = $value;
+        }
+
+        return $this;
+    }
+
+
+    /**
+     * @param  string
+     * @param  string|NULL
+     * @return self
+     */
+    protected function setHeader($name, $value)
+    {
+        $name = strtolower($name);
+        if ($value === NULL) {
+            unset($this->headers[$name]);
+        } else {
+            $this->headers[$name] = $value;
+        }
+
+        return $this;
+    }
+
+
+    /**
+     * @return array
+     */
+    public function getHeaders()
+    {
+        return $this->headers;
+    }
+
+
+    /**
+     * @return string|NULL
+     */
+    public function getContent()
+    {
+        return $this->content;
+    }
 
 }

class/Github/Http/CurlClient.php

Indentation +105 added lines, -105 removed lines

@@ -12,110 +12,110 @@
  */
 class CurlClient extends AbstractClient
 {
-	/** @var array|NULL */
-	private $options;
-
-	/** @var resource */
-	private $curl;
-
-
-	/**
-	 * @param  array  cURL options {@link http://php.net/manual/en/function.curl-setopt.php}
-	 *
-	 * @throws Github\LogicException
-	 */
-	public function __construct(array $options = NULL)
-	{
-		if (!extension_loaded('curl')) {
-			throw new Github\LogicException('cURL extension is not loaded.');
-		}
-
-		$this->options = $options;
-	}
-
-
-	protected function setupRequest(Request $request)
-	{
-		parent::setupRequest($request);
-		$request->addHeader('Connection', 'keep-alive');
-	}
-
-
-	/**
-	 * @return Response
-	 *
-	 * @throws BadResponseException
-	 */
-	protected function process(Request $request)
-	{
-		$headers = [];
-		foreach ($request->getHeaders() as $name => $value) {
-			$headers[] = "$name: $value";
-		}
-
-		$responseHeaders = [];
-		$softOptions = [
-			CURLOPT_CONNECTTIMEOUT => 10,
-			CURLOPT_SSL_VERIFYHOST => 2,
-			CURLOPT_SSL_VERIFYPEER => 1,
-			CURLOPT_CAINFO => realpath(__DIR__ . '/../ca-chain.crt'),
-		];
-
-		$hardOptions = [
-			CURLOPT_FOLLOWLOCATION => FALSE, # Github sets the Location header for 201 code too and redirection is not required for us
-			CURLOPT_HTTP_VERSION => CURL_HTTP_VERSION_1_1,
-			CURLOPT_CUSTOMREQUEST => $request->getMethod(),
-			CURLOPT_NOBODY => $request->isMethod(Request::HEAD),
-			CURLOPT_URL => $request->getUrl(),
-			CURLOPT_HTTPHEADER => $headers,
-			CURLOPT_RETURNTRANSFER => TRUE,
-			CURLOPT_POSTFIELDS => $request->getContent(),
-			CURLOPT_HEADER => FALSE,
-			CURLOPT_HEADERFUNCTION => function($curl, $line) use (& $responseHeaders, & $last) {
-				if (strncasecmp($line, 'HTTP/', 5) === 0) {
-					/** @todo Set proxy response as Response::setPrevious($proxyResponse)? */
-					# The HTTP/x.y may occur multiple times with proxy (HTTP/1.1 200 Connection Established)
-					$responseHeaders = [];
-
-				} elseif (in_array(substr($line, 0, 1), [' ', "\t"], TRUE)) {
-					$responseHeaders[$last] .= ' ' . trim($line);  # RFC2616, 2.2
-
-				} elseif ($line !== "\r\n") {
-					list($name, $value) = explode(':', $line, 2);
-					$responseHeaders[$last = trim($name)] = trim($value);
-				}
-
-				return strlen($line);
-			},
-		];
-
-		if (defined('CURLOPT_PROTOCOLS')) {  # HHVM issue. Even cURL v7.26.0, constants are missing.
-			$hardOptions[CURLOPT_PROTOCOLS] = CURLPROTO_HTTP | CURLPROTO_HTTPS;
-		}
-
-		if (!$this->curl) {
-			$this->curl = curl_init();
-			if ($this->curl === FALSE) {
-				throw new BadResponseException('Cannot init cURL handler.');
-			}
-		}
-
-		$result = curl_setopt_array($this->curl, $hardOptions + ($this->options ?: []) + $softOptions);
-		if ($result === FALSE) {
-			throw new BadResponseException('Setting cURL options failed: ' . curl_error($this->curl), curl_errno($this->curl));
-		}
-
-		$content = curl_exec($this->curl);
-		if ($content === FALSE) {
-			throw new BadResponseException(curl_error($this->curl), curl_errno($this->curl));
-		}
-
-		$code = curl_getinfo($this->curl, CURLINFO_HTTP_CODE);
-		if ($code === FALSE) {
-			throw new BadResponseException('HTTP status code is missing:' . curl_error($this->curl), curl_errno($this->curl));
-		}
-
-		return new Response($code, $responseHeaders, $content);
-	}
+    /** @var array|NULL */
+    private $options;
+
+    /** @var resource */
+    private $curl;
+
+
+    /**
+     * @param  array  cURL options {@link http://php.net/manual/en/function.curl-setopt.php}
+     *
+     * @throws Github\LogicException
+     */
+    public function __construct(array $options = NULL)
+    {
+        if (!extension_loaded('curl')) {
+            throw new Github\LogicException('cURL extension is not loaded.');
+        }
+
+        $this->options = $options;
+    }
+
+
+    protected function setupRequest(Request $request)
+    {
+        parent::setupRequest($request);
+        $request->addHeader('Connection', 'keep-alive');
+    }
+
+
+    /**
+     * @return Response
+     *
+     * @throws BadResponseException
+     */
+    protected function process(Request $request)
+    {
+        $headers = [];
+        foreach ($request->getHeaders() as $name => $value) {
+            $headers[] = "$name: $value";
+        }
+
+        $responseHeaders = [];
+        $softOptions = [
+            CURLOPT_CONNECTTIMEOUT => 10,
+            CURLOPT_SSL_VERIFYHOST => 2,
+            CURLOPT_SSL_VERIFYPEER => 1,
+            CURLOPT_CAINFO => realpath(__DIR__ . '/../ca-chain.crt'),
+        ];
+
+        $hardOptions = [
+            CURLOPT_FOLLOWLOCATION => FALSE, # Github sets the Location header for 201 code too and redirection is not required for us
+            CURLOPT_HTTP_VERSION => CURL_HTTP_VERSION_1_1,
+            CURLOPT_CUSTOMREQUEST => $request->getMethod(),
+            CURLOPT_NOBODY => $request->isMethod(Request::HEAD),
+            CURLOPT_URL => $request->getUrl(),
+            CURLOPT_HTTPHEADER => $headers,
+            CURLOPT_RETURNTRANSFER => TRUE,
+            CURLOPT_POSTFIELDS => $request->getContent(),
+            CURLOPT_HEADER => FALSE,
+            CURLOPT_HEADERFUNCTION => function($curl, $line) use (& $responseHeaders, & $last) {
+                if (strncasecmp($line, 'HTTP/', 5) === 0) {
+                    /** @todo Set proxy response as Response::setPrevious($proxyResponse)? */
+                    # The HTTP/x.y may occur multiple times with proxy (HTTP/1.1 200 Connection Established)
+                    $responseHeaders = [];
+
+                } elseif (in_array(substr($line, 0, 1), [' ', "\t"], TRUE)) {
+                    $responseHeaders[$last] .= ' ' . trim($line);  # RFC2616, 2.2
+
+                } elseif ($line !== "\r\n") {
+                    list($name, $value) = explode(':', $line, 2);
+                    $responseHeaders[$last = trim($name)] = trim($value);
+                }
+
+                return strlen($line);
+            },
+        ];
+
+        if (defined('CURLOPT_PROTOCOLS')) {  # HHVM issue. Even cURL v7.26.0, constants are missing.
+            $hardOptions[CURLOPT_PROTOCOLS] = CURLPROTO_HTTP | CURLPROTO_HTTPS;
+        }
+
+        if (!$this->curl) {
+            $this->curl = curl_init();
+            if ($this->curl === FALSE) {
+                throw new BadResponseException('Cannot init cURL handler.');
+            }
+        }
+
+        $result = curl_setopt_array($this->curl, $hardOptions + ($this->options ?: []) + $softOptions);
+        if ($result === FALSE) {
+            throw new BadResponseException('Setting cURL options failed: ' . curl_error($this->curl), curl_errno($this->curl));
+        }
+
+        $content = curl_exec($this->curl);
+        if ($content === FALSE) {
+            throw new BadResponseException(curl_error($this->curl), curl_errno($this->curl));
+        }
+
+        $code = curl_getinfo($this->curl, CURLINFO_HTTP_CODE);
+        if ($code === FALSE) {
+            throw new BadResponseException('HTTP status code is missing:' . curl_error($this->curl), curl_errno($this->curl));
+        }
+
+        return new Response($code, $responseHeaders, $content);
+    }
 
 }

Spacing +4 added lines, -4 removed lines

@@ -58,7 +58,7 @@ 
 			CURLOPT_CONNECTTIMEOUT => 10,
 			CURLOPT_SSL_VERIFYHOST => 2,
 			CURLOPT_SSL_VERIFYPEER => 1,
-			CURLOPT_CAINFO => realpath(__DIR__ . '/../ca-chain.crt'),
+			CURLOPT_CAINFO => realpath(__DIR__.'/../ca-chain.crt'),
 		];
 
 		$hardOptions = [
@@ -78,7 +78,7 @@ 
 					$responseHeaders = [];
 
 				} elseif (in_array(substr($line, 0, 1), [' ', "\t"], TRUE)) {
-					$responseHeaders[$last] .= ' ' . trim($line);  # RFC2616, 2.2
+					$responseHeaders[$last] .= ' '.trim($line); # RFC2616, 2.2
 
 				} elseif ($line !== "\r\n") {
 					list($name, $value) = explode(':', $line, 2);
@@ -102,7 +102,7 @@ 
 
 		$result = curl_setopt_array($this->curl, $hardOptions + ($this->options ?: []) + $softOptions);
 		if ($result === FALSE) {
-			throw new BadResponseException('Setting cURL options failed: ' . curl_error($this->curl), curl_errno($this->curl));
+			throw new BadResponseException('Setting cURL options failed: '.curl_error($this->curl), curl_errno($this->curl));
 		}
 
 		$content = curl_exec($this->curl);
@@ -112,7 +112,7 @@ 
 
 		$code = curl_getinfo($this->curl, CURLINFO_HTTP_CODE);
 		if ($code === FALSE) {
-			throw new BadResponseException('HTTP status code is missing:' . curl_error($this->curl), curl_errno($this->curl));
+			throw new BadResponseException('HTTP status code is missing:'.curl_error($this->curl), curl_errno($this->curl));
 		}
 
 		return new Response($code, $responseHeaders, $content);

class/Github/Http/Response.php

Indentation +75 added lines, -75 removed lines

@@ -12,80 +12,80 @@
  */
 class Response extends Message
 {
-	/** HTTP 1.1 code */
-	const
-		S200_OK = 200,
-		S301_MOVED_PERMANENTLY = 301,
-		S302_FOUND = 302,
-		S304_NOT_MODIFIED = 304,
-		S307_TEMPORARY_REDIRECT = 307,
-		S400_BAD_REQUEST = 400,
-		S401_UNAUTHORIZED = 401,
-		S403_FORBIDDEN = 403,
-		S404_NOT_FOUND = 404,
-		S422_UNPROCESSABLE_ENTITY = 422;
-
-	/** @var int */
-	private $code;
-
-	/** @var Response */
-	private $previous;
-
-
-	/**
-	 * @param  int
-	 * @param  array
-	 * @param  string
-	 */
-	public function __construct($code, array $headers, $content)
-	{
-		$this->code = (int) $code;
-		parent::__construct($headers, $content);
-	}
-
-
-	/**
-	 * HTTP code.
-	 * @return int
-	 */
-	public function getCode()
-	{
-		return $this->code;
-	}
-
-
-	/**
-	 * @param  int
-	 * @return bool
-	 */
-	public function isCode($code)
-	{
-		return $this->code === (int) $code;
-	}
-
-
-	/**
-	 * @return Response|NULL
-	 */
-	public function getPrevious()
-	{
-		return $this->previous;
-	}
-
-
-	/**
-	 * @return self
-	 *
-	 * @throws Github\LogicException
-	 */
-	public function setPrevious(Response $previous = NULL)
-	{
-		if ($this->previous) {
-			throw new Github\LogicException('Previous response is already set.');
-		}
-		$this->previous = $previous;
-
-		return $this;
-	}
+    /** HTTP 1.1 code */
+    const
+        S200_OK = 200,
+        S301_MOVED_PERMANENTLY = 301,
+        S302_FOUND = 302,
+        S304_NOT_MODIFIED = 304,
+        S307_TEMPORARY_REDIRECT = 307,
+        S400_BAD_REQUEST = 400,
+        S401_UNAUTHORIZED = 401,
+        S403_FORBIDDEN = 403,
+        S404_NOT_FOUND = 404,
+        S422_UNPROCESSABLE_ENTITY = 422;
+
+    /** @var int */
+    private $code;
+
+    /** @var Response */
+    private $previous;
+
+
+    /**
+     * @param  int
+     * @param  array
+     * @param  string
+     */
+    public function __construct($code, array $headers, $content)
+    {
+        $this->code = (int) $code;
+        parent::__construct($headers, $content);
+    }
+
+
+    /**
+     * HTTP code.
+     * @return int
+     */
+    public function getCode()
+    {
+        return $this->code;
+    }
+
+
+    /**
+     * @param  int
+     * @return bool
+     */
+    public function isCode($code)
+    {
+        return $this->code === (int) $code;
+    }
+
+
+    /**
+     * @return Response|NULL
+     */
+    public function getPrevious()
+    {
+        return $this->previous;
+    }
+
+
+    /**
+     * @return self
+     *
+     * @throws Github\LogicException
+     */
+    public function setPrevious(Response $previous = NULL)
+    {
+        if ($this->previous) {
+            throw new Github\LogicException('Previous response is already set.');
+        }
+        $this->previous = $previous;
+
+        return $this;
+    }
 
 }

class/Github/Http/AbstractClient.php

Indentation +93 added lines, -93 removed lines

@@ -12,98 +12,98 @@
  */
 abstract class AbstractClient extends Github\Sanity implements IClient
 {
-	/** @var int[]  will follow Location header on these response codes */
-	public $redirectCodes = [
-		Response::S301_MOVED_PERMANENTLY,
-		Response::S302_FOUND,
-		Response::S307_TEMPORARY_REDIRECT,
-	];
-
-	/** @var int  maximum redirects per request*/
-	public $maxRedirects = 5;
-
-	/** @var callable|NULL */
-	private $onRequest;
-
-	/** @var callable|NULL */
-	private $onResponse;
-
-
-	/**
-	 * @see https://developer.github.com/v3/#http-redirects
-	 *
-	 * @return Response
-	 *
-	 * @throws BadResponseException
-	 */
-	public function request(Request $request)
-	{
-		$request = clone $request;
-
-		$counter = $this->maxRedirects;
-		$previous = NULL;
-		do {
-			$this->setupRequest($request);
-
-			$this->onRequest && call_user_func($this->onRequest, $request);
-			$response = $this->process($request);
-			$this->onResponse && call_user_func($this->onResponse, $response);
-
-			$previous = $response->setPrevious($previous);
-
-			if ($counter > 0 && in_array($response->getCode(), $this->redirectCodes) && $response->hasHeader('Location')) {
-				/** @todo Use the same HTTP $method for redirection? Set $content to NULL? */
-				$request = new Request(
-					$request->getMethod(),
-					$response->getHeader('Location'),
-					$request->getHeaders(),
-					$request->getContent()
-				);
-
-				$counter--;
-				continue;
-			}
-			break;
-
-		} while (TRUE);
-
-		return $response;
-	}
-
-
-	/**
-	 * @param  callable|NULL function(Request $request)
-	 * @return self
-	 */
-	public function onRequest($callback)
-	{
-		$this->onRequest = $callback;
-		return $this;
-	}
-
-
-	/**
-	 * @param  callable|NULL function(Response $response)
-	 * @return self
-	 */
-	public function onResponse($callback)
-	{
-		$this->onResponse = $callback;
-		return $this;
-	}
-
-
-	protected function setupRequest(Request $request)
-	{
-		$request->addHeader('Expect', '');
-	}
-
-
-	/**
-	 * @return Response
-	 *
-	 * @throws BadResponseException
-	 */
-	abstract protected function process(Request $request);
+    /** @var int[]  will follow Location header on these response codes */
+    public $redirectCodes = [
+        Response::S301_MOVED_PERMANENTLY,
+        Response::S302_FOUND,
+        Response::S307_TEMPORARY_REDIRECT,
+    ];
+
+    /** @var int  maximum redirects per request*/
+    public $maxRedirects = 5;
+
+    /** @var callable|NULL */
+    private $onRequest;
+
+    /** @var callable|NULL */
+    private $onResponse;
+
+
+    /**
+     * @see https://developer.github.com/v3/#http-redirects
+     *
+     * @return Response
+     *
+     * @throws BadResponseException
+     */
+    public function request(Request $request)
+    {
+        $request = clone $request;
+
+        $counter = $this->maxRedirects;
+        $previous = NULL;
+        do {
+            $this->setupRequest($request);
+
+            $this->onRequest && call_user_func($this->onRequest, $request);
+            $response = $this->process($request);
+            $this->onResponse && call_user_func($this->onResponse, $response);
+
+            $previous = $response->setPrevious($previous);
+
+            if ($counter > 0 && in_array($response->getCode(), $this->redirectCodes) && $response->hasHeader('Location')) {
+                /** @todo Use the same HTTP $method for redirection? Set $content to NULL? */
+                $request = new Request(
+                    $request->getMethod(),
+                    $response->getHeader('Location'),
+                    $request->getHeaders(),
+                    $request->getContent()
+                );
+
+                $counter--;
+                continue;
+            }
+            break;
+
+        } while (TRUE);
+
+        return $response;
+    }
+
+
+    /**
+     * @param  callable|NULL function(Request $request)
+     * @return self
+     */
+    public function onRequest($callback)
+    {
+        $this->onRequest = $callback;
+        return $this;
+    }
+
+
+    /**
+     * @param  callable|NULL function(Response $response)
+     * @return self
+     */
+    public function onResponse($callback)
+    {
+        $this->onResponse = $callback;
+        return $this;
+    }
+
+
+    protected function setupRequest(Request $request)
+    {
+        $request->addHeader('Expect', '');
+    }
+
+
+    /**
+     * @return Response
+     *
+     * @throws BadResponseException
+     */
+    abstract protected function process(Request $request);
 
 }

class/Github/Http/IClient.php

Indentation +14 added lines, -14 removed lines

@@ -10,21 +10,21 @@
  */
 interface IClient
 {
-	/**
-	 * @return Response
-	 */
-	function request(Request $request);
+    /**
+     * @return Response
+     */
+    function request(Request $request);
 
-	/**
-	 * @param  callable|NULL
-	 * @return self
-	 */
-	function onRequest($callback);
+    /**
+     * @param  callable|NULL
+     * @return self
+     */
+    function onRequest($callback);
 
-	/**
-	 * @param  callable|NULL
-	 * @return self
-	 */
-	function onResponse($callback);
+    /**
+     * @param  callable|NULL
+     * @return self
+     */
+    function onResponse($callback);
 
 }