Passed
Push — master ( 55161e...62ffb0 )
by Goffy
03:30
created
include/update.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
     $ret = wggithub_check_db($module);
40 40
 
41 41
     //check upload directory
42
-	include_once __DIR__ . '/install.php';
42
+	include_once __DIR__.'/install.php';
43 43
     $ret = xoops_module_install_wggithub($module);
44 44
 
45 45
     $errors = $module->getErrors();
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 {
62 62
     global $xoopsDB;
63 63
     $result = $xoopsDB->query(
64
-        'SELECT t1.tpl_id FROM ' . $xoopsDB->prefix('tplfile') . ' t1, ' . $xoopsDB->prefix('tplfile') . ' t2 WHERE t1.tpl_refid = t2.tpl_refid AND t1.tpl_module = t2.tpl_module AND t1.tpl_tplset=t2.tpl_tplset AND t1.tpl_file = t2.tpl_file AND t1.tpl_type = t2.tpl_type AND t1.tpl_id > t2.tpl_id'
64
+        'SELECT t1.tpl_id FROM '.$xoopsDB->prefix('tplfile').' t1, '.$xoopsDB->prefix('tplfile').' t2 WHERE t1.tpl_refid = t2.tpl_refid AND t1.tpl_module = t2.tpl_module AND t1.tpl_tplset=t2.tpl_tplset AND t1.tpl_file = t2.tpl_file AND t1.tpl_type = t2.tpl_type AND t1.tpl_id > t2.tpl_id'
65 65
     );
66 66
     $tplids = [];
67 67
     while (false !== (list($tplid) = $xoopsDB->fetchRow($result))) {
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
     }
70 70
     if (\count($tplids) > 0) {
71 71
         $tplfileHandler  = \xoops_getHandler('tplfile');
72
-        $duplicate_files = $tplfileHandler->getObjects(new \Criteria('tpl_id', '(' . \implode(',', $tplids) . ')', 'IN'));
72
+        $duplicate_files = $tplfileHandler->getObjects(new \Criteria('tpl_id', '('.\implode(',', $tplids).')', 'IN'));
73 73
 
74 74
         if (\count($duplicate_files) > 0) {
75 75
             foreach (\array_keys($duplicate_files) as $i) {
@@ -77,9 +77,9 @@  discard block
 block discarded – undo
77 77
             }
78 78
         }
79 79
     }
80
-    $sql = 'SHOW INDEX FROM ' . $xoopsDB->prefix('tplfile') . " WHERE KEY_NAME = 'tpl_refid_module_set_file_type'";
80
+    $sql = 'SHOW INDEX FROM '.$xoopsDB->prefix('tplfile')." WHERE KEY_NAME = 'tpl_refid_module_set_file_type'";
81 81
     if (!$result = $xoopsDB->queryF($sql)) {
82
-        xoops_error($xoopsDB->error() . '<br>' . $sql);
82
+        xoops_error($xoopsDB->error().'<br>'.$sql);
83 83
 
84 84
         return false;
85 85
     }
@@ -92,9 +92,9 @@  discard block
 block discarded – undo
92 92
 
93 93
         return true;
94 94
     }
95
-    $sql = 'ALTER TABLE ' . $xoopsDB->prefix('tplfile') . ' ADD UNIQUE tpl_refid_module_set_file_type ( tpl_refid, tpl_module, tpl_tplset, tpl_file, tpl_type )';
95
+    $sql = 'ALTER TABLE '.$xoopsDB->prefix('tplfile').' ADD UNIQUE tpl_refid_module_set_file_type ( tpl_refid, tpl_module, tpl_tplset, tpl_file, tpl_type )';
96 96
     if (!$result = $xoopsDB->queryF($sql)) {
97
-        xoops_error($xoopsDB->error() . '<br>' . $sql);
97
+        xoops_error($xoopsDB->error().'<br>'.$sql);
98 98
         $module->setErrors("'tpl_refid_module_set_file_type' unique index is not added to 'tplfile' table. Warning: do not use XOOPS until you add this unique index.");
99 99
 
100 100
         return false;
@@ -118,12 +118,12 @@  discard block
 block discarded – undo
118 118
     // Example: update table (add new field)
119 119
     $table   = $GLOBALS['xoopsDB']->prefix('wggithub_repositories');
120 120
     $field   = 'repo_release';
121
-    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `' . $table . "` LIKE '" . $field . "'");
121
+    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `'.$table."` LIKE '".$field."'");
122 122
     $numRows = $GLOBALS['xoopsDB']->getRowsNum($check);
123 123
     if (!$numRows) {
124 124
         $sql = "ALTER TABLE `$table` ADD `$field` INT(1) NOT NULL DEFAULT '0' AFTER `repo_htmlurl`;";
125 125
         if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
126
-            xoops_error($GLOBALS['xoopsDB']->error() . '<br>' . $sql);
126
+            xoops_error($GLOBALS['xoopsDB']->error().'<br>'.$sql);
127 127
             $module->setErrors("Error when adding '$field' to table '$table'.");
128 128
             $ret = false;
129 129
         }
@@ -132,12 +132,12 @@  discard block
 block discarded – undo
132 132
     // Example: update table (add new field)
133 133
     $table   = $GLOBALS['xoopsDB']->prefix('wggithub_repositories');
134 134
     $field   = 'repo_prerelease';
135
-    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `' . $table . "` LIKE '" . $field . "'");
135
+    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `'.$table."` LIKE '".$field."'");
136 136
     $numRows = $GLOBALS['xoopsDB']->getRowsNum($check);
137 137
     if (!$numRows) {
138 138
         $sql = "ALTER TABLE `$table` ADD `$field` INT(1) NOT NULL DEFAULT '0' AFTER `repo_htmlurl`;";
139 139
         if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
140
-            xoops_error($GLOBALS['xoopsDB']->error() . '<br>' . $sql);
140
+            xoops_error($GLOBALS['xoopsDB']->error().'<br>'.$sql);
141 141
             $module->setErrors("Error when adding '$field' to table '$table'.");
142 142
             $ret = false;
143 143
         }
@@ -145,12 +145,12 @@  discard block
 block discarded – undo
145 145
     // Example: update table (add new field)
146 146
     $table   = $GLOBALS['xoopsDB']->prefix('wggithub_repositories');
147 147
     $field   = 'repo_readme';
148
-    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `' . $table . "` LIKE '" . $field . "'");
148
+    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `'.$table."` LIKE '".$field."'");
149 149
     $numRows = $GLOBALS['xoopsDB']->getRowsNum($check);
150 150
     if (!$numRows) {
151 151
         $sql = "ALTER TABLE `$table` ADD `$field` INT(1) NOT NULL DEFAULT '0' AFTER `repo_htmlurl`;";
152 152
         if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
153
-            xoops_error($GLOBALS['xoopsDB']->error() . '<br>' . $sql);
153
+            xoops_error($GLOBALS['xoopsDB']->error().'<br>'.$sql);
154 154
             $module->setErrors("Error when adding '$field' to table '$table'.");
155 155
             $ret = false;
156 156
         }
@@ -159,12 +159,12 @@  discard block
 block discarded – undo
159 159
 // Example: update table (add new field)
160 160
     $table   = $GLOBALS['xoopsDB']->prefix('wggithub_directories');
161 161
     $field   = 'dir_filterrelease';
162
-    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `' . $table . "` LIKE '" . $field . "'");
162
+    $check   = $GLOBALS['xoopsDB']->queryF('SHOW COLUMNS FROM `'.$table."` LIKE '".$field."'");
163 163
     $numRows = $GLOBALS['xoopsDB']->getRowsNum($check);
164 164
     if (!$numRows) {
165 165
         $sql = "ALTER TABLE `$table` ADD `$field` INT(1) NOT NULL DEFAULT '0' AFTER `dir_online`;";
166 166
         if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
167
-            xoops_error($GLOBALS['xoopsDB']->error() . '<br>' . $sql);
167
+            xoops_error($GLOBALS['xoopsDB']->error().'<br>'.$sql);
168 168
             $module->setErrors("Error when adding '$field' to table '$table'.");
169 169
             $ret = false;
170 170
         }
Please login to merge, or discard this patch.
index.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -30,15 +30,15 @@  discard block
 block discarded – undo
30 30
     Github\Releases
31 31
 };
32 32
 
33
-require __DIR__ . '/header.php';
33
+require __DIR__.'/header.php';
34 34
 $GLOBALS['xoopsOption']['template_main'] = 'wggithub_index.tpl';
35
-include_once \XOOPS_ROOT_PATH . '/header.php';
35
+include_once \XOOPS_ROOT_PATH.'/header.php';
36 36
 
37 37
 // Permissions
38 38
 $permGlobalView = $permissionsHandler->getPermGlobalView();
39 39
 if (!$permGlobalView) {
40 40
     $GLOBALS['xoopsTpl']->assign('error', _NOPERM);
41
-    require __DIR__ . '/footer.php';
41
+    require __DIR__.'/footer.php';
42 42
 }
43 43
 $permGlobalRead = $permissionsHandler->getPermGlobalRead();
44 44
 $permReadmeUpdate = $permissionsHandler->getPermReadmeUpdate();
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 
53 53
 // Define Stylesheet
54 54
 $GLOBALS['xoTheme']->addStylesheet($style, null);
55
-$GLOBALS['xoTheme']->addStylesheet(WGGITHUB_URL . '/assets/css/tabs.css', null);
55
+$GLOBALS['xoTheme']->addStylesheet(WGGITHUB_URL.'/assets/css/tabs.css', null);
56 56
 $keywords = [];
57 57
 // 
58 58
 $GLOBALS['xoopsTpl']->assign('xoops_icons32_url', XOOPS_ICONS32_URL);
@@ -120,13 +120,13 @@  discard block
 block discarded – undo
120 120
             foreach (\array_keys($directoriesAll) as $i) {
121 121
                 $directories[$i] = $directoriesAll[$i]->getValuesDirectories();
122 122
                 $dirName = $directoriesAll[$i]->getVar('dir_name');
123
-                $dirFilterRelease = (bool)$directoriesAll[$i]->getVar('dir_filterrelease');
123
+                $dirFilterRelease = (bool) $directoriesAll[$i]->getVar('dir_filterrelease');
124 124
                 $repos = [];
125 125
                 $crRepositories = new \CriteriaCompo();
126 126
                 $crRepositories->add(new \Criteria('repo_user', $dirName));
127 127
                 $repositoriesCountTotal = $repositoriesHandler->getCount($crRepositories);
128 128
                 if ('any' === $filterRelease && $dirFilterRelease) {
129
-                    $crRepositories->add(new \Criteria('repo_prerelease', 1) );
129
+                    $crRepositories->add(new \Criteria('repo_prerelease', 1));
130 130
                     $crRepositories->add(new \Criteria('repo_release', 1), 'OR');
131 131
                 }
132 132
                 if ('final' === $filterRelease && $dirFilterRelease) {
@@ -181,9 +181,9 @@  discard block
 block discarded – undo
181 181
                 }
182 182
                 $directories[$i]['repos'] = $repos;
183 183
                 $directories[$i]['previousRepos'] = $start > 0;
184
-                $directories[$i]['previousOp'] = '&amp;start=' . ($start - $limit) . '&amp;limit=' . $limit . '&amp;release=' . $filterRelease . '&amp;sortby=' . $filterSortby;
184
+                $directories[$i]['previousOp'] = '&amp;start='.($start - $limit).'&amp;limit='.$limit.'&amp;release='.$filterRelease.'&amp;sortby='.$filterSortby;
185 185
                 $directories[$i]['nextRepos'] = ($repositoriesCount - $start) > $limit;
186
-                $directories[$i]['nextOp'] = '&amp;start=' . ($start + $limit) . '&amp;limit=' . $limit . '&amp;release=' . $filterRelease . '&amp;sortby=' . $filterSortby;
186
+                $directories[$i]['nextOp'] = '&amp;start='.($start + $limit).'&amp;limit='.$limit.'&amp;release='.$filterRelease.'&amp;sortby='.$filterSortby;
187 187
                 $GLOBALS['xoopsTpl']->assign('start', $start);
188 188
                 $GLOBALS['xoopsTpl']->assign('limit', $limit);
189 189
                 $GLOBALS['xoopsTpl']->assign('menu', $menu);
@@ -194,8 +194,8 @@  discard block
 block discarded – undo
194 194
             unset($crDirectories, $directories);
195 195
             // Display Navigation
196 196
             if ($directoriesCount > $limit) {
197
-                include_once \XOOPS_ROOT_PATH . '/class/pagenav.php';
198
-                $pagenav = new \XoopsPageNav($directoriesCount, $limit, $start, 'start', 'op=list&limit=' . $limit);
197
+                include_once \XOOPS_ROOT_PATH.'/class/pagenav.php';
198
+                $pagenav = new \XoopsPageNav($directoriesCount, $limit, $start, 'start', 'op=list&limit='.$limit);
199 199
                 $GLOBALS['xoopsTpl']->assign('pagenav', $pagenav->renderNav(4));
200 200
             }
201 201
             $GLOBALS['xoopsTpl']->assign('lang_thereare', \sprintf(\_MA_WGGITHUB_INDEX_THEREARE, $directoriesCount));
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
         // Permissions
209 209
         if (!$permGlobalRead) {
210 210
             $GLOBALS['xoopsTpl']->assign('error', _NOPERM);
211
-            require __DIR__ . '/footer.php';
211
+            require __DIR__.'/footer.php';
212 212
         }
213 213
         executeUpdate();
214 214
         break;
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
         // Permissions
217 217
         if (!$permReadmeUpdate) {
218 218
             $GLOBALS['xoopsTpl']->assign('error', _NOPERM);
219
-            require __DIR__ . '/footer.php';
219
+            require __DIR__.'/footer.php';
220 220
         }
221 221
         $repoId = Request::getInt('repo_id', 0);
222 222
         $repoUser  = Request::getString('repo_user', 'none');
@@ -229,14 +229,14 @@  discard block
 block discarded – undo
229 229
 // Breadcrumbs
230 230
 $xoBreadcrumbs[] = ['title' => \_MA_WGGITHUB_INDEX];
231 231
 // Keywords
232
-wggithubMetaKeywords($helper->getConfig('keywords') . ', ' . \implode(',', $keywords));
232
+wggithubMetaKeywords($helper->getConfig('keywords').', '.\implode(',', $keywords));
233 233
 unset($keywords);
234 234
 // Description
235 235
 wggithubMetaDescription(\_MA_WGGITHUB_INDEX_DESC);
236 236
 $GLOBALS['xoopsTpl']->assign('xoops_mpageurl', WGGITHUB_URL.'/index.php');
237 237
 $GLOBALS['xoopsTpl']->assign('xoops_icons32_url', XOOPS_ICONS32_URL);
238 238
 $GLOBALS['xoopsTpl']->assign('wggithub_upload_url', WGGITHUB_UPLOAD_URL);
239
-require __DIR__ . '/footer.php';
239
+require __DIR__.'/footer.php';
240 240
 
241 241
 
242 242
 
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
  *
246 246
  * @return bool
247 247
  */
248
-function executeUpdate(){
248
+function executeUpdate() {
249 249
 
250 250
     $github = Github::getInstance();
251 251
     $helper = Helper::getInstance();
Please login to merge, or discard this patch.
class/Github/Github.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -230,7 +230,7 @@
 block discarded – undo
230 230
         }
231 231
 
232 232
         if (0 == \count($setting)) {
233
-            \redirect_header(XOOPS_URL . '/index.php', 3, \_AM_WGGITHUB_THEREARENT_SETTINGS);
233
+            \redirect_header(XOOPS_URL.'/index.php', 3, \_AM_WGGITHUB_THEREARENT_SETTINGS);
234 234
         }
235 235
         $this->userAuth = $setting['user'];
236 236
         $this->tokenAuth = $setting['token'];
Please login to merge, or discard this patch.
class/ReadmesHandler.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
                     $readmesObj->setVar('rm_content', $readme['content']);
171 171
                     $readmesObj->setVar('rm_encoding', $readme['encoding']);
172 172
                     $readmesObj->setVar('rm_downloadurl', $readme['download_url']);
173
-                    $readmesObj->setVar('rm_datecreated',time());
173
+                    $readmesObj->setVar('rm_datecreated', time());
174 174
                     $readmesObj->setVar('rm_submitter', $submitter);
175 175
                     // Insert Data
176 176
                     if (!$readmesHandler->insert($readmesObj)) {
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
             $readmesObj->setVar('rm_content', $readme['content']);
241 241
             $readmesObj->setVar('rm_encoding', $readme['encoding']);
242 242
             $readmesObj->setVar('rm_downloadurl', $readme['download_url']);
243
-            $readmesObj->setVar('rm_datecreated',time());
243
+            $readmesObj->setVar('rm_datecreated', time());
244 244
             $readmesObj->setVar('rm_submitter', $submitter);
245 245
             // Insert Data
246 246
             if (!$readmesHandler->insert($readmesObj)) {
@@ -278,10 +278,10 @@  discard block
 block discarded – undo
278 278
     public function updateRepoReadme()
279 279
     {
280 280
         // update repo_readme
281
-        $sql = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('wggithub_repositories') . ' INNER JOIN ' . $GLOBALS['xoopsDB']->prefix('wggithub_readmes');
282
-        $sql .= ' ON ' . $GLOBALS['xoopsDB']->prefix('wggithub_repositories') . '.repo_id = ' . $GLOBALS['xoopsDB']->prefix('wggithub_readmes') . '.rm_repoid ';
283
-        $sql .= 'SET ' . $GLOBALS['xoopsDB']->prefix('wggithub_repositories') . '.repo_readme = 1 ';
284
-        $sql .= 'WHERE (((' . $GLOBALS['xoopsDB']->prefix('wggithub_readmes') . '.rm_id)>0));';
281
+        $sql = 'UPDATE '.$GLOBALS['xoopsDB']->prefix('wggithub_repositories').' INNER JOIN '.$GLOBALS['xoopsDB']->prefix('wggithub_readmes');
282
+        $sql .= ' ON '.$GLOBALS['xoopsDB']->prefix('wggithub_repositories').'.repo_id = '.$GLOBALS['xoopsDB']->prefix('wggithub_readmes').'.rm_repoid ';
283
+        $sql .= 'SET '.$GLOBALS['xoopsDB']->prefix('wggithub_repositories').'.repo_readme = 1 ';
284
+        $sql .= 'WHERE ((('.$GLOBALS['xoopsDB']->prefix('wggithub_readmes').'.rm_id)>0));';
285 285
         $GLOBALS['xoopsDB']->queryF($sql);
286 286
 
287 287
         return true;
Please login to merge, or discard this patch.