Issues (127)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  Header Injection
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.
Labels
Severity
1
<?php
2
3
declare(strict_types=1);
4
5
/*
6
 You may not change or alter any portion of this comment or credits
7
 of supporting developers from this source code or any supporting source code
8
 which is considered copyrighted (c) material of the original comment or credit authors.
9
10
 This program is distributed in the hope that it will be useful,
11
 but WITHOUT ANY WARRANTY; without even the implied warranty of
12
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
13
*/
14
15
/**
16
 * wgFileManager module for xoops
17
 *
18
 * @copyright    2021 XOOPS Project (https://xoops.org)
19
 * @license      GPL 2.0 or later
20
 * @package      wgfilemanager
21
 * @author       Goffy - Wedega - Email:[email protected] - Website:https://xoops.wedega.com
22
 */
23
24
use Xmf\Request;
0 ignored issues
show
This use statement conflicts with another class in this namespace, Request. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
25
use XoopsModules\Wgfilemanager;
26
use XoopsModules\Wgfilemanager\Constants;
27
use XoopsModules\Wgfilemanager\Common;
28
29
require __DIR__ . '/header.php';
30
$GLOBALS['xoopsOption']['template_main'] = 'wgfilemanager_file.tpl';
31
require_once \XOOPS_ROOT_PATH . '/header.php';
32
33
$op     = Request::getCmd('op', 'list');
34
$fileId = Request::getInt('file_id');
35
$dirId  = Request::getInt('dir_id');
36
$start  = Request::getInt('start');
37
$limit  = Request::getInt('limit', $helper->getConfig('userpager'));
38
$GLOBALS['xoopsTpl']->assign('start', $start);
39
$GLOBALS['xoopsTpl']->assign('limit', $limit);
40
41
// Define Stylesheet
42
foreach ($styles as $style) {
43
    $GLOBALS['xoTheme']->addStylesheet($style, null);
44
}
45
// Paths
46
$GLOBALS['xoopsTpl']->assign('xoops_icons32_url', \XOOPS_ICONS32_URL);
47
$GLOBALS['xoopsTpl']->assign('wgfilemanager_url', \WGFILEMANAGER_URL);
48
$GLOBALS['xoopsTpl']->assign('wgfilemanager_icon_bi_url', \WGFILEMANAGER_ICONS_URL . '/bootstrap/');
49
$GLOBALS['xoopsTpl']->assign('wgfilemanager_upload_url', \WGFILEMANAGER_UPLOAD_URL);
50
// Keywords
51
$keywords = [];
52
// Breadcrumbs
53
$xoBreadcrumbs[] = ['title' => \_MA_WGFILEMANAGER_INDEX, 'link' => 'index.php'];
54
if ($dirId > 1) {
55
    $dirArray = $directoryHandler->getDirListBreadcrumb($dirId);
56
    $dirListBreadcrumb = array_reverse($dirArray, true);
57
    foreach ($dirListBreadcrumb as $key => $value) {
58
        $xoBreadcrumbs[] = ['title' => $value, 'link' => 'index.php?dir_id=' . $key];
59
    }
60
}
61
// Permissions
62
$GLOBALS['xoopsTpl']->assign('showItem', $fileId > 0);
63
// params for url
64
$urlParams = '&amp;start=' . $start . '&amp;limit=' . $limit;
65
$urlParams = '&amp;dir_id=' . $dirId . '&amp;limit=' . $limit;
66
67
switch ($op) {
68
    case 'show':
69
        // Breadcrumbs
70
        $xoBreadcrumbs[] = ['title' => \_MA_WGFILEMANAGER_FILE_DETAILS];
71
        if ($fileId > 0) {
72
            $fileObj = $fileHandler->get($fileId);
73
            if (!\is_object($fileObj)) {
74
                \redirect_header('file.php', 3, \_MA_WGFILEMANAGER_INVALID_PARAMS);
75
            }
76
        } else {
77
            \redirect_header('file.php', 3, \_MA_WGFILEMANAGER_INVALID_PARAMS);
78
        }
79
        $GLOBALS['xoopsTpl']->assign('fileShow', true);
80
        $GLOBALS['xoopsTpl']->assign('showBtnBack', true);
81
        $GLOBALS['xoopsTpl']->assign('useBroken', (bool)$helper->getConfig('use_broken'));
82
        // get permissions
83
        $GLOBALS['xoopsTpl']->assign('permEditFile', $permissionsHandler->getPermSubmitDirectory($dirId));
84
        $GLOBALS['xoopsTpl']->assign('permDownloadFileFromDir', $permissionsHandler->getPermDownloadFileFromDir($dirId));
85
        $GLOBALS['xoopsTpl']->assign('permUploadFileToDir', $permissionsHandler->getPermUploadFileToDir($dirId));
86
        $GLOBALS['xoopsTpl']->assign('permViewDirectory', $permissionsHandler->getPermViewDirectory($dirId));
87
        // get iconset
88
        $iconSet = $helper->getConfig('iconset');
89
        $fileIcons = [];
90
        if ('none' !== $iconSet) {
91
            $fileIcons = $fileHandler->getFileIconCollection($iconSet);
92
        }
93
        // Get File
94
        $file = $fileObj->getValuesFile();
95
        $ext = substr(strrchr($file['name'], '.'), 1);
96
        $fileCategory = isset($fileIcons['files'][$ext]) ? (int)$fileIcons['files'][$ext]['category'] : 0;
97
        $file['category'] = $fileCategory;
98
        $file['image']    = false;
99
        $file['pdf']      = false;
100
        switch ($fileCategory) {
101
            case 0:
102
                $previewUrl = isset($fileIcons['files'][$ext]) ? $fileIcons['files'][$ext]['src'] : $fileIcons['default'];
103
                break;
104
            case Constants::MIMETYPE_CAT_IMAGE:
105
                $file['image'] = true;
106
                $previewUrl = $file['real_url'];
107
                break;
108
            case Constants::MIMETYPE_CAT_PDF:
109
                $file['pdf'] = true;
110
                $previewUrl = $file['real_url'];
111
                break;
112
        }
113
        $file['preview_url'] = $previewUrl;
114
        $GLOBALS['xoopsTpl']->assign('file', $file);
115
        unset($fileList);
116
        $GLOBALS['xoopsTpl']->assign('table_type', $helper->getConfig('table_type'));
117
        $GLOBALS['xoopsTpl']->assign('panel_type', $helper->getConfig('panel_type'));
118
        $GLOBALS['xoopsTpl']->assign('xoops_pagetitle', \strip_tags($GLOBALS['xoopsModule']->getVar('name')));
119
120
        break;
121
    case 'list':
122
    default:
123
124
        break;
125
    case 'save':
126
        // Security Check
127
        if (!$GLOBALS['xoopsSecurity']->check()) {
128
            \redirect_header('index.php', 3, \implode(',', $GLOBALS['xoopsSecurity']->getErrors()));
129
        }
130
        if (!$permissionsHandler->getPermUploadFileToDir($dirId) && !$permissionsHandler->getPermSubmitDirectory($dirId)) {
131
            \redirect_header('index.php?op=list', 3, \_NOPERM);
132
        }
133
        if ($fileId > 0) {
134
            $fileObj = $fileHandler->get($fileId);
135
        } else {
136
            $fileObj = $fileHandler->create();
137
        }
138
        $fileHandlename = (int)$helper->getConfig('file_handlename');
139
        // Set Vars
140
        $directoryId    = Request::getInt('directory_id');
141
        $directoryIdOld = Request::getInt('directory_id_old');
142
        $fileObj->setVar('directory_id', $directoryId);
143
        // get full path of current directory
144
        $dirBasePath = '/';
145
        if ($directoryId > 0) {
146
            $dirBasePath .= $directoryHandler->getFullPath($directoryId);
147
            $dirBasePath .= '/';
148
        }
149
        $repoPath = \WGFILEMANAGER_REPO_PATH . $dirBasePath;
150
151
        $uploaderErrors = '';
152
        $redirOp = $fileId > 0 ? 'edit' : 'new';
153
154
        if (0 == $fileId) {
155
            //upload new file
156
            require_once \XOOPS_ROOT_PATH . '/class/uploader.php';
157
            $filename     = $_FILES['fil_name']['name'];
158
            $fileMimetype = $_FILES['fil_name']['type'];
159
            $fileSize     = $_FILES['fil_name']['size'];
160
            $fileNewName  = substr($filename, 0, (strlen($filename)) - (strlen(strrchr($filename, '.'))));
161
            $extension    = \str_replace($fileNewName, '', $filename);
162
            //do same replacements as class/uploader.php
163
            $fileNewName = iconv('UTF-8', 'ASCII//TRANSLIT', $fileNewName);
164
            $fileNewName = preg_replace('!\s+!', '_', $fileNewName);
165
            $fileNewName = preg_replace("/[^a-zA-Z0-9\._-]/", '', $fileNewName);
166
167
            //check for new files, whether file already exists
168
            if (file_exists($repoPath . $fileNewName . $extension)) {
169
                \redirect_header('file.php?op=' . $redirOp . '&amp;file_id=' . $fileId . '&amp;dir_id=' . $directoryId, 5, \_MA_WGFILEMANAGER_FILE_ERROR_EXISTS);
170
            }
171
            $allowedMimeTypes = $mimetypeHandler->getMimetypeArray();
172
            $uploader = new \XoopsMediaUploader($repoPath, $allowedMimeTypes, $helper->getConfig('maxsize_file'), null, null);
173
            if ($uploader->fetchMedia($_POST['xoops_upload_file'][0])) {
174
                if (Constants::FILE_HANDLENAME_UNIQUE === $fileHandlename) {
175
                    $uploader->setPrefix($fileNewName . '_');
176
                } else {
177
                    $uploader->setTargetFileName($fileNewName . $extension);
178
                }
179
                $uploader->fetchMedia($_POST['xoops_upload_file'][0]);
180
                if ($uploader->upload()) {
181
                    $fileObj->setVar('name', $uploader->getSavedFileName());
182
                } else {
183
                    $uploaderErrors .= '<br>' . $uploader->getErrors();
184
                }
185
            } else {
186
                if ('' !== $filename) {
187
                    $uploaderErrors .= '<br>' . $uploader->getErrors();
188
                }
189
            }
190
            if ('' !== $uploaderErrors) {
191
                \redirect_header('file.php?op=' . $redirOp . '&amp;file_id=' . $fileId . '&amp;dir_id=' . $directoryId, 5, $uploaderErrors);
192
            }
193
        } else {
194
            //handle existing
195
            $fileName    = Request::getString('fil_name');
196
            $fileNameOld = Request::getString('fil_name_old');
197
            $movefile    = $directoryIdOld !== $directoryId;
198
            $renameFile  = $fileName !== $fileNameOld;
199
            if ($directoryIdOld !== $directoryId) {
200
                //move and rename file
201
                $dirBasePathOld = '/';
202
                $dirBasePathOld .= $directoryHandler->getFullPath($directoryIdOld);
203
                $dirBasePathOld .= '/';
204
205
                $fileHandler->renameFile($dirBasePathOld . $fileNameOld, $dirBasePath . $fileName);
206
            } else {
207
                if ($fileName !== $fileNameOld) {
208
                    //rename file
209
                    $fileHandler->renameFile($dirBasePath . $fileNameOld, $dirBasePath . $fileName);
210
                }
211
            }
212
            $fileObj->setVar('name', $fileName);
213
        }
214
        $fileObj->setVar('description', Request::getText('description'));
215
        $fileObj->setVar('ip', Request::getString('ip'));
216
        $fileObj->setVar('status', Request::getInt('status'));
217
        if (Request::hasVar('date_created')) {
218
            $fileDate_createdObj = \DateTime::createFromFormat(\_SHORTDATESTRING, Request::getString('date_created'));
219
            $fileObj->setVar('date_created', $fileDate_createdObj->getTimestamp());
220
        } else {
221
            $fileObj->setVar('date_created', time());
222
        }
223
        $fileObj->setVar('submitter', Request::getInt('submitter'));
224
        // Insert Data
225
        if ($fileHandler->insert($fileObj)) {
226
            $newFileId = $fileId > 0 ? $fileId : $fileObj->getNewInsertedId();
227
            unset($fileObj);
228
            $fileObj = $fileHandler->get($newFileId);
229
            $fileSaved = $repoPath . $fileObj->getVar('name');
230
            $fileObj->setVar('mimetype', \mime_content_type($fileSaved));
231
            $fileObj->setVar('mtime', \filemtime($fileSaved));
232
            $fileObj->setVar('ctime', \filectime($fileSaved));
233
            $fileObj->setVar('size', \filesize($fileSaved));
234
            $fileHandler->insert($fileObj);
235
            \redirect_header('index.php?op=list&amp;start=' . $start . '&amp;limit=' . $limit . '&amp;dir_id=' . $dirId, 2, \_AM_WGFILEMANAGER_FORM_OK);
236
        }
237
        // Get Form
238
        $GLOBALS['xoopsTpl']->assign('error', $fileObj->getHtmlErrors());
239
        $form = $fileObj->getForm();
240
        $GLOBALS['xoopsTpl']->assign('form', $form->render());
241
        break;
242
    case 'new':
243
        if (!$permissionsHandler->getPermUploadFileToDir($dirId)) {
244
            \redirect_header('index.php?op=list', 3, \_NOPERM);
245
        }
246
        // Breadcrumbs
247
        $xoBreadcrumbs[] = ['title' => \_MA_WGFILEMANAGER_FILE_ADD];
248
        // Form Create
249
        $fileObj = $fileHandler->create();
250
        $fileObj->start = $start;
251
        $fileObj->limit = $limit;
252
        $fileObj->setVar('directory_id', $dirId);
253
        $fileObj->setVar('directory_id_old', $dirId);
254
        $form = $fileObj->getForm();
255
        $GLOBALS['xoopsTpl']->assign('form', $form->render());
256
        break;
257
    case 'edit':
258
        if (!$permissionsHandler->getPermSubmitDirectory($dirId)) {
259
            \redirect_header('index.php?op=list', 3, \_NOPERM);
260
        }
261
        // Breadcrumbs
262
        $xoBreadcrumbs[] = ['title' => \_MA_WGFILEMANAGER_FILE_EDIT];
263
        // Check params
264
        if (0 == $fileId) {
265
            \redirect_header('index.php?op=list', 3, \_MA_WGFILEMANAGER_INVALID_PARAM);
266
        }
267
        // Get Form
268
        $fileObj = $fileHandler->get($fileId);
269
        $fileObj->start = $start;
270
        $fileObj->limit = $limit;
271
        $form = $fileObj->getForm();
272
        $GLOBALS['xoopsTpl']->assign('form', $form->render());
273
        break;
274
    case 'delete':
275
        if (!$permissionsHandler->getPermSubmitDirectory($dirId)) {
276
            \redirect_header('index.php?op=list', 3, \_NOPERM);
277
        }
278
        // Breadcrumbs
279
        $xoBreadcrumbs[] = ['title' => \_MA_WGFILEMANAGER_FILE_DELETE];
280
        // Check params
281
        if (0 == $fileId) {
282
            \redirect_header('index.php?op=list', 3, \_MA_WGFILEMANAGER_INVALID_PARAM);
283
        }
284
        $fileObj = $fileHandler->get($fileId);
285
        $file = $fileObj->getValuesFile();
286
        if (isset($_REQUEST['ok']) && 1 == $_REQUEST['ok']) {
287
            if (!$GLOBALS['xoopsSecurity']->check()) {
288
                \redirect_header('index.php', 3, \implode(', ', $GLOBALS['xoopsSecurity']->getErrors()));
289
            }
290
            $filePath = $file['real_path'];
291
            if ($fileHandler->delete($fileObj)) {
292
                \unlink($filePath);
293
                //get param list
294
                $params = '?op=list';
295
                $params .= '&amp;dir_id=' . $fileObj->getVar('directory_id');
296
                $params .= '&amp;start=' . $start;
297
                $params .= '&amp;limit=' . $limit;
298
                \redirect_header('index.php' . $params, 3, \_MA_WGFILEMANAGER_FORM_DELETE_OK);
299
            } else {
300
                $GLOBALS['xoopsTpl']->assign('error', $fileObj->getHtmlErrors());
301
            }
302
        } else {
303
            $customConfirm = new Common\Confirm(
304
                ['ok' => 1, 'id' => $fileId, 'start' => $start, 'limit' => $limit, 'dir_id' => $dirId, 'op' => 'delete'],
305
                $_SERVER['REQUEST_URI'],
306
                \sprintf(\_MA_WGFILEMANAGER_FORM_SURE_DELETE, $file['name']));
307
            $form = $customConfirm->getFormConfirm();
308
            $GLOBALS['xoopsTpl']->assign('form', $form->render());
309
        }
310
        break;
311
    case 'broken':
312
        // Breadcrumbs
313
        $xoBreadcrumbs[] = ['title' => \_MA_WGFILEMANAGER_BROKEN];
314
        // Check params
315
        if (0 == $fileId) {
316
            \redirect_header('file.php?op=list', 3, \_MA_WGFILEMANAGER_INVALID_PARAM);
317
        }
318
        $fileObj = $fileHandler->get($fileId);
319
        $fileName = $fileObj->getVar('name');
320
        if (isset($_REQUEST['ok']) && 1 == $_REQUEST['ok']) {
321
            if (!$GLOBALS['xoopsSecurity']->check()) {
322
                \redirect_header('file.php', 3, \implode(', ', $GLOBALS['xoopsSecurity']->getErrors()));
323
            }
324
            $fileObj->setVar('status', Constants::STATUS_BROKEN);
325
            if ($fileHandler->insert($fileObj)) {
326
                \redirect_header('index.php?op=list' . $urlParams, 2, \_MA_WGFILEMANAGER_FORM_OK);
327
            } else {
328
                $GLOBALS['xoopsTpl']->assign('error', $fileObj->getHtmlErrors());
329
            }
330
        } else {
331
            $customConfirm = new Common\Confirm(
332
                ['ok' => 1, 'id' => $fileId, 'start' => $start, 'limit' => $limit, 'op' => 'broken'],
333
                $_SERVER['REQUEST_URI'],
334
                \sprintf(\_MA_WGFILEMANAGER_FORM_SURE_BROKEN, $fileName));
335
            $form = $customConfirm->getFormConfirm();
336
            $GLOBALS['xoopsTpl']->assign('form', $form->render());
337
        }
338
        break;
339
    case 'favorite_pin':
340
        //check perms
341
        if (!$permissionsHandler->getPermSubmitDirectory($dirId)) {
342
            \redirect_header('index.php?op=list', 3, \_NOPERM);
343
        }
344
        // Check params
345
        if (0 === $fileId) {
346
            \redirect_header('index.php?op=list', 3, \_MA_WGFILEMANAGER_INVALID_PARAM);
347
        }
348
        //get current user
349
        $userUid = 0;
350
        if (isset($GLOBALS['xoopsUser']) && \is_object($GLOBALS['xoopsUser'])) {
351
            $userUid = $GLOBALS['xoopsUser']->uid();
352
        }
353
        if (0 === $userUid) {
354
            \redirect_header('index.php?op=list', 3, \_MA_WGFILEMANAGER_INVALID_PARAM);
355
        }
356
        $favoriteObj = $favoriteHandler->create();
357
        $favoriteObj->setVar('file_id', $fileId);
358
        $favoriteObj->setVar('date_created', \time());
359
        $favoriteObj->setVar('submitter', $userUid);
360
        if ($favoriteHandler->insert($favoriteObj)) {
361
            \redirect_header('index.php?op=list&amp;start=' . $start . '&amp;limit=' . $limit, 2, \_AM_WGFILEMANAGER_FORM_OK);
362
        } else {
363
            \redirect_header('index.php?op=list&amp;start=' . $start . '&amp;limit=' . $limit, 2, \_MA_WGFILEMANAGER_FAVORITE_ERROR_SET);
364
        }
365
        break;
366
    case 'favorite_unpin':
367
        //check perms
368
        if (!$permissionsHandler->getPermSubmitDirectory($dirId)) {
369
            \redirect_header('index.php?op=list', 3, \_NOPERM);
370
        }
371
        // Check params
372
        if (0 === $fileId) {
373
            \redirect_header('index.php?op=list', 3, \_MA_WGFILEMANAGER_INVALID_PARAM);
374
        }
375
        $favoriteId = Request::getInt('favorite_id');
376
        if (0 === $favoriteId) {
377
            \redirect_header('index.php?op=list', 3, \_MA_WGFILEMANAGER_INVALID_PARAM);
378
        }
379
        $favoriteObj = $favoriteHandler->get($favoriteId);
380
        if ($favoriteHandler->delete($favoriteObj, true)) {
381
           \redirect_header('index.php?op=list&amp;start=' . $start . '&amp;limit=' . $limit, 2, \_AM_WGFILEMANAGER_FORM_OK);
382
        } else {
383
            \redirect_header('index.php?op=list&amp;start=' . $start . '&amp;limit=' . $limit, 2, \_MA_WGFILEMANAGER_FAVORITE_ERROR_SET);
384
        }
385
        break;
386
}
387
388
// Keywords
389
wgfilemanagerMetaKeywords($helper->getConfig('keywords') . ', ' . \implode(',', $keywords));
390
unset($keywords);
391
392
$GLOBALS['xoopsTpl']->assign('xoops_mpageurl', \WGFILEMANAGER_URL.'/file.php');
393
394
require __DIR__ . '/footer.php';
395