ggoffy /
wgfilemanager
| Conditions | 15 |
| Paths | 3072 |
| Total Lines | 130 |
| Code Lines | 94 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 88 | public function getForm($action = false) |
||
| 89 | { |
||
| 90 | $helper = \XoopsModules\Wgfilemanager\Helper::getInstance(); |
||
| 91 | if (!$action) { |
||
| 92 | $action = $_SERVER['REQUEST_URI']; |
||
| 93 | } |
||
| 94 | $isAdmin = \is_object($GLOBALS['xoopsUser']) && $GLOBALS['xoopsUser']->isAdmin($GLOBALS['xoopsModule']->mid()); |
||
| 95 | // Title |
||
| 96 | $title = $this->isNew() ? \_MA_WGFILEMANAGER_DIRECTORY_ADD : \_MA_WGFILEMANAGER_DIRECTORY_EDIT; |
||
| 97 | // handler |
||
| 98 | $directoryHandler = $helper->getHandler('Directory'); |
||
| 99 | // Get Theme Form |
||
| 100 | \xoops_load('XoopsFormLoader'); |
||
| 101 | $form = new \XoopsThemeForm($title, 'form', $action, 'post', true); |
||
| 102 | $form->setExtra('enctype="multipart/form-data"'); |
||
| 103 | // Form Table directory |
||
| 104 | if ($this->getVar('id') > 1 || $this->isNew()) { |
||
| 105 | $dirParentid = $this->getVar('parent_id'); |
||
| 106 | $dirParent_idSelect = new \XoopsFormSelect(\_MA_WGFILEMANAGER_DIRECTORY_PARENT_ID, 'parent_id', $dirParentid); |
||
| 107 | $dirListSelect = new \RecursiveIteratorIterator(new \RecursiveArrayIterator($directoryHandler->getDirListFormSelect(0))); |
||
| 108 | foreach ($dirListSelect as $key => $value) { |
||
| 109 | $dirParent_idSelect->addOption($key, $value); |
||
|
Bug
introduced
by
|
|||
| 110 | } |
||
| 111 | $form->addElement($dirParent_idSelect); |
||
| 112 | $form->addElement(new \XoopsFormHidden('parent_id_old', $dirParentid)); |
||
| 113 | } else { |
||
| 114 | $form->addElement(new \XoopsFormHidden('parent_id', 0)); |
||
| 115 | $form->addElement(new \XoopsFormHidden('parent_id_old', 0)); |
||
| 116 | } |
||
| 117 | // Form Text dirName |
||
| 118 | $dirName = $this->getVar('name'); |
||
| 119 | $form->addElement(new \XoopsFormText(\_MA_WGFILEMANAGER_DIRECTORY_NAME, 'name', 50, 255, $dirName), true); |
||
| 120 | $form->addElement(new \XoopsFormHidden('name_old', $dirName)); |
||
| 121 | // Form Editor DhtmlTextArea dirDescription |
||
| 122 | $dirDescription = $this->getVar('description', 'e'); |
||
| 123 | $editorConfigs = []; |
||
| 124 | if ($isAdmin) { |
||
| 125 | $editor = $helper->getConfig('editor_admin'); |
||
| 126 | } else { |
||
| 127 | $editor = $helper->getConfig('editor_user'); |
||
| 128 | } |
||
| 129 | $editorConfigs['name'] = 'description'; |
||
| 130 | $editorConfigs['value'] = $dirDescription; |
||
| 131 | $editorConfigs['rows'] = 5; |
||
| 132 | $editorConfigs['cols'] = 40; |
||
| 133 | $editorConfigs['width'] = '100%'; |
||
| 134 | $editorConfigs['height'] = '400px'; |
||
| 135 | $editorConfigs['editor'] = $editor; |
||
| 136 | $form->addElement(new \XoopsFormEditor(\_MA_WGFILEMANAGER_DIRECTORY_DESCRIPTION, 'description', $editorConfigs)); |
||
| 137 | // Form Text dirFullpath |
||
| 138 | $dirFullpath = $this->getVar('fullpath'); |
||
| 139 | if ($isAdmin) { |
||
| 140 | $tbFullpath = new \XoopsFormLabel(\_MA_WGFILEMANAGER_DIRECTORY_FULLPATH, $dirFullpath); |
||
| 141 | $tbFullpath->setDescription(sprintf(\_MA_WGFILEMANAGER_DIRECTORY_FULLPATH_DESCR, WGFILEMANAGER_UPLOAD_PATH . '/repository')); |
||
| 142 | $form->addElement($tbFullpath); |
||
| 143 | $form->addElement(new \XoopsFormHidden('fullpath', $dirFullpath)); |
||
| 144 | $form->addElement(new \XoopsFormHidden('fullpath_old', $dirFullpath)); |
||
| 145 | } else { |
||
| 146 | $form->addElement(new \XoopsFormHidden('fullpath', $dirFullpath)); |
||
| 147 | $form->addElement(new \XoopsFormHidden('fullpath_old', $dirFullpath)); |
||
| 148 | } |
||
| 149 | // Form Text dirWeight |
||
| 150 | $dirWeight = $this->isNew() ? $directoryHandler->getCount() + 1 : $this->getVar('weight'); |
||
| 151 | //if ($isAdmin) { |
||
| 152 | //$form->addElement(new \XoopsFormText(\_MA_WGFILEMANAGER_DIRECTORY_WEIGHT, 'weight', 50, 255, $dirWeight), true); |
||
| 153 | //} else { |
||
| 154 | $form->addElement(new \XoopsFormHidden('weight', $dirWeight)); |
||
| 155 | //} |
||
| 156 | // Form Text Date Select dirDate_created |
||
| 157 | $dirDate_created = $this->isNew() ? \time() : $this->getVar('date_created'); |
||
| 158 | $form->addElement(new \XoopsFormTextDateSelect(\_MA_WGFILEMANAGER_DIRECTORY_DATE_CREATED, 'date_created', '', $dirDate_created)); |
||
| 159 | // Form Select User dirSubmitter |
||
| 160 | $uidCurrent = \is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->uid() : 0; |
||
| 161 | $dirSubmitter = $this->isNew() ? $uidCurrent : $this->getVar('submitter'); |
||
| 162 | $form->addElement(new \XoopsFormSelectUser(\_MA_WGFILEMANAGER_DIRECTORY_SUBMITTER, 'submitter', false, $dirSubmitter)); |
||
| 163 | // Permissions |
||
| 164 | if ('directory' === $helper->getConfig('permission_type')) { |
||
| 165 | $memberHandler = \xoops_getHandler('member'); |
||
| 166 | $groupList = $memberHandler->getGroupList(); |
||
| 167 | $grouppermHandler = \xoops_getHandler('groupperm'); |
||
| 168 | $fullList[] = \array_keys($groupList); |
||
| 169 | if ($this->isNew()) { |
||
| 170 | //$groupsCanApproveCheckbox = new \XoopsFormCheckBox(\_MA_WGFILEMANAGER_PERM_DIR_APPROVE, 'groups_approve_directory[]', $fullList); |
||
| 171 | $groupsCanSubmitDirCheckbox = new \XoopsFormCheckBox(\_MA_WGFILEMANAGER_PERM_DIR_SUBMIT, 'groups_submit_directory[]', $fullList); |
||
| 172 | $groupsCanViewDirCheckbox = new \XoopsFormCheckBox(\_MA_WGFILEMANAGER_PERM_DIR_VIEW, 'groups_view_directory[]', $fullList); |
||
| 173 | $groupsCanDownloadCheckbox = new \XoopsFormCheckBox(\_MA_WGFILEMANAGER_PERM_FILE_DOWNLOAD_FROM_DIR, 'groups_download_directory[]', $fullList); |
||
| 174 | $groupsCanUploadCheckbox = new \XoopsFormCheckBox(\_MA_WGFILEMANAGER_PERM_FILE_UPLOAD_TO_DIR, 'groups_upload_directory[]', $fullList); |
||
| 175 | } else { |
||
| 176 | //$groupsIdsApprove = $grouppermHandler->getGroupIds('wgfilemanager_approve_directory', $this->getVar('id'), $GLOBALS['xoopsModule']->getVar('mid')); |
||
| 177 | //$groupsIdsApprove[] = \array_values($groupsIdsApprove); |
||
| 178 | //$groupsCanApproveCheckbox = new \XoopsFormCheckBox(\_MA_WGFILEMANAGER_PERM_APPROVE, 'groups_approve_directory[]', $groupsIdsApprove); |
||
| 179 | $groupsIdsSubmit = $grouppermHandler->getGroupIds('wgfilemanager_submit_directory', $this->getVar('id'), $GLOBALS['xoopsModule']->getVar('mid')); |
||
| 180 | $groupsIdsSubmit[] = \array_values($groupsIdsSubmit); |
||
| 181 | $groupsCanSubmitDirCheckbox = new \XoopsFormCheckBox(\_MA_WGFILEMANAGER_PERM_DIR_SUBMIT, 'groups_submit_directory[]', $groupsIdsSubmit); |
||
| 182 | $groupsIdsView = $grouppermHandler->getGroupIds('wgfilemanager_view_directory', $this->getVar('id'), $GLOBALS['xoopsModule']->getVar('mid')); |
||
| 183 | $groupsIdsView[] = \array_values($groupsIdsView); |
||
| 184 | $groupsCanViewDirCheckbox = new \XoopsFormCheckBox(\_MA_WGFILEMANAGER_PERM_DIR_VIEW, 'groups_view_directory[]', $groupsIdsView); |
||
| 185 | $groupsIdsDownload = $grouppermHandler->getGroupIds('wgfilemanager_download_directory', $this->getVar('id'), $GLOBALS['xoopsModule']->getVar('mid')); |
||
| 186 | $groupsIdsDownload[] = \array_values($groupsIdsDownload); |
||
| 187 | $groupsCanDownloadCheckbox = new \XoopsFormCheckBox(\_MA_WGFILEMANAGER_PERM_FILE_DOWNLOAD_FROM_DIR, 'groups_download_directory[]', $groupsIdsDownload); |
||
| 188 | $groupsIdsUpload = $grouppermHandler->getGroupIds('wgfilemanager_upload_directory', $this->getVar('id'), $GLOBALS['xoopsModule']->getVar('mid')); |
||
| 189 | $groupsIdsUpload[] = \array_values($groupsIdsUpload); |
||
| 190 | $groupsCanUploadCheckbox = new \XoopsFormCheckBox(\_MA_WGFILEMANAGER_PERM_FILE_UPLOAD_TO_DIR, 'groups_upload_directory[]', $groupsIdsUpload); |
||
| 191 | } |
||
| 192 | // To Approve |
||
| 193 | //$groupsCanApproveCheckbox->addOptionArray($groupList); |
||
| 194 | //$form->addElement($groupsCanApproveCheckbox); |
||
| 195 | // To Submit |
||
| 196 | $groupsCanSubmitDirCheckbox->addOptionArray($groupList); |
||
| 197 | $groupsCanSubmitDirCheckbox->setDescription(\_MA_WGFILEMANAGER_PERM_DIR_SUBMIT_DESC); |
||
| 198 | $form->addElement($groupsCanSubmitDirCheckbox); |
||
| 199 | // To View |
||
| 200 | $groupsCanViewDirCheckbox->addOptionArray($groupList); |
||
| 201 | $groupsCanViewDirCheckbox->setDescription(\_MA_WGFILEMANAGER_PERM_DIR_VIEW_DESC); |
||
| 202 | $form->addElement($groupsCanViewDirCheckbox); |
||
| 203 | // To download |
||
| 204 | $groupsCanDownloadCheckbox->addOptionArray($groupList); |
||
| 205 | $groupsCanDownloadCheckbox->setDescription(\_MA_WGFILEMANAGER_PERM_FILE_DOWNLOAD_FROM_DIR_DESC); |
||
| 206 | $form->addElement($groupsCanDownloadCheckbox); |
||
| 207 | // To upload |
||
| 208 | $groupsCanUploadCheckbox->addOptionArray($groupList); |
||
| 209 | $groupsCanUploadCheckbox->setDescription(\_MA_WGFILEMANAGER_PERM_FILE_UPLOAD_TO_DIR_DESC); |
||
| 210 | $form->addElement($groupsCanUploadCheckbox); |
||
| 211 | } |
||
| 212 | // To Save |
||
| 213 | $form->addElement(new \XoopsFormHidden('op', 'save')); |
||
| 214 | $form->addElement(new \XoopsFormHidden('start', $this->start)); |
||
| 215 | $form->addElement(new \XoopsFormHidden('limit', $this->limit)); |
||
| 216 | $form->addElement(new \XoopsFormButtonTray('', \_SUBMIT, 'submit', '', false)); |
||
| 217 | return $form; |
||
| 218 | } |
||
| 269 |
Loading history...