Issues (314)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  Header Injection
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/Common/Resizer.php (4 issues)

Labels
Severity
1
<?php
2
3
namespace XoopsModules\Modulebuilder\Common;
4
5
/*
6
 You may not change or alter any portion of this comment or credits
7
 of supporting developers from this source code or any supporting source code
8
 which is considered copyrighted (c) material of the original comment or credit authors.
9
10
 This program is distributed in the hope that it will be useful,
11
 but WITHOUT ANY WARRANTY; without even the implied warranty of
12
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
13
*/
14
15
/**
16
 * Image resizer class for xoops
17
 *
18
 * @copyright      module for xoops
19
 * @license        GPL 2.0 or later
20
 * @package        XOOPS common
21
 * @since          1.0
22
 * @min_xoops      2.5.9
23
 * @author         Goffy - Wedega - Email:<[email protected]> - Website:<https://wedega.com>
24
 * @version        $Id: 1.0 Resizer.php 1 Mon 2019-02-09 10:04:49Z XOOPS Project (www.xoops.org) $
25
 */
26
class Resizer
27
{
28
    public $sourceFile    = '';
29
    public $endFile       = '';
30
    public $maxWidth      = 0;
31
    public $maxHeight     = 0;
32
    public $imageMimetype = '';
33
    public $jpgQuality    = 90;
34
    public $mergeType     = 0;
35
    public $mergePos      = 0;
36
    public $degrees       = 0;
37
    public $error         = '';
38
39
    /**
40
     * resize image if size exceed given width/height
41
     * @return string|bool
42
     */
43
    public function resizeImage()
44
    {
45
        // check file extension
46
        switch ($this->imageMimetype) {
47
            case 'image/png':
48
                $img = \imagecreatefrompng($this->sourceFile);
49
                break;
50
            case 'image/jpeg':
51
                $img = \imagecreatefromjpeg($this->sourceFile);
52
                if (!$img) {
53
                    $img = \imagecreatefromstring(file_get_contents($this->sourceFile));
54
                }
55
                break;
56
            case 'image/gif':
57
                $img = \imagecreatefromgif($this->sourceFile);
58
                break;
59
            default:
60
                return 'Unsupported format';
61
        }
62
63
        $width  = \imagesx($img);
64
        $height = \imagesy($img);
65
66
        if ($width > $this->maxWidth || $height > $this->maxHeight) {
67
            // recalc image size based on this->maxWidth/this->maxHeight
68
			$new_width  = 0;
69
			$new_height = 0;
70
            if ($width > $height) {
71
                if ($width < $this->maxWidth) {
72
                    $new_width = $width;
73
                } else {
74
                    $new_width  = $this->maxWidth;
75
                    $divisor    = $width / $new_width;
76
                    $new_height = \floor($height / $divisor);
77
                }
78
            } elseif ($height < $this->maxHeight) {
79
                $new_height = $height;
80
            } else {
81
                $new_height = $this->maxHeight;
82
                $divisor    = $height / $new_height;
83
                $new_width  = \floor($width / $divisor);
84
            }
85
86
            // Create a new temporary image.
87
            $tmpimg = \imagecreatetruecolor($new_width, $new_height);
0 ignored issues
show
It seems like $new_width can also be of type double; however, parameter $width of imagecreatetruecolor() does only seem to accept integer, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

87
            $tmpimg = \imagecreatetruecolor(/** @scrutinizer ignore-type */ $new_width, $new_height);
Loading history...
It seems like $new_height can also be of type double; however, parameter $height of imagecreatetruecolor() does only seem to accept integer, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

87
            $tmpimg = \imagecreatetruecolor($new_width, /** @scrutinizer ignore-type */ $new_height);
Loading history...
88
            \imagealphablending($tmpimg, false);
89
            \imagesavealpha($tmpimg, true);
90
91
            // Copy and resize old image into new image.
92
            \imagecopyresampled($tmpimg, $img, 0, 0, 0, 0, $new_width, $new_height, $width, $height);
0 ignored issues
show
It seems like $new_width can also be of type double; however, parameter $dst_w of imagecopyresampled() does only seem to accept integer, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

92
            \imagecopyresampled($tmpimg, $img, 0, 0, 0, 0, /** @scrutinizer ignore-type */ $new_width, $new_height, $width, $height);
Loading history...
It seems like $new_height can also be of type double; however, parameter $dst_h of imagecopyresampled() does only seem to accept integer, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

92
            \imagecopyresampled($tmpimg, $img, 0, 0, 0, 0, $new_width, /** @scrutinizer ignore-type */ $new_height, $width, $height);
Loading history...
93
94
            \unlink($this->endFile);
95
            //compressing the file
96
            switch ($this->imageMimetype) {
97
                case 'image/png':
98
                    \imagepng($tmpimg, $this->endFile, 0);
99
                    break;
100
                case 'image/jpeg':
101
                    \imagejpeg($tmpimg, $this->endFile, 100);
102
                    break;
103
                case 'image/gif':
104
                    \imagegif($tmpimg, $this->endFile);
105
                    break;
106
            }
107
108
            // release the memory
109
            \imagedestroy($tmpimg);
110
        } else {
111
            return 'copy';
112
        }
113
        \imagedestroy($img);
114
115
        return true;
116
    }
117
118
    /**
119
     * @return bool|string
120
     */
121
    public function resizeAndCrop()
122
    {
123
        // check file extension
124
        switch ($this->imageMimetype) {
125
            case 'image/png':
126
                $original = \imagecreatefrompng($this->sourceFile);
127
                break;
128
            case 'image/jpeg':
129
                $original = \imagecreatefromjpeg($this->sourceFile);
130
                break;
131
            case 'image/gif':
132
                $original = \imagecreatefromgif($this->sourceFile);
133
                break;
134
            default:
135
                return 'Unsupported format';
136
        }
137
138
        if (!$original) {
139
            return false;
140
        }
141
        // GET ORIGINAL IMAGE DIMENSIONS
142
        [$original_w, $original_h] = \getimagesize($this->sourceFile);
143
144
        // RESIZE IMAGE AND PRESERVE PROPORTIONS
145
        $max_width_resize  = $this->maxWidth;
146
        $max_height_resize = $this->maxHeight;
147
        if ($original_w > $original_h) {
148
            $max_height_ratio = $this->maxHeight / $original_h;
149
            $max_width_resize = (int)\round($original_w * $max_height_ratio);
150
        } else {
151
            $max_width_ratio   = $this->maxWidth / $original_w;
152
            $max_height_resize = (int)\round($original_h * $max_width_ratio);
153
        }
154
        if ($max_width_resize < $this->maxWidth) {
155
            $max_height_ratio  = $this->maxWidth / $max_width_resize;
156
            $max_height_resize = (int)\round($this->maxHeight * $max_height_ratio);
157
            $max_width_resize  = $this->maxWidth;
158
        }
159
160
        // CREATE THE PROPORTIONAL IMAGE RESOURCE
161
        $thumb = \imagecreatetruecolor($max_width_resize, $max_height_resize);
162
        if (!\imagecopyresampled($thumb, $original, 0, 0, 0, 0, $max_width_resize, $max_height_resize, $original_w, $original_h)) {
163
            return false;
164
        }
165
        // CREATE THE CENTERED CROPPED IMAGE TO THE SPECIFIED DIMENSIONS
166
        $final = \imagecreatetruecolor($this->maxWidth, $this->maxHeight);
167
168
        $max_width_offset  = 0;
169
        $max_height_offset = 0;
170
        if ($this->maxWidth < $max_width_resize) {
171
            $max_width_offset = (int)\round(($max_width_resize - $this->maxWidth) / 2);
172
        } else {
173
            $max_height_offset = (int)\round(($max_height_resize - $this->maxHeight) / 2);
174
        }
175
176
        if (!\imagecopy($final, $thumb, 0, 0, $max_width_offset, $max_height_offset, $max_width_resize, $max_height_resize)) {
177
            return false;
178
        }
179
        // STORE THE FINAL IMAGE - WILL OVERWRITE $this->endFile
180
        if (!\imagejpeg($final, $this->endFile, $this->jpgQuality)) {
181
            return false;
182
        }
183
184
        return true;
185
    }
186
187
    public function mergeImage()
188
    {
189
        $dest = \imagecreatefromjpeg($this->endFile);
190
        $src  = \imagecreatefromjpeg($this->sourceFile);
191
        if (4 == $this->mergeType) {
192
            $imgWidth  = (int)\round($this->maxWidth / 2 - 1);
193
            $imgHeight = (int)\round($this->maxHeight / 2 - 1);
194
            $posCol2   = (int)\round($this->maxWidth / 2 + 1);
195
            $posRow2   = (int)\round($this->maxHeight / 2 + 1);
196
            switch ($this->mergePos) {
197
                case 1:
198
                    \imagecopy($dest, $src, 0, 0, 0, 0, $imgWidth, $imgHeight); //top left
199
                    break;
200
                case 2:
201
                    \imagecopy($dest, $src, $posCol2, 0, 0, 0, $imgWidth, $imgHeight); //top right
202
                    break;
203
                case 3:
204
                    \imagecopy($dest, $src, 0, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom left
205
                    break;
206
                case 4:
207
                    \imagecopy($dest, $src, $posCol2, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom right
208
                    break;
209
            }
210
        }
211
        if (6 == $this->mergeType) {
212
            $imgWidth  = (int)\round($this->maxWidth / 3 - 1);
213
            $imgHeight = (int)\round($this->maxHeight / 2 - 1);
214
            $posCol2   = (int)\round($this->maxWidth / 3 + 1);
215
            $posCol3   = $posCol2 + (int)\round($this->maxWidth / 3 + 1);
216
            $posRow2   = (int)\round($this->maxHeight / 2 + 1);
217
218
            switch ($this->mergePos) {
219
                case 1:
220
                    \imagecopy($dest, $src, 0, 0, 0, 0, $imgWidth, $imgHeight); //top left
221
                    break;
222
                case 2:
223
                    \imagecopy($dest, $src, $posCol2, 0, 0, 0, $imgWidth, $imgHeight); //top center
224
                    break;
225
                case 3:
226
                    \imagecopy($dest, $src, $posCol3, 0, 0, 0, $imgWidth, $imgHeight); //top right
227
                    break;
228
                case 4:
229
                    \imagecopy($dest, $src, 0, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom left
230
                    break;
231
                case 5:
232
                    \imagecopy($dest, $src, $posCol2, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom center
233
                    break;
234
                case 6:
235
                    \imagecopy($dest, $src, $posCol3, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom right
236
                    break;
237
            }
238
        }
239
        \imagejpeg($dest, $this->endFile);
240
241
        \imagedestroy($src);
242
        \imagedestroy($dest);
243
    }
244
245
    /**
246
     * @return bool|string
247
     */
248
    public function rotateImage()
249
    {
250
        // check file extension
251
        switch ($this->imageMimetype) {
252
            case 'image/png':
253
                $original = \imagecreatefrompng($this->sourceFile);
254
                break;
255
            case 'image/jpeg':
256
                $original = \imagecreatefromjpeg($this->sourceFile);
257
                break;
258
            case 'image/gif':
259
                $original = \imagecreatefromgif($this->sourceFile);
260
                break;
261
            default:
262
                return 'Unsupported format';
263
        }
264
265
        if (!$original) {
266
            return false;
267
        }
268
        // Rotate
269
        $tmpimg = \imagerotate($original, $this->degrees, 0);
270
271
        \unlink($this->endFile);
272
        //compressing the file
273
        switch ($this->imageMimetype) {
274
            case 'image/png':
275
                if (!\imagepng($tmpimg, $this->endFile, 0)) {
276
                    return false;
277
                }
278
                break;
279
            case 'image/jpeg':
280
                if (!\imagejpeg($tmpimg, $this->endFile, $this->jpgQuality)) {
281
                    return false;
282
                }
283
                break;
284
            case 'image/gif':
285
                if (!\imagegif($tmpimg, $this->endFile)) {
286
                    return false;
287
                }
288
                break;
289
        }
290
291
        // release the memory
292
        \imagedestroy($tmpimg);
293
294
        return true;
295
    }
296
}
297