Conditions | 13 |
Paths | 176 |
Total Lines | 88 |
Code Lines | 68 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
83 | private function getTemplatesUserPagesListPanel($moduleDirname, $tableId, $tableMid, $tableName, $tableSoleName, $language) |
||
84 | { |
||
85 | $hc = Modulebuilder\Files\CreateHtmlCode::getInstance(); |
||
86 | $sc = Modulebuilder\Files\CreateSmartyCode::getInstance(); |
||
87 | $fields = $this->getTableFields($tableMid, $tableId); |
||
88 | $ret = ''; |
||
89 | $retNumb = ''; |
||
90 | foreach (array_keys($fields) as $f) { |
||
91 | $fieldElement = $fields[$f]->getVar('field_element'); |
||
92 | if (1 == $fields[$f]->getVar('field_user')) { |
||
93 | if (1 == $fields[$f]->getVar('field_ihead')) { |
||
94 | switch ($fieldElement) { |
||
95 | default: |
||
96 | //case 2: |
||
97 | $fieldName = $fields[$f]->getVar('field_name'); |
||
98 | $rpFieldName = $this->getRightString($fieldName); |
||
99 | $doubleVar = $sc->getSmartyDoubleVar($tableSoleName, $rpFieldName); |
||
100 | $retNumb .= $hc->getHtmlHNumb($doubleVar, '3', 'panel-title', "\t"); |
||
101 | break; |
||
102 | } |
||
103 | } |
||
104 | } |
||
105 | } |
||
106 | $ret .= $hc->getHtmlDiv($retNumb, 'panel-heading'); |
||
107 | $retElem = ''; |
||
108 | $fieldId = ''; |
||
109 | $keyDouble = ''; |
||
110 | foreach (array_keys($fields) as $f) { |
||
111 | if (0 == $f) { |
||
112 | $fieldId = $fields[$f]->getVar('field_name'); |
||
113 | $keyDouble = $sc->getSmartyDoubleVar($tableSoleName, $fieldId); |
||
114 | } |
||
115 | $fieldElement = $fields[$f]->getVar('field_element'); |
||
116 | if (1 == $fields[$f]->getVar('field_user')) { |
||
117 | if (1 == $fields[$f]->getVar('field_ibody')) { |
||
118 | switch ($fieldElement) { |
||
119 | default: |
||
120 | //case 3: |
||
121 | //case 4: |
||
122 | $fieldName = $fields[$f]->getVar('field_name'); |
||
123 | $rpFieldName = $this->getRightString($fieldName); |
||
124 | $doubleVar = $sc->getSmartyDoubleVar($tableSoleName, $rpFieldName); |
||
125 | $retElem .= $hc->getHtmlSpan($doubleVar, 'col-sm-9 justify', "\t"); |
||
126 | break; |
||
127 | case 10: |
||
128 | $fieldName = $fields[$f]->getVar('field_name'); |
||
129 | $rpFieldName = $this->getRightString($fieldName); |
||
130 | $singleVar = $sc->getSmartySingleVar('xoops_icons32_url'); |
||
131 | $doubleVar = $sc->getSmartyDoubleVar($tableSoleName, $rpFieldName); |
||
132 | $img = $hc->getHtmlImage($singleVar . '/' . $doubleVar, (string)$tableName); |
||
133 | $retElem .= $hc->getHtmlSpan($img, 'col-sm-3', "\t"); |
||
134 | unset($img); |
||
135 | break; |
||
136 | case 13: |
||
137 | $fieldName = $fields[$f]->getVar('field_name'); |
||
138 | $rpFieldName = $this->getRightString($fieldName); |
||
139 | $singleVar = $sc->getSmartySingleVar($moduleDirname . '_upload_url'); |
||
140 | $doubleVar = $sc->getSmartyDoubleVar($tableSoleName, $rpFieldName); |
||
141 | $img = $hc->getHtmlImage($singleVar . "/images/{$tableName}/" . $doubleVar, (string)$tableName); |
||
142 | $retElem .= $hc->getHtmlSpan($img, 'col-sm-3',"\t"); |
||
143 | unset($img); |
||
144 | break; |
||
145 | } |
||
146 | } |
||
147 | } |
||
148 | } |
||
149 | |||
150 | |||
151 | $ret .= $hc->getHtmlDiv($retElem, 'panel-body'); |
||
152 | $retFoot = ''; |
||
153 | foreach (array_keys($fields) as $f) { |
||
154 | if (1 == $fields[$f]->getVar('field_user')) { |
||
155 | if (1 == $fields[$f]->getVar('field_ifoot')) { |
||
156 | $fieldName = $fields[$f]->getVar('field_name'); |
||
157 | $rpFieldName = $this->getRightString($fieldName); |
||
158 | $langConst = mb_strtoupper($tableSoleName) . '_' . mb_strtoupper($rpFieldName); |
||
159 | $lang = $sc->getSmartyConst($language, $langConst); |
||
160 | $doubleVar = $sc->getSmartyDoubleVar($tableSoleName, $rpFieldName); |
||
161 | $retFoot .= $hc->getHtmlSpan($lang . ': ' . $doubleVar, 'block-pie justify',"\t"); |
||
162 | } |
||
163 | } |
||
164 | } |
||
165 | $lang = $sc->getSmartyConst($language, 'DETAILS'); |
||
166 | $anchor = $hc->getHtmlAnchor($tableName . ".php?op=show&{$fieldId}=" . $keyDouble, $lang, $lang, '', 'btn btn-primary', '', '', ''); |
||
167 | $retFoot .= $hc->getHtmlSpan($anchor, 'col-sm-12',"\t"); |
||
168 | $ret .= $hc->getHtmlDiv($retFoot, 'panel-foot'); |
||
169 | |||
170 | return $ret; |
||
171 | } |
||
236 |
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.