XoopsModules\Modulebuilder\Morefiles::getFormMorefiles()

Complexity

Conditions	7
Paths	48

Size

Total Lines	62
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getFormMorefiles($action = false)
    {
        $helper = Modulebuilder\Helper::getInstance();
        if (false === $action) {
            $action = \Xmf\Request::getString('REQUEST_URI', '', 'SERVER');
        }

        $isNew = $this->isNew();
        $title = $isNew ? sprintf(_AM_MODULEBUILDER_MORE_FILES_NEW) : sprintf(_AM_MODULEBUILDER_MORE_FILES_EDIT);

        xoops_load('XoopsFormLoader');

        $form = new \XoopsThemeForm($title, 'morefilesform', $action, 'post', true);
        $form->setExtra('enctype="multipart/form-data"');

        $modules       = $helper->getHandler('Modules')->getObjects(null);
        $modulesSelect = new \XoopsFormSelect(_AM_MODULEBUILDER_MORE_FILES_MODULES, 'file_mid', $this->getVar('file_mid'));
        $modulesSelect->addOption('', _AM_MODULEBUILDER_MORE_FILES_MODULE_SELECT);
        foreach ($modules as $mod) {
            //$modulesSelect->addOptionArray();
            $modulesSelect->addOption($mod->getVar('mod_id'), $mod->getVar('mod_name'));
        }
        $form->addElement($modulesSelect, true);

        $typeSelect = new \XoopsFormSelect(_AM_MODULEBUILDER_MORE_FILES_TYPE, 'file_type', $this->getVar('file_type'));
        $typeSelect->addOption(0, ' ');
        $typeSelect->addOption(Constants::MORE_FILES_TYPE_EMPTY, _AM_MODULEBUILDER_MORE_FILES_TYPE_EMPTY);
        $typeSelect->addOption(Constants::MORE_FILES_TYPE_COPY, _AM_MODULEBUILDER_MORE_FILES_TYPE_COPY);
        $form->addElement($typeSelect, true);

        $fileName = new \XoopsFormText(_AM_MODULEBUILDER_MORE_FILES_NAME, 'file_name', 50, 255, $this->getVar('file_name'));

It seems like $this->getVar('file_name') can also be of type array and array; however, parameter $value of XoopsFormText::__construct() does only seem to accept string, maybe add an additional type check?

        $fileName->setDescription(_AM_MODULEBUILDER_MORE_FILES_NAME_DESC);
        $form->addElement($fileName);

        $fileExtension = new \XoopsFormText(_AM_MODULEBUILDER_MORE_FILES_EXTENSION, 'file_extension', 50, 255, $this->getVar('file_extension'));
        $fileExtension->setDescription(_AM_MODULEBUILDER_MORE_FILES_EXTENSION_DESC);
        $form->addElement($fileExtension);


        $fileUpload = $this->isNew() ? '' : $this->getVar('file_upload');
        $fileTray = new \XoopsFormElementTray(_AM_MODULEBUILDER_MORE_FILES_UPLOAD, '<br>' );
        $fileDirectory = '/uploads/modulebuilder/files';
        $fileSelect = new \XoopsFormSelect( ".{$fileDirectory}/", 'file_upload', $fileUpload, 5);
        $filesArray = \XoopsLists::getFileListAsArray( WGTRANSIFEX_UPLOAD_FILES_PATH );

The constant XoopsModules\Modulebuilder\WGTRANSIFEX_UPLOAD_FILES_PATH was not found. Maybe you did not declare it correctly or list all dependencies?

        $fileSelect->addOption('', ' - ');
        foreach($filesArray as $file1) {
            if ('index.html' !== $file1) {
                $fileSelect->addOption("{$file1}", $file1);
            }
        }
        $fileTray->addElement($fileSelect, false);
        $form->addElement($fileTray);


        $fileInfolder = new \XoopsFormText(_AM_MODULEBUILDER_MORE_FILES_INFOLDER, 'file_infolder', 50, 255, $this->getVar('file_infolder'));
        $fileInfolder->setDescription(_AM_MODULEBUILDER_MORE_FILES_INFOLDER_DESC);
        $form->addElement($fileInfolder, true);

        $form->addElement(new \XoopsFormHidden('op', 'save'));
        $form->addElement(new \XoopsFormButton(_REQUIRED . ' <sup class="red bold">*</sup>', 'submit', _SUBMIT, 'submit'));

        return $form;
    }