Conditions | 8 |
Paths | 48 |
Total Lines | 62 |
Code Lines | 42 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
98 | public function getFormMorefiles($action = false) |
||
99 | { |
||
100 | $helper = Modulebuilder\Helper::getInstance(); |
||
101 | if (false === $action) { |
||
102 | $action = \Xmf\Request::getString('REQUEST_URI', '', 'SERVER'); |
||
103 | } |
||
104 | |||
105 | $isNew = $this->isNew(); |
||
106 | $title = $isNew ? \sprintf(\_AM_MODULEBUILDER_MORE_FILES_NEW) : \sprintf(\_AM_MODULEBUILDER_MORE_FILES_EDIT); |
||
107 | |||
108 | \xoops_load('XoopsFormLoader'); |
||
109 | |||
110 | $form = new \XoopsThemeForm($title, 'morefilesform', $action, 'post', true); |
||
111 | $form->setExtra('enctype="multipart/form-data"'); |
||
112 | |||
113 | $modules = $helper->getHandler('Modules')->getObjects(null); |
||
114 | $modulesSelect = new \XoopsFormSelect(\_AM_MODULEBUILDER_MORE_FILES_MODULES, 'file_mid', $this->getVar('file_mid')); |
||
115 | $modulesSelect->addOption('', \_AM_MODULEBUILDER_MORE_FILES_MODULE_SELECT); |
||
116 | foreach ($modules as $mod) { |
||
117 | //$modulesSelect->addOptionArray(); |
||
118 | $modulesSelect->addOption($mod->getVar('mod_id'), $mod->getVar('mod_name')); |
||
119 | } |
||
120 | $form->addElement($modulesSelect, true); |
||
121 | |||
122 | $typeSelect = new \XoopsFormSelect(\_AM_MODULEBUILDER_MORE_FILES_TYPE, 'file_type', $this->getVar('file_type')); |
||
123 | $typeSelect->addOption(0, ' '); |
||
124 | $typeSelect->addOption(Constants::MORE_FILES_TYPE_EMPTY, \_AM_MODULEBUILDER_MORE_FILES_TYPE_EMPTY); |
||
125 | $typeSelect->addOption(Constants::MORE_FILES_TYPE_COPY, \_AM_MODULEBUILDER_MORE_FILES_TYPE_COPY); |
||
126 | $form->addElement($typeSelect, true); |
||
127 | |||
128 | $fileName = new \XoopsFormText(\_AM_MODULEBUILDER_MORE_FILES_NAME, 'file_name', 50, 255, $this->getVar('file_name')); |
||
129 | $fileName->setDescription(\_AM_MODULEBUILDER_MORE_FILES_NAME_DESC); |
||
130 | $form->addElement($fileName); |
||
131 | |||
132 | $fileExtension = new \XoopsFormText(\_AM_MODULEBUILDER_MORE_FILES_EXTENSION, 'file_extension', 50, 255, $this->getVar('file_extension')); |
||
133 | $fileExtension->setDescription(\_AM_MODULEBUILDER_MORE_FILES_EXTENSION_DESC); |
||
134 | $form->addElement($fileExtension); |
||
135 | |||
136 | |||
137 | $fileUpload = $this->isNew() ? '' : $this->getVar('file_upload'); |
||
138 | $fileTray = new \XoopsFormElementTray(\_AM_MODULEBUILDER_MORE_FILES_UPLOAD, '<br>' ); |
||
139 | $fileDirectory = '/uploads/modulebuilder/files'; |
||
140 | $fileSelect = new \XoopsFormSelect( ".{$fileDirectory}/", 'file_upload', $fileUpload, 5); |
||
141 | $filesArray = \XoopsLists::getFileListAsArray( TDMC_UPLOAD_FILES_PATH); |
||
142 | $fileSelect->addOption('', ' - '); |
||
143 | foreach($filesArray as $file1) { |
||
144 | if ('index.html' !== $file1 && 'index.php' !== $file1) { |
||
145 | $fileSelect->addOption("{$file1}", $file1); |
||
146 | } |
||
147 | } |
||
148 | $fileTray->addElement($fileSelect, false); |
||
149 | $form->addElement($fileTray); |
||
150 | |||
151 | |||
152 | $fileInfolder = new \XoopsFormText(\_AM_MODULEBUILDER_MORE_FILES_INFOLDER, 'file_infolder', 50, 255, $this->getVar('file_infolder')); |
||
153 | $fileInfolder->setDescription(\_AM_MODULEBUILDER_MORE_FILES_INFOLDER_DESC); |
||
154 | $form->addElement($fileInfolder, true); |
||
155 | |||
156 | $form->addElement(new \XoopsFormHidden('op', 'save')); |
||
157 | $form->addElement(new \XoopsFormButton(_REQUIRED . ' <sup class="red bold">*</sup>', 'submit', \_SUBMIT, 'submit')); |
||
158 | |||
159 | return $form; |
||
160 | } |
||
187 |