ggoffy /
modulebuilder
| Conditions | 13 |
| Paths | 792 |
| Total Lines | 119 |
| Code Lines | 103 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 91 | private function getLanguageMain($module, $language) |
||
| 92 | { |
||
| 93 | $utility = new \XoopsModules\Modulebuilder\Utility(); |
||
| 94 | |||
| 95 | $moduleName = $module->getVar('mod_name'); |
||
| 96 | $tables = $this->getTables(); |
||
| 97 | $ret = $this->ld->getBlankLine(); |
||
| 98 | $ret .= $this->pc->getPhpCodeIncludeDir('__DIR__', 'admin', true); |
||
| 99 | $ret .= $this->ld->getBlankLine(); |
||
| 100 | $ret .= $this->ld->getAboveHeadDefines('Main'); |
||
| 101 | $ret .= $this->ld->getDefine($language, 'INDEX', 'Overview ' . (string)$module->getVar('mod_name')); |
||
| 102 | $ret .= $this->ld->getDefine($language, 'TITLE', (string)$module->getVar('mod_name')); |
||
| 103 | $ret .= $this->ld->getDefine($language, 'DESC', (string)$module->getVar('mod_description')); |
||
| 104 | $ret .= $this->ld->getDefine($language, 'INDEX_DESC',"Welcome to the homepage of your new module {$moduleName}!<br>This description is only visible on the homepage of this module."); |
||
| 105 | $ret .= $this->ld->getDefine($language, 'NO_PDF_LIBRARY', 'Libraries TCPDF not there yet, upload them in root/Frameworks'); |
||
| 106 | $ret .= $this->ld->getDefine($language, 'NO', 'No'); |
||
| 107 | $ret .= $this->ld->getDefine($language, 'DETAILS', 'Show details'); |
||
| 108 | $ret .= $this->ld->getDefine($language, 'BROKEN', 'Notify broken'); |
||
| 109 | $ret .= $this->ld->getAboveHeadDefines('Contents'); |
||
| 110 | $ucfTableName = ''; |
||
| 111 | $ucfTableSoleName = ''; |
||
|
Unused Code
introduced
by
|
|||
| 112 | $stuTableSoleName = ''; |
||
| 113 | $tableSoleName = ''; |
||
| 114 | $tableSubmit = 0; |
||
| 115 | $tableBroken = 0; |
||
| 116 | $tableRate = 0; |
||
| 117 | $tablePrint = 0; |
||
| 118 | foreach (\array_keys($tables) as $i) { |
||
| 119 | if (1 == $tables[$i]->getVar('table_user')) { |
||
| 120 | $tableName = $tables[$i]->getVar('table_name'); |
||
| 121 | $tableSoleName = $tables[$i]->getVar('table_solename'); |
||
| 122 | if (1 === (int)$tables[$i]->getVar('table_submit')) { |
||
| 123 | $tableSubmit = 1; |
||
| 124 | } |
||
| 125 | if (1 === (int)$tables[$i]->getVar('table_broken')) { |
||
| 126 | $tableBroken = 1; |
||
| 127 | } |
||
| 128 | if (1 === (int)$tables[$i]->getVar('table_rate')) { |
||
| 129 | $tableRate = 1; |
||
| 130 | } |
||
| 131 | if (1 === (int)$tables[$i]->getVar('table_print')) { |
||
| 132 | $tablePrint = 1; |
||
| 133 | } |
||
| 134 | $stuTableName = \mb_strtoupper($tableName); |
||
| 135 | $stuTableSoleName = \mb_strtoupper($tableSoleName); |
||
| 136 | $ucfTableName = $utility::UcFirstAndToLower($tableName); |
||
| 137 | $ucfTableSoleName = $utility::UcFirstAndToLower($tableSoleName); |
||
| 138 | $ret .= $this->ld->getAboveDefines($ucfTableSoleName); |
||
| 139 | $ret .= $this->ld->getDefine($language, $stuTableSoleName, $ucfTableSoleName); |
||
| 140 | if (1 === $tableSubmit) { |
||
| 141 | $ret .= $this->ld->getDefine($language, "{$stuTableSoleName}_ADD", "Add {$ucfTableSoleName}"); |
||
| 142 | $ret .= $this->ld->getDefine($language, "{$stuTableSoleName}_EDIT", "Edit {$ucfTableSoleName}"); |
||
| 143 | $ret .= $this->ld->getDefine($language, "{$stuTableSoleName}_DELETE", "Delete {$ucfTableSoleName}"); |
||
| 144 | $ret .= $this->ld->getDefine($language, "{$stuTableSoleName}_CLONE", "Clone {$ucfTableSoleName}"); |
||
| 145 | } |
||
| 146 | $ret .= $this->ld->getDefine($language, $stuTableName, $ucfTableName); |
||
| 147 | $ret .= $this->ld->getDefine($language, "{$stuTableName}_LIST", "List of {$ucfTableName}"); |
||
| 148 | $ret .= $this->ld->getDefine($language, "{$stuTableName}_TITLE", "{$ucfTableName} title"); |
||
| 149 | $ret .= $this->ld->getDefine($language, "{$stuTableName}_DESC", "{$ucfTableName} description"); |
||
| 150 | |||
| 151 | $ret .= $this->ld->getAboveDefines("Caption of {$ucfTableSoleName}"); |
||
| 152 | $fields = $this->getTableFields($tables[$i]->getVar('table_mid'), $tables[$i]->getVar('table_id')); |
||
| 153 | foreach (\array_keys($fields) as $f) { |
||
| 154 | $fieldName = $fields[$f]->getVar('field_name'); |
||
| 155 | $rpFieldName = $this->getRightString($fieldName); |
||
| 156 | $fieldNameDesc = \ucfirst($rpFieldName); |
||
| 157 | $ret .= $this->ld->getDefine($language, $stuTableSoleName . '_' . $rpFieldName, $fieldNameDesc); |
||
| 158 | } |
||
| 159 | } |
||
| 160 | } |
||
| 161 | $ret .= $this->ld->getDefine($language, 'INDEX_THEREARE', "There are %s {$ucfTableName}"); |
||
| 162 | $ret .= $this->ld->getDefine($language, 'INDEX_LATEST_LIST', "Last {$module->getVar('mod_name')}"); |
||
| 163 | if (1 === $tableSubmit) { |
||
| 164 | $ret .= $this->ld->getAboveDefines('Submit'); |
||
| 165 | $ret .= $this->ld->getDefine($language, 'SUBMIT', 'Submit'); |
||
| 166 | $ret .= $this->ld->getAboveDefines('Form'); |
||
| 167 | $ret .= $this->ld->getDefine($language, 'FORM_OK', 'Successfully saved'); |
||
| 168 | $ret .= $this->ld->getDefine($language, 'FORM_DELETE_OK', 'Successfully deleted'); |
||
| 169 | $ret .= $this->ld->getDefine($language, 'FORM_SURE_DELETE', "Are you sure to delete: <b><span style='color : Red;'>%s </span></b>", true); |
||
| 170 | $ret .= $this->ld->getDefine($language, 'FORM_SURE_RENEW', "Are you sure to update: <b><span style='color : Red;'>%s </span></b>", true); |
||
| 171 | if (1 === $tableBroken) { |
||
| 172 | $ret .= $this->ld->getDefine($language, 'FORM_SURE_BROKEN', "Are you sure to notify as broken: <b><span style='color : Red;'>%s </span></b>", true); |
||
| 173 | } |
||
| 174 | $ret .= $this->ld->getDefine($language, 'INVALID_PARAM', 'Invalid parameter', false); |
||
| 175 | } |
||
| 176 | if (1 === $tableRate) { |
||
| 177 | $ret .= $this->ld->getAboveHeadDefines('Ratings'); |
||
| 178 | $ret .= $this->ld->getDefine($language, 'RATING_CURRENT_1', 'Rating: %c / %m (%t rating totally)'); |
||
| 179 | $ret .= $this->ld->getDefine($language, 'RATING_CURRENT_X', 'Rating: %c / %m (%t ratings totally)'); |
||
| 180 | $ret .= $this->ld->getDefine($language, 'RATING_CURRENT_SHORT_1', '%c (%t rating)'); |
||
| 181 | $ret .= $this->ld->getDefine($language, 'RATING_CURRENT_SHORT_X', '%c (%t ratings)'); |
||
| 182 | $ret .= $this->ld->getDefine($language, 'RATING1', '1 of 5'); |
||
| 183 | $ret .= $this->ld->getDefine($language, 'RATING2', '2 of 5'); |
||
| 184 | $ret .= $this->ld->getDefine($language, 'RATING3', '3 of 5'); |
||
| 185 | $ret .= $this->ld->getDefine($language, 'RATING4', '4 of 5'); |
||
| 186 | $ret .= $this->ld->getDefine($language, 'RATING5', '5 of 5'); |
||
| 187 | $ret .= $this->ld->getDefine($language, 'RATING_10_1', '1 of 10'); |
||
| 188 | $ret .= $this->ld->getDefine($language, 'RATING_10_2', '2 of 10'); |
||
| 189 | $ret .= $this->ld->getDefine($language, 'RATING_10_3', '3 of 10'); |
||
| 190 | $ret .= $this->ld->getDefine($language, 'RATING_10_4', '4 of 10'); |
||
| 191 | $ret .= $this->ld->getDefine($language, 'RATING_10_5', '5 of 10'); |
||
| 192 | $ret .= $this->ld->getDefine($language, 'RATING_10_6', '6 of 10'); |
||
| 193 | $ret .= $this->ld->getDefine($language, 'RATING_10_7', '7 of 10'); |
||
| 194 | $ret .= $this->ld->getDefine($language, 'RATING_10_8', '8 of 10'); |
||
| 195 | $ret .= $this->ld->getDefine($language, 'RATING_10_9', '9 of 10'); |
||
| 196 | $ret .= $this->ld->getDefine($language, 'RATING_10_10', '10 of 10'); |
||
| 197 | $ret .= $this->ld->getDefine($language, 'RATING_VOTE_BAD', 'Invalid vote'); |
||
| 198 | $ret .= $this->ld->getDefine($language, 'RATING_VOTE_ALREADY', 'You have already voted'); |
||
| 199 | $ret .= $this->ld->getDefine($language, 'RATING_VOTE_THANKS', 'Thank you for rating'); |
||
| 200 | $ret .= $this->ld->getDefine($language, 'RATING_NOPERM', "Sorry, you don't have permission to rate items", true); |
||
| 201 | $ret .= $this->ld->getDefine($language, 'RATING_LIKE', 'Like'); |
||
| 202 | $ret .= $this->ld->getDefine($language, 'RATING_DISLIKE', 'Dislike'); |
||
| 203 | $ret .= $this->ld->getDefine($language, 'RATING_ERROR1', 'Error: update base table failed!'); |
||
| 204 | } |
||
| 205 | if (1 === $tablePrint) { |
||
| 206 | $ret .= $this->ld->getAboveHeadDefines('Print'); |
||
| 207 | $ret .= $this->ld->getDefine($language, 'PRINT', 'Print'); |
||
| 208 | } |
||
| 209 | return $ret; |
||
| 210 | } |
||
| 248 |
Loading history...