ggoffy /
modulebuilder
| Conditions | 22 |
| Paths | 5240 |
| Total Lines | 116 |
| Code Lines | 98 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 167 | public function getLanguageAdminClass($language, $tables) |
||
| 168 | { |
||
| 169 | $ret = $this->ld->getAboveHeadDefines('Admin Classes'); |
||
| 170 | $fieldStatus = 0; |
||
| 171 | $fieldSampleListValue = 0; |
||
| 172 | $tableBroken = 0; |
||
| 173 | foreach (\array_keys($tables) as $t) { |
||
| 174 | $tableId = $tables[$t]->getVar('table_id'); |
||
| 175 | $tableMid = $tables[$t]->getVar('table_mid'); |
||
| 176 | $tableSoleName = $tables[$t]->getVar('table_solename'); |
||
| 177 | $tableBroken = $tables[$t]->getVar('table_broken'); |
||
| 178 | $ucfTableSoleName = \ucfirst($tableSoleName); |
||
| 179 | |||
| 180 | $fields = $this->getTableFields($tableMid, $tableId); |
||
| 181 | $fieldInForm = 0; |
||
| 182 | foreach (\array_keys($fields) as $f) { |
||
| 183 | if ($fieldInForm < $fields[$f]->getVar('field_inform')) { |
||
| 184 | $fieldInForm = $fields[$f]->getVar('field_inform'); |
||
| 185 | } |
||
| 186 | } |
||
| 187 | if (1 == $fieldInForm) { |
||
| 188 | $ret .= $this->ld->getAboveDefines("{$ucfTableSoleName} add/edit"); |
||
| 189 | $ret .= $this->ld->getDefine($language, "{$tableSoleName}_ADD", "Add {$ucfTableSoleName}"); |
||
| 190 | $ret .= $this->ld->getDefine($language, "{$tableSoleName}_EDIT", "Edit {$ucfTableSoleName}"); |
||
| 191 | } |
||
| 192 | $ret .= $this->ld->getAboveDefines("Elements of {$ucfTableSoleName}"); |
||
| 193 | |||
| 194 | foreach (\array_keys($fields) as $f) { |
||
| 195 | $fieldName = $fields[$f]->getVar('field_name'); |
||
| 196 | $fieldElement = $fields[$f]->getVar('field_element'); |
||
| 197 | $rpFieldName = $this->getRightString($fieldName); |
||
| 198 | if ($fieldElement >= Constants::FIRST_FIELDELEMENT_TABLE) { |
||
| 199 | $fieldElements = Modulebuilder\Helper::getInstance()->getHandler('Fieldelements')->get($fieldElement); |
||
| 200 | $fieldElementName = $fieldElements->getVar('fieldelement_name'); |
||
| 201 | $fieldNameDesc = mb_substr($fieldElementName, \mb_strrpos($fieldElementName, ':'), mb_strlen($fieldElementName)); |
||
| 202 | $fieldNameDesc = \str_replace(': ', '', $fieldNameDesc); |
||
| 203 | } else { |
||
| 204 | $fieldNameDesc = false !== mb_strpos($rpFieldName, '_') ? \str_replace('_', ' ', \ucfirst($rpFieldName)) : \ucfirst($rpFieldName); |
||
| 205 | } |
||
| 206 | $ret .= $this->ld->getDefine($language, $tableSoleName . '_' . $rpFieldName, $fieldNameDesc); |
||
| 207 | |||
| 208 | switch ($fieldElement) { |
||
| 209 | case 10: |
||
| 210 | $ret .= $this->ld->getDefine($language, $tableSoleName . '_' . $rpFieldName . '_UPLOADS', "{$fieldNameDesc} in frameworks images: %s"); |
||
| 211 | break; |
||
| 212 | case 12: |
||
| 213 | $ret .= $this->ld->getDefine($language, $tableSoleName . '_' . $rpFieldName . '_UPLOADS', "{$fieldNameDesc} in uploads"); |
||
| 214 | break; |
||
| 215 | case 11: |
||
| 216 | case 13: |
||
| 217 | case 14: |
||
| 218 | $ret .= $this->ld->getDefine($language, $tableSoleName . '_' . $rpFieldName . '_UPLOADS', "{$fieldNameDesc} in %s :"); |
||
| 219 | break; |
||
| 220 | case 16: |
||
| 221 | $fieldStatus++; |
||
| 222 | break; |
||
| 223 | case 20: |
||
| 224 | case 22: |
||
| 225 | $fieldSampleListValue++; |
||
| 226 | break; |
||
| 227 | } |
||
| 228 | if (16 === (int)$fieldElement) { |
||
| 229 | $fieldStatus++; |
||
| 230 | } |
||
| 231 | if (20 === (int)$fieldElement || 20 === (int)$fieldElement) { |
||
| 232 | $fieldSampleListValue++; |
||
| 233 | } |
||
| 234 | } |
||
| 235 | } |
||
| 236 | $ret .= $this->ld->getAboveDefines('General'); |
||
| 237 | $ret .= $this->ld->getDefine($language, 'FORM_UPLOAD', 'Upload file'); |
||
| 238 | $ret .= $this->ld->getDefine($language, 'FORM_UPLOAD_NEW', 'Upload new file: '); |
||
| 239 | $ret .= $this->ld->getDefine($language, 'FORM_UPLOAD_SIZE', 'Max file size: '); |
||
| 240 | $ret .= $this->ld->getDefine($language, 'FORM_UPLOAD_SIZE_MB', 'MB'); |
||
| 241 | $ret .= $this->ld->getDefine($language, 'FORM_UPLOAD_IMG_WIDTH', 'Max image width: '); |
||
| 242 | $ret .= $this->ld->getDefine($language, 'FORM_UPLOAD_IMG_HEIGHT', 'Max image height: '); |
||
| 243 | $ret .= $this->ld->getDefine($language, 'FORM_IMAGE_PATH', 'Files in %s :'); |
||
| 244 | $ret .= $this->ld->getDefine($language, 'FORM_ACTION', 'Action'); |
||
| 245 | $ret .= $this->ld->getDefine($language, 'FORM_EDIT', 'Modification'); |
||
| 246 | $ret .= $this->ld->getDefine($language, 'FORM_DELETE', 'Clear'); |
||
| 247 | if ($fieldStatus > 0) { |
||
| 248 | $ret .= $this->ld->getAboveDefines('Status'); |
||
| 249 | $ret .= $this->ld->getDefine($language, 'STATUS_NONE', 'No status'); |
||
| 250 | $ret .= $this->ld->getDefine($language, 'STATUS_OFFLINE', 'Offline'); |
||
| 251 | $ret .= $this->ld->getDefine($language, 'STATUS_SUBMITTED', 'Submitted'); |
||
| 252 | $ret .= $this->ld->getDefine($language, 'STATUS_APPROVED', 'Approved'); |
||
| 253 | $ret .= $this->ld->getDefine($language, 'STATUS_BROKEN', 'Broken'); |
||
| 254 | } |
||
| 255 | if ($tableBroken > 0) { |
||
| 256 | $ret .= $this->ld->getAboveDefines('Broken'); |
||
| 257 | $ret .= $this->ld->getDefine($language, 'BROKEN_RESULT', 'Broken items in table %s'); |
||
| 258 | $ret .= $this->ld->getDefine($language, 'BROKEN_NODATA', 'No broken items in table %s'); |
||
| 259 | $ret .= $this->ld->getDefine($language, 'BROKEN_TABLE', 'Table'); |
||
| 260 | $ret .= $this->ld->getDefine($language, 'BROKEN_KEY', 'Key field'); |
||
| 261 | $ret .= $this->ld->getDefine($language, 'BROKEN_KEYVAL', 'Key value'); |
||
| 262 | $ret .= $this->ld->getDefine($language, 'BROKEN_MAIN', 'Info main'); |
||
| 263 | } |
||
| 264 | if ($fieldSampleListValue > 0) { |
||
| 265 | $ret .= $this->ld->getAboveDefines('Sample List Values'); |
||
| 266 | $ret .= $this->ld->getDefine($language, 'LIST_1', 'Sample List Value 1'); |
||
| 267 | $ret .= $this->ld->getDefine($language, 'LIST_2', 'Sample List Value 2'); |
||
| 268 | $ret .= $this->ld->getDefine($language, 'LIST_3', 'Sample List Value 3'); |
||
| 269 | } |
||
| 270 | $ret .= $this->ld->getAboveDefines('Clone feature'); |
||
| 271 | $ret .= $this->ld->getDefine($language, 'CLONE', 'Clone'); |
||
| 272 | $ret .= $this->ld->getDefine($language, 'CLONE_DSC', 'Cloning a module has never been this easy! Just type in the name you want for it and hit submit button!'); |
||
| 273 | $ret .= $this->ld->getDefine($language, 'CLONE_TITLE', 'Clone %s'); |
||
| 274 | $ret .= $this->ld->getDefine($language, 'CLONE_NAME', 'Choose a name for the new module'); |
||
| 275 | $ret .= $this->ld->getDefine($language, 'CLONE_NAME_DSC', 'Do not use special characters! <br>Do not choose an existing module dirname or database table name!'); |
||
| 276 | $ret .= $this->ld->getDefine($language, 'CLONE_INVALIDNAME', 'ERROR: Invalid module name, please try another one!'); |
||
| 277 | $ret .= $this->ld->getDefine($language, 'CLONE_EXISTS', 'ERROR: Module name already taken, please try another one!'); |
||
| 278 | $ret .= $this->ld->getDefine($language, 'CLONE_CONGRAT', 'Congratulations! %s was sucessfully created!<br>You may want to make changes in language files.'); |
||
| 279 | $ret .= $this->ld->getDefine($language, 'CLONE_IMAGEFAIL', 'Attention, we failed creating the new module logo. Please consider modifying assets/images/logo_module.png manually!'); |
||
| 280 | $ret .= $this->ld->getDefine($language, 'CLONE_FAIL', 'Sorry, we failed in creating the new clone. Maybe you need to temporally set write permissions (CHMOD 777) to modules folder and try again.'); |
||
| 281 | |||
| 282 | return $ret; |
||
| 283 | } |
||
| 361 |
