gggeek / phpxmlrpc

tests/LoggerAwareTestCase.php

<?php

include_once __DIR__ . '/../lib/xmlrpc.inc';
include_once __DIR__ . '/../lib/xmlrpcs.inc';

include_once __DIR__ . '/parse_args.php';

include_once __DIR__ . '/PolyfillTestCase.php';

use PHPUnit\Runner\BaseTestRunner;

abstract class PhpXmlRpc_LoggerAwareTestCase extends PhpXmlRpc_PolyfillTestCase
{
    protected $args = array();

    protected $buffer = '';

    /**
     * Hide debug messages and errors unless we either are in debug mode or the test fails.
     * @return void
     */
    protected function set_up()
    {
        $this->args = argParser::getArgs();

        if ($this->args['DEBUG'] == 0) {
            $this->debugBuffer = '';

The property debugBuffer does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->errorBuffer = '';

The property errorBuffer does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            \PhpXmlRpc\PhpXmlRpc::setLogger($this);
        }
    }

    protected function tear_down()
    {
        if ($this->args['DEBUG'] > 0) {
            return;
        }

        // reset the logger to the default
        \PhpXmlRpc\PhpXmlRpc::setLogger(\PhpXmlRpc\Helper\Logger::instance());

        $status = $this->getStatus();
        if ($status == BaseTestRunner::STATUS_ERROR
            || $status == BaseTestRunner::STATUS_FAILURE) {
            echo $this->buffer;
        }
    }

    // logger API implementation

    public function debug($message, $context = array())

The parameter $context is not used and could be removed.

    {
        $this->buffer .= $message . "\n";
    }

    public function error($message, $context = array())

The parameter $context is not used and could be removed.

    {
        $this->buffer .= $message . "\n";
    }

    public function warning($message, $context = array())

The parameter $context is not used and could be removed.

    {
        $this->buffer .= $message . "\n";
    }
}