gggeek / phpxmlrpc

tests/10DemofilesTest.php

<?php

include_once __DIR__ . '/WebTestCase.php';

/**
 * Tests for php files in the 'demo' directory.
 *
 * @todo add execution of perl and python demos via usage of 'exec'
 */
class DemoFilesTest extends PhpXmlRpc_WebTestCase
{
    public function testVardemo()
    {
        $page = $this->request('?demo=vardemo.php');

The assignment to $page is dead and can be removed.

    }

    // *** client ***

    public function testAgeSort()
    {
        $page = $this->request('?demo=client/agesort.php');

The assignment to $page is dead and can be removed.

    }

    public function testCodegen()
    {
        $page = $this->request('?demo=client/codegen.php');

The assignment to $page is dead and can be removed.

    }

    public function testGetStateName()
    {
        $page = $this->request('?demo=client/getstatename.php');

The assignment to $page is dead and can be removed.

        $page = $this->request('?demo=client/getstatename.php', 'POST', array('stateno' => '1'));

array('stateno' => '1') of type array<string,string> is incompatible with the type string expected by parameter $payload of PhpXmlRpc_WebTestCase::request().

    }

    public function testLoggerInjection()
    {
        $page = $this->request('?demo=client/loggerinjection.php');

The assignment to $page is dead and can be removed.

    }

    public function testIntrospect()
    {
        $page = $this->request('?demo=client/introspect.php');

The assignment to $page is dead and can be removed.

    }

    public function testParallel()
    {
        $page = $this->request('?demo=client/parallel.php');

The assignment to $page is dead and can be removed.

    }

    public function testProxy()
    {
        $page = $this->request('?demo=client/proxy.php', 'GET', null, true);

The assignment to $page is dead and can be removed.

    }

    public function testWhich()
    {
        $page = $this->request('?demo=client/which.php');

The assignment to $page is dead and can be removed.

    }

    public function testWindowsCharset()
    {
        $page = $this->request('?demo=client/windowscharset.php');

The assignment to $page is dead and can be removed.

    }

    public function testWrap()
    {
        $page = $this->request('?demo=client/wrap.php');

The assignment to $page is dead and can be removed.

    }

    // *** servers ***

    public function testCodegenServer()
    {
        $page = $this->request('?demo=server/codegen.php');
        $this->assertStringContainsString('<name>faultCode</name>', $page);

It seems like $page can also be of type true; however, parameter $haystack of PHPUnit\Framework\Assert::assertStringContainsString() does only seem to accept string, maybe add an additional type check?

        $this->assertRegexp('#<int>10(5|3)</int>#', $page);

It seems like $page can also be of type true; however, parameter $string of PHPUnit\Framework\Assert::assertRegExp() does only seem to accept string, maybe add an additional type check?

        $c = $this->newClient('?demo=server/codegen.php');
        $r = $c->send(new \PhpXmlRpc\Request('CommentManager.getComments', array(
            new \PhpXmlRpc\Value('aCommentId')
        )));
        $this->assertEquals(0, $r->faultCode());
    }

    public function testDiscussServer()
    {
        $page = $this->request('?demo=server/discuss.php');
        $this->assertStringContainsString('<name>faultCode</name>', $page);

It seems like $page can also be of type true; however, parameter $haystack of PHPUnit\Framework\Assert::assertStringContainsString() does only seem to accept string, maybe add an additional type check?

        $this->assertRegexp('#<int>10(5|3)</int>#', $page);

It seems like $page can also be of type true; however, parameter $string of PHPUnit\Framework\Assert::assertRegExp() does only seem to accept string, maybe add an additional type check?

        $c = $this->newClient('?demo=server/discuss.php');

        $r = $c->send(new \PhpXmlRpc\Request('discuss.addComment', array(
            new \PhpXmlRpc\Value('aCommentId'),
            new \PhpXmlRpc\Value('aCommentUser'),
            new \PhpXmlRpc\Value('a Comment')
        )));
        $this->assertEquals(0, $r->faultCode());
        $this->assertGreaterThanOrEqual(1, $r->value()->scalarval());

        $r = $c->send(new \PhpXmlRpc\Request('discuss.getComments', array(
            new \PhpXmlRpc\Value('aCommentId')
        )));
        $this->assertEquals(0, $r->faultCode());
        $this->assertEquals(0, $r->faultCode());
        $this->assertGreaterThanOrEqual(1, count($r->value()));

It seems like $r->value() can also be of type string; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

    }

    public function testProxyServer()
    {
        /// @todo add a couple of proper xmlrpc calls, too
        $page = $this->request('?demo=server/proxy.php');
        $this->assertStringContainsString('<name>faultCode</name>', $page);

It seems like $page can also be of type true; however, parameter $haystack of PHPUnit\Framework\Assert::assertStringContainsString() does only seem to accept string, maybe add an additional type check?

        $this->assertRegexp('#<int>10(5|3)</int>#', $page);

It seems like $page can also be of type true; however, parameter $string of PHPUnit\Framework\Assert::assertRegExp() does only seem to accept string, maybe add an additional type check?

    }
}