Passed
Push — master ( ad2d4b...f50d88 )
by Gaetano
08:45
created
tests/01CharsetTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * @author JoakimLofgren
4 4
  */
5 5
 
6
-include_once __DIR__ . '/PolyfillTestCase.php';
6
+include_once __DIR__.'/PolyfillTestCase.php';
7 7
 
8 8
 use PhpXmlRpc\Helper\Charset;
9 9
 
@@ -48,10 +48,10 @@  discard block
 block discarded – undo
48 48
     public function testUtf8ToLatin1All()
49 49
     {
50 50
         $latinString = "\n\r\t";
51
-        for($i = 32; $i < 127; $i++) {
51
+        for ($i = 32; $i<127; $i++) {
52 52
             $latinString .= chr($i);
53 53
         }
54
-        for($i = 160; $i < 256; $i++) {
54
+        for ($i = 160; $i<256; $i++) {
55 55
             $latinString .= chr($i);
56 56
         }
57 57
 
Please login to merge, or discard this patch.
tests/03MessagesTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/LoggerAwareTestCase.php';
3
+include_once __DIR__.'/LoggerAwareTestCase.php';
4 4
 
5 5
 /**
6 6
  * Tests involving Requests and Responses, except for the parsing part
Please login to merge, or discard this patch.
tests/06EncoderTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/LoggerAwareTestCase.php';
3
+include_once __DIR__.'/LoggerAwareTestCase.php';
4 4
 
5 5
 /**
6 6
  * Tests involving automatic encoding/decoding of php values into xmlrpc values (the Encoder class).
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
         /// @todo it seems that old php versions can not automatically transform latin to utf8 upon xml parsing.
76 76
         ///       We should fix that, then re-enable this test
77 77
         if (version_compare(PHP_VERSION, '5.6.0', '>=')) {
78
-            $i = $e->decodeXml('<?xml version="1.0" encoding="ISO-8859-15" ?><value><string>' . $string . '</string></value>');
78
+            $i = $e->decodeXml('<?xml version="1.0" encoding="ISO-8859-15" ?><value><string>'.$string.'</string></value>');
79 79
             $this->assertEquals($string, $i->scalarVal());
80 80
         }
81 81
 
Please login to merge, or discard this patch.
demo/client/wrap.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 output('<html lang="en">
5 5
 <head><title>phpxmlrpc - Webservice wrapper demo</title></head>
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 $client->setOption(\PhpXmlRpc\Client::OPT_RETURN_TYPE, 'phpvals'); // let client give us back php values instead of xmlrpcvals
21 21
 $resp = $client->send(new PhpXmlRpc\Request('system.listMethods'));
22 22
 if ($resp->faultCode()) {
23
-    output("<p>Server methods list could not be retrieved: error {$resp->faultCode()} '" . htmlspecialchars($resp->faultString()) . "'</p>\n");
23
+    output("<p>Server methods list could not be retrieved: error {$resp->faultCode()} '".htmlspecialchars($resp->faultString())."'</p>\n");
24 24
 } else {
25 25
     output("<p>Server methods list retrieved, now wrapping it up...</p>\n<ul>\n");
26 26
     flush();
@@ -32,9 +32,9 @@  discard block
 block discarded – undo
32 32
         if ($methodName == 'examples.getStateName') {
33 33
             $callable = $wrapper->wrapXmlrpcMethod($client, $methodName);
34 34
             if ($callable) {
35
-                output("<li>Remote server method " . htmlspecialchars($methodName) . " wrapped into php function</li>\n");
35
+                output("<li>Remote server method ".htmlspecialchars($methodName)." wrapped into php function</li>\n");
36 36
             } else {
37
-                output("<li>Remote server method " . htmlspecialchars($methodName) . " could not be wrapped!</li>\n");
37
+                output("<li>Remote server method ".htmlspecialchars($methodName)." could not be wrapped!</li>\n");
38 38
             }
39 39
             break;
40 40
         }
Please login to merge, or discard this patch.
tests/LoggerAwareTestCase.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-include_once __DIR__ . '/../lib/xmlrpc.inc';
4
-include_once __DIR__ . '/../lib/xmlrpcs.inc';
3
+include_once __DIR__.'/../lib/xmlrpc.inc';
4
+include_once __DIR__.'/../lib/xmlrpcs.inc';
5 5
 
6
-include_once __DIR__ . '/parse_args.php';
6
+include_once __DIR__.'/parse_args.php';
7 7
 
8
-include_once __DIR__ . '/PolyfillTestCase.php';
8
+include_once __DIR__.'/PolyfillTestCase.php';
9 9
 
10 10
 use PHPUnit\Runner\BaseTestRunner;
11 11
 
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 
33 33
     protected function tear_down()
34 34
     {
35
-        if ($this->args['DEBUG'] > 0) {
35
+        if ($this->args['DEBUG']>0) {
36 36
             return;
37 37
         }
38 38
 
@@ -50,16 +50,16 @@  discard block
 block discarded – undo
50 50
 
51 51
     public function debug($message, $context = array())
52 52
     {
53
-        $this->buffer .= $message . "\n";
53
+        $this->buffer .= $message."\n";
54 54
     }
55 55
 
56 56
     public function error($message, $context = array())
57 57
     {
58
-        $this->buffer .= $message . "\n";
58
+        $this->buffer .= $message."\n";
59 59
     }
60 60
 
61 61
     public function warning($message, $context = array())
62 62
     {
63
-        $this->buffer .= $message . "\n";
63
+        $this->buffer .= $message."\n";
64 64
     }
65 65
 }
Please login to merge, or discard this patch.
demo/client/loggerinjection.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 /**
5 5
  * Demoing how to inject a custom logger for use by the library
@@ -21,17 +21,17 @@  discard block
 block discarded – undo
21 21
     // logger API
22 22
     public function debug($message, $context = array())
23 23
     {
24
-        $this->debugBuffer .= $message . "\n";
24
+        $this->debugBuffer .= $message."\n";
25 25
     }
26 26
 
27 27
     public function error($message, $context = array())
28 28
     {
29
-        $this->errorBuffer .= $message . "\n";
29
+        $this->errorBuffer .= $message."\n";
30 30
     }
31 31
 
32 32
     public function warning($message, $context = array())
33 33
     {
34
-        $this->warningBuffer .= $message . "\n";
34
+        $this->warningBuffer .= $message."\n";
35 35
     }
36 36
 
37 37
     public function getDebug()
@@ -62,8 +62,8 @@  discard block
 block discarded – undo
62 62
 
63 63
 $input = array(
64 64
     array('name' => 'Dave', 'age' => 24),
65
-    array('name' => 'Edd',  'age' => 45),
66
-    array('name' => 'Joe',  'age' => 37),
65
+    array('name' => 'Edd', 'age' => 45),
66
+    array('name' => 'Joe', 'age' => 37),
67 67
     array('name' => 'Fred', 'age' => 27),
68 68
 );
69 69
 
@@ -85,6 +85,6 @@  discard block
 block discarded – undo
85 85
 $response = $client->send($request);
86 86
 output("Response received.<br>");
87 87
 
88
-output("The client error info is:<pre>\n" . $logger->getError() . "\n</pre>");
89
-output("The client warning info is:<pre>\n" . $logger->getWarning() . "\n</pre>");
90
-output("The client debug info is:<pre>\n" . $logger->getDebug() . "\n</pre>");
88
+output("The client error info is:<pre>\n".$logger->getError()."\n</pre>");
89
+output("The client warning info is:<pre>\n".$logger->getWarning()."\n</pre>");
90
+output("The client debug info is:<pre>\n".$logger->getDebug()."\n</pre>");
Please login to merge, or discard this patch.
demo/client/symfony/ClientController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
         if ($response->faultCode()) {
29 29
             throw new HttpException(502, $response->faultString());
30 30
         } else {
31
-            return new Response("<html><body>State number $stateNo is: " . $response->value()->scalarVal() . '</body></html>');
31
+            return new Response("<html><body>State number $stateNo is: ".$response->value()->scalarVal().'</body></html>');
32 32
         }
33 33
     }
34 34
 }
Please login to merge, or discard this patch.
lib/xmlrpc.inc 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
         $val = reset($ar);
130 130
         $typ = key($ar);
131 131
 
132
-        return '<value>' . $this->serializeData($typ, $val) . "</value>\n";
132
+        return '<value>'.$this->serializeData($typ, $val)."</value>\n";
133 133
         //}
134 134
     }
135 135
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
         // preserve back compatibility
149 149
 
150 150
         if (is_array($b)) {
151
-            foreach($b as $id => $cont) {
151
+            foreach ($b as $id => $cont) {
152 152
                 $b[$id] = $cont->scalarVal();
153 153
             }
154 154
         }
@@ -156,10 +156,10 @@  discard block
 block discarded – undo
156 156
         // add support for structures directly encoding php objects
157 157
         if (is_object($b)) {
158 158
             $t = get_object_vars($b);
159
-            foreach($t as $id => $cont) {
159
+            foreach ($t as $id => $cont) {
160 160
                 $t[$id] = $cont->scalarVal();
161 161
             }
162
-            foreach($t as $id => $cont) {
162
+            foreach ($t as $id => $cont) {
163 163
                 @$b->$id = $cont;
164 164
             }
165 165
         }
@@ -201,17 +201,17 @@  discard block
 block discarded – undo
201 201
 /* Expose as global functions the ones which are now class methods */
202 202
 
203 203
 /// Wrong speling, but we are adamant on backwards compatibility!
204
-function xmlrpc_encode_entitites($data, $srcEncoding='', $destEncoding='')
204
+function xmlrpc_encode_entitites($data, $srcEncoding = '', $destEncoding = '')
205 205
 {
206 206
     return Charset::instance()->encodeEntities($data, $srcEncoding, $destEncoding);
207 207
 }
208 208
 
209
-function iso8601_encode($timeT, $utc=0)
209
+function iso8601_encode($timeT, $utc = 0)
210 210
 {
211 211
     return Date::iso8601Encode($timeT, $utc);
212 212
 }
213 213
 
214
-function iso8601_decode($iDate, $utc=0)
214
+function iso8601_decode($iDate, $utc = 0)
215 215
 {
216 216
     return Date::iso8601Decode($iDate, $utc);
217 217
 }
@@ -221,25 +221,25 @@  discard block
 block discarded – undo
221 221
     return Http::decodeChunked($buffer);
222 222
 }
223 223
 
224
-function php_xmlrpc_decode($xmlrpcVal, $options=array())
224
+function php_xmlrpc_decode($xmlrpcVal, $options = array())
225 225
 {
226 226
     $encoder = new Encoder();
227 227
     return $encoder->decode($xmlrpcVal, $options);
228 228
 }
229 229
 
230
-function php_xmlrpc_encode($phpVal, $options=array())
230
+function php_xmlrpc_encode($phpVal, $options = array())
231 231
 {
232 232
     $encoder = new Encoder();
233 233
     return $encoder->encode($phpVal, $options);
234 234
 }
235 235
 
236
-function php_xmlrpc_decode_xml($xmlVal, $options=array())
236
+function php_xmlrpc_decode_xml($xmlVal, $options = array())
237 237
 {
238 238
     $encoder = new Encoder();
239 239
     return $encoder->decodeXml($xmlVal, $options);
240 240
 }
241 241
 
242
-function guess_encoding($httpHeader='', $xmlChunk='', $encodingPrefs=null)
242
+function guess_encoding($httpHeader = '', $xmlChunk = '', $encodingPrefs = null)
243 243
 {
244 244
     return XMLParser::guessEncoding($httpHeader, $xmlChunk, $encodingPrefs);
245 245
 }
Please login to merge, or discard this patch.
demo/client/parallel.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once __DIR__ . "/_prepend.php";
2
+require_once __DIR__."/_prepend.php";
3 3
 
4 4
 use PhpXmlRpc\Encoder;
5 5
 use PhpXmlRpc\Client;
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
         $handles = array();
34 34
         $curl = curl_multi_init();
35 35
 
36
-        foreach($requests as $k => $req) {
36
+        foreach ($requests as $k => $req) {
37 37
             $req->setDebug($this->debug);
38 38
             $handle = $this->createCurlHandle($req, $method, $this->server, $this->port, $this->path, $opts);
39 39
             curl_multi_add_handle($curl, $handle);
@@ -43,20 +43,20 @@  discard block
 block discarded – undo
43 43
         $running = 0;
44 44
         do {
45 45
             curl_multi_exec($curl, $running);
46
-        } while($running > 0);
46
+        } while ($running>0);
47 47
 
48 48
         $responses = array();
49 49
         $errors = array();
50
-        foreach($handles as $k => $h) {
50
+        foreach ($handles as $k => $h) {
51 51
             $responses[$k] = curl_multi_getcontent($handles[$k]);
52 52
 
53
-            if ($this->debug > 1) {
53
+            if ($this->debug>1) {
54 54
                 $message = "---CURL INFO---\n";
55 55
                 foreach (curl_getinfo($h) as $name => $val) {
56 56
                     if (is_array($val)) {
57 57
                         $val = implode("\n", $val);
58 58
                     }
59
-                    $message .= $name . ': ' . $val . "\n";
59
+                    $message .= $name.': '.$val."\n";
60 60
                 }
61 61
                 $message .= '---END---';
62 62
                 $this->getLogger()->debugMessage($message);
@@ -71,9 +71,9 @@  discard block
 block discarded – undo
71 71
         }
72 72
         curl_multi_close($curl);
73 73
 
74
-        foreach($responses as $k => $resp) {
74
+        foreach ($responses as $k => $resp) {
75 75
             if (!$resp) {
76
-                $responses[$k] = new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'] . ': ' . $errors[$k]);
76
+                $responses[$k] = new Response(0, PhpXmlRpc::$xmlrpcerr['curl_fail'], PhpXmlRpc::$xmlrpcstr['curl_fail'].': '.$errors[$k]);
77 77
             } else {
78 78
                 $responses[$k] = $requests[$k]->parseResponse($resp, true, $this->return_type);
79 79
             }
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 $value = $encoder->encode($data, array('auto_dates'));
94 94
 $req = new Request('interopEchoTests.echoValue', array($value));
95 95
 $reqs = array();
96
-for ($i = 0; $i < $num_tests; $i++) {
96
+for ($i = 0; $i<$num_tests; $i++) {
97 97
     $reqs[] = $req;
98 98
 }
99 99
 
@@ -102,40 +102,40 @@  discard block
 block discarded – undo
102 102
 // avoid storing http info in the responses, to make the checksums comparable
103 103
 $client->setDebug(-1);
104 104
 
105
-echo "Making $num_tests calls to method interopEchoTests.echoValue on server " . XMLRPCSERVER . " ...\n";
105
+echo "Making $num_tests calls to method interopEchoTests.echoValue on server ".XMLRPCSERVER." ...\n";
106 106
 flush();
107 107
 
108
-$client->setOption(Client::OPT_NO_MULTICALL,  true);
108
+$client->setOption(Client::OPT_NO_MULTICALL, true);
109 109
 $t = microtime(true);
110 110
 $resp = $client->send($reqs);
111
-$t = microtime(true) - $t;
112
-echo "Sequential send: " . sprintf('%.3f', $t) . " secs.\n";
113
-echo "Response checksum: " . md5(var_export($resp, true)) . "\n";
111
+$t = microtime(true)-$t;
112
+echo "Sequential send: ".sprintf('%.3f', $t)." secs.\n";
113
+echo "Response checksum: ".md5(var_export($resp, true))."\n";
114 114
 flush();
115 115
 
116 116
 if (strpos(XMLRPCSERVER, 'http://') === 0) {
117
-    $client->setOption(Client::OPT_USE_CURL,  Client::USE_CURL_ALWAYS);
117
+    $client->setOption(Client::OPT_USE_CURL, Client::USE_CURL_ALWAYS);
118 118
     $t = microtime(true);
119 119
     $resp = $client->send($reqs);
120
-    $t = microtime(true) - $t;
121
-    echo "Sequential send, curl (w. keepalive): " . sprintf('%.3f', $t) . " secs.\n";
122
-    echo "Response checksum: " . md5(var_export($resp, true)) . "\n";
120
+    $t = microtime(true)-$t;
121
+    echo "Sequential send, curl (w. keepalive): ".sprintf('%.3f', $t)." secs.\n";
122
+    echo "Response checksum: ".md5(var_export($resp, true))."\n";
123 123
     flush();
124 124
 }
125 125
 
126 126
 $t = microtime(true);
127 127
 $resp = $client->sendParallel($reqs);
128
-$t = microtime(true) - $t;
129
-echo "Parallel send: " . sprintf('%.3f', $t) . " secs.\n";
130
-echo "Response checksum: " . md5(var_export($resp, true)) . "\n";
128
+$t = microtime(true)-$t;
129
+echo "Parallel send: ".sprintf('%.3f', $t)." secs.\n";
130
+echo "Response checksum: ".md5(var_export($resp, true))."\n";
131 131
 flush();
132 132
 
133 133
 $client->setOption(Client::OPT_NO_MULTICALL, false);
134 134
 // make sure we don't reuse the keepalive handle
135
-$client->setOption(Client::OPT_USE_CURL,  Client::USE_CURL_NEVER);
135
+$client->setOption(Client::OPT_USE_CURL, Client::USE_CURL_NEVER);
136 136
 $t = microtime(true);
137 137
 $resp = $client->send($reqs);
138
-$t = microtime(true) - $t;
139
-echo "Multicall send: " . sprintf('%.3f', $t) . " secs.\n";
140
-echo "Response checksum: " . md5(var_export($resp, true)) . "\n";
138
+$t = microtime(true)-$t;
139
+echo "Multicall send: ".sprintf('%.3f', $t)." secs.\n";
140
+echo "Response checksum: ".md5(var_export($resp, true))."\n";
141 141
 flush();
Please login to merge, or discard this patch.