View GitHub Repository phpxmlrpc

Schedule Inspection
Subscribe
Passed
Pull Request — master (#84)
by
unknown
10:39
created
Status
Category
Toggle Patches
demo/server/proxy.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -9,7 +9,7 @@  discard block
 
 block discarded – undo
9 9 
  * @license code licensed under the BSD License: see file license.txt
10 10 
  */
11 11
12 
-require_once __DIR__ . "/_prepend.php";
12 
+require_once __DIR__."/_prepend.php";
13 13
14 14 
 /**
15 15 
  * Forward an xmlrpc request to another server, and return to client the response received.
 
@@ -29,7 +29,7 @@  discard block
 
 block discarded – undo
29 29 
     $url = $encoder->decode($req->getParam(0));
30 30 
     $client = new PhpXmlRpc\Client($url);
31 31
32 
-    if ($req->getNumParams() > 3) {
32 
+    if ($req->getNumParams()>3) {
33 33 
         // we have to set some options onto the client.
34 34 
         // Note that if we do not untaint the received values, warnings might be generated...
35 35 
         $options = $encoder->decode($req->getParam(3));
 
@@ -49,7 +49,7 @@  discard block
 
 block discarded – undo
49 49 
                     $client->setSSLVerifyPeer($val);
50 50 
                     break;
51 51 
                 case 'Timeout':
52 
-                    $timeout = (integer)$val;
52 
+                    $timeout = (integer) $val;
53 53 
                     break;
54 54 
             } // switch
55 55 
         }
 
@@ -67,7 +67,7 @@  discard block
 
 block discarded – undo
67 67 
     }
68 68
69 69 
     // add debug info into response we give back to caller
70 
-    PhpXmlRpc\Server::xmlrpc_debugmsg("Sending to server $url the payload: " . $req->serialize());
70 
+    PhpXmlRpc\Server::xmlrpc_debugmsg("Sending to server $url the payload: ".$req->serialize());
71 71
72 72 
     return $client->send($req, $timeout);
73 73 
 }
 
@@ -88,4 +88,4 @@  discard block
 
 block discarded – undo
88 88 
     )
89 89 
 );
90 90
91 
-require_once __DIR__ . "/_append.php";
91 
+require_once __DIR__."/_append.php";
Please login to merge, or discard this patch.
demo/client/introspect.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch 
@@ -1,4 +1,4 @@  discard block
 
 block discarded – undo
1 
-<?php require_once __DIR__ . "/_prepend.php"; ?><html lang="en">
1 
+<?php require_once __DIR__."/_prepend.php"; ?><html lang="en">
2 2 
 <head><title>xmlrpc - Introspect demo</title></head>
3 3 
 <body>
4 4 
 <h1>Introspect demo</h1>
 
@@ -10,14 +10,14 @@  discard block
 
 block discarded – undo
10 10 
 function display_error($r)
11 11 
 {
12 12 
     print "An error occurred: ";
13 
-    print "Code: " . $r->faultCode()
14 
-        . " Reason: '" . $r->faultString() . "'<br/>";
13 
+    print "Code: ".$r->faultCode()
14 
+        . " Reason: '".$r->faultString()."'<br/>";
15 15 
 }
16 16
17 17 
 $client = new PhpXmlRpc\Client(XMLRPCSERVER);
18 18
19 19 
 // First off, let's retrieve the list of methods available on the remote server
20 
-print "<h3>methods available at http://" . $client->server . $client->path . "</h3>\n";
20 
+print "<h3>methods available at http://".$client->server.$client->path."</h3>\n";
21 21 
 $req = new PhpXmlRpc\Request('system.listMethods');
22 22 
 $resp = $client->send($req);
23 23 
 
@@ -28,7 +28,7 @@  discard block
 
 block discarded – undo
28 28
29 29 
     // Then, retrieve the signature and help text of each available method
30 30 
     foreach ($v as $methodName) {
31 
-        print "<h4>" . $methodName->scalarval() . "</h4>\n";
31 
+        print "<h4>".$methodName->scalarval()."</h4>\n";
32 32 
         // build messages first, add params later
33 33 
         $m1 = new PhpXmlRpc\Request('system.methodHelp');
34 34 
         $m2 = new PhpXmlRpc\Request('system.methodSignature');
 
@@ -59,13 +59,13 @@  discard block
 
 block discarded – undo
59 59 
             if ($val->kindOf() == "array") {
60 60 
                 foreach ($val as $x) {
61 61 
                     $ret = $x[0];
62 
-                    print "<code>" . htmlspecialchars($ret->scalarval()) . " "
63 
-                        . htmlspecialchars($methodName->scalarval()) . "(";
64 
-                    if ($x->count() > 1) {
65 
-                        for ($k = 1; $k < $x->count(); $k++) {
62 
+                    print "<code>".htmlspecialchars($ret->scalarval())." "
63 
+                        . htmlspecialchars($methodName->scalarval())."(";
64 
+                    if ($x->count()>1) {
65 
+                        for ($k = 1; $k<$x->count(); $k++) {
66 66 
                             $y = $x[$k];
67 67 
                             print htmlspecialchars($y->scalarval());
68 
-                            if ($k < $x->count() - 1) {
68 
+                            if ($k<$x->count()-1) {
69 69 
                                 print ", ";
70 70 
                             }
71 71 
                         }
 
@@ -81,4 +81,4 @@  discard block
 
 block discarded – undo
81 81 
 }
82 82 
 ?>
83 83 
 </body>
84 
-</html><?php require_once __DIR__ . "/_append.php"; ?>
84 
+</html><?php require_once __DIR__."/_append.php"; ?>
Please login to merge, or discard this patch.
demo/client/getstatename.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch 
@@ -1,4 +1,4 @@  discard block
 
 block discarded – undo
1 
-<?php require_once __DIR__ . "/_prepend.php"; ?><html lang="en">
1 
+<?php require_once __DIR__."/_prepend.php"; ?><html lang="en">
2 2 
 <head><title>xmlrpc - Getstatename demo</title></head>
3 3 
 <body>
4 4 
 <h1>Getstatename demo</h1>
 
@@ -11,32 +11,32 @@  discard block
 
 block discarded – undo
11 11 
 <?php
12 12
13 13 
 if (isset($_POST["stateno"]) && $_POST["stateno"] != "") {
14 
-    $stateNo = (integer)$_POST["stateno"];
14 
+    $stateNo = (integer) $_POST["stateno"];
15 15 
     $encoder = new PhpXmlRpc\Encoder();
16 16 
     $req = new PhpXmlRpc\Request('examples.getStateName',
17 17 
         array($encoder->encode($stateNo))
18 18 
     );
19 
-    print "Sending the following request:<pre>\n\n" . htmlentities($req->serialize()) . "\n\n</pre>Debug info of server data follows...\n\n";
19 
+    print "Sending the following request:<pre>\n\n".htmlentities($req->serialize())."\n\n</pre>Debug info of server data follows...\n\n";
20 20 
     $client = new PhpXmlRpc\Client(XMLRPCSERVER);
21 21 
     $client->setDebug(1);
22 22 
     $r = $client->send($req);
23 23 
     if (!$r->faultCode()) {
24 24 
         $v = $r->value();
25 
-        print "<br/>State number <b>" . $stateNo . "</b> is <b>"
26 
-            . htmlspecialchars($encoder->decode($v)) . "</b><br/><br/>";
25 
+        print "<br/>State number <b>".$stateNo."</b> is <b>"
26 
+            . htmlspecialchars($encoder->decode($v))."</b><br/><br/>";
27 27 
     } else {
28 28 
         print "An error occurred: ";
29 
-        print "Code: " . htmlspecialchars($r->faultCode())
30 
-            . " Reason: '" . htmlspecialchars($r->faultString()) . "'</pre><br/>";
29 
+        print "Code: ".htmlspecialchars($r->faultCode())
30 
+            . " Reason: '".htmlspecialchars($r->faultString())."'</pre><br/>";
31 31 
     }
32 32 
 } else {
33 33 
     $stateNo = "";
34 34 
 }
35 35
36 36 
 print "<form action=\"getstatename.php\" method=\"POST\">
37 
-<input name=\"stateno\" value=\"" . $stateNo . "\"><input type=\"submit\" value=\"go\" name=\"submit\"></form>
37 
+<input name=\"stateno\" value=\"" . $stateNo."\"><input type=\"submit\" value=\"go\" name=\"submit\"></form>
38 38 
 <p>Enter a state number to query its name</p>";
39 39
40 40 
 ?>
41 41 
 </body>
42 
-</html><?php require_once __DIR__ . "/_append.php"; ?>
42 
+</html><?php require_once __DIR__."/_append.php"; ?>
Please login to merge, or discard this patch.
demo/client/agesort.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch 
@@ -1,4 +1,4 @@  discard block
 
 block discarded – undo
1 
-<?php require_once __DIR__ . "/_prepend.php"; ?><html lang="en">
1 
+<?php require_once __DIR__."/_prepend.php"; ?><html lang="en">
2 2 
 <head><title>xmlrpc - Agesort demo</title></head>
3 3 
 <body>
4 4 
 <h1>Agesort demo</h1>
 
@@ -13,7 +13,7 @@  discard block
 
 block discarded – undo
13 13 
 $inAr = array("Dave" => 24, "Edd" => 45, "Joe" => 37, "Fred" => 27);
14 14 
 print "This is the input data:<br/><pre>";
15 15 
 foreach ($inAr as $key => $val) {
16 
-    print $key . ", " . $val . "\n";
16 
+    print $key.", ".$val."\n";
17 17 
 }
18 18 
 print "</pre>";
19 19 
 
@@ -29,7 +29,7 @@  discard block
 
 block discarded – undo
29 29 
     );
30 30 
 }
31 31 
 $v = new PhpXmlRpc\Value($p, "array");
32 
-print "Encoded into xmlrpc format it looks like this: <pre>\n" . htmlentities($v->serialize()) . "</pre>\n";
32 
+print "Encoded into xmlrpc format it looks like this: <pre>\n".htmlentities($v->serialize())."</pre>\n";
33 33
34 34 
 // create client and message objects
35 35 
 $req = new PhpXmlRpc\Request('examples.sortByAge', array($v));
 
@@ -49,17 +49,17 @@  discard block
 
 block discarded – undo
49 49 
     foreach ($value as $struct) {
50 50 
         $name = $struct["name"];
51 51 
         $age = $struct["age"];
52 
-        print htmlspecialchars($name->scalarval()) . ", " . htmlspecialchars($age->scalarval()) . "\n";
52 
+        print htmlspecialchars($name->scalarval()).", ".htmlspecialchars($age->scalarval())."\n";
53 53 
     }
54 54
55 
-    print "<hr/>For nerds: I got this value back<br/><pre>" .
56 
-        htmlentities($resp->serialize()) . "</pre><hr/>\n";
55 
+    print "<hr/>For nerds: I got this value back<br/><pre>".
56 
+        htmlentities($resp->serialize())."</pre><hr/>\n";
57 57 
 } else {
58 58 
     print "An error occurred:<pre>";
59 
-    print "Code: " . htmlspecialchars($resp->faultCode()) .
60 
-        "\nReason: '" . htmlspecialchars($resp->faultString()) . '\'</pre><hr/>';
59 
+    print "Code: ".htmlspecialchars($resp->faultCode()).
60 
+        "\nReason: '".htmlspecialchars($resp->faultString()).'\'</pre><hr/>';
61 61 
 }
62 62
63 63 
 ?>
64 64 
 </body>
65 
-</html><?php require_once __DIR__ . "/_append.php"; ?>
65 
+</html><?php require_once __DIR__."/_append.php"; ?>
Please login to merge, or discard this patch.
demo/client/wrap.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -1,4 +1,4 @@  discard block
 
 block discarded – undo
1 
-<?php require_once __DIR__ . "/_prepend.php"; ?><html lang="en">
1 
+<?php require_once __DIR__."/_prepend.php"; ?><html lang="en">
2 2 
 <head><title>xmlrpc - Webservice wrappper demo</title></head>
3 3 
 <body>
4 4 
 <h1>Webservice wrappper demo</h1>
 
@@ -17,7 +17,7 @@  discard block
 
 block discarded – undo
17 17 
 $client->return_type = 'phpvals'; // let client give us back php values instead of xmlrpcvals
18 18 
 $resp = $client->send(new PhpXmlRpc\Request('system.listMethods'));
19 19 
 if ($resp->faultCode()) {
20 
-    echo "<p>Server methods list could not be retrieved: error {$resp->faultCode()} '" . htmlspecialchars($resp->faultString()) . "'</p>\n";
20 
+    echo "<p>Server methods list could not be retrieved: error {$resp->faultCode()} '".htmlspecialchars($resp->faultString())."'</p>\n";
21 21 
 } else {
22 22 
     echo "<p>Server methods list retrieved, now wrapping it up...</p>\n<ul>\n";
23 23 
     flush();
 
@@ -29,9 +29,9 @@  discard block
 
 block discarded – undo
29 29 
         if ($methodName == 'examples.getStateName') {
30 30 
             $callable = $wrapper->wrapXmlrpcMethod($client, $methodName);
31 31 
             if ($callable) {
32 
-                echo "<li>Remote server method " . htmlspecialchars($methodName) . " wrapped into php function</li>\n";
32 
+                echo "<li>Remote server method ".htmlspecialchars($methodName)." wrapped into php function</li>\n";
33 33 
             } else {
34 
-                echo "<li>Remote server method " . htmlspecialchars($methodName) . " could not be wrapped!</li>\n";
34 
+                echo "<li>Remote server method ".htmlspecialchars($methodName)." could not be wrapped!</li>\n";
35 35 
             }
36 36 
             break;
37 37 
         }
 
@@ -49,4 +49,4 @@  discard block
 
 block discarded – undo
49 49 
 }
50 50 
 ?>
51 51 
 </body>
52 
-</html><?php require_once __DIR__ . "/_append.php"; ?>
52 
+</html><?php require_once __DIR__."/_append.php"; ?>
Please login to merge, or discard this patch.
demo/client/proxy.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,4 +1,4 @@  discard block
 
 block discarded – undo
1 
-<?php require_once __DIR__ . "/_prepend.php"; ?><html lang="en">
1 
+<?php require_once __DIR__."/_prepend.php"; ?><html lang="en">
2 2 
 <head><title>xmlrpc - Proxy demo</title></head>
3 3 
 <body>
4 4 
 <h1>proxy demo</h1>
 
@@ -56,4 +56,4 @@  discard block
 
 block discarded – undo
56 56
57 57 
 echo "State $stateNo is ".htmlspecialchars($stateName);
58 58
59 
-require_once __DIR__ . "/_append.php";
59 
+require_once __DIR__."/_append.php";
Please login to merge, or discard this patch.
demo/client/which.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -1,4 +1,4 @@  discard block
 
 block discarded – undo
1 
-<?php require_once __DIR__ . "/_prepend.php"; ?><html lang="en">
1 
+<?php require_once __DIR__."/_prepend.php"; ?><html lang="en">
2 2 
 <head><title>xmlrpc - Which toolkit demo</title></head>
3 3 
 <body>
4 4 
 <h1>Which toolkit demo</h1>
 
@@ -15,15 +15,15 @@  discard block
 
 block discarded – undo
15 15 
     $value = $encoder->decode($resp->value());
16 16 
     print "Toolkit info:<br/>\n";
17 17 
     print "<pre>";
18 
-    print "name: " . htmlspecialchars($value["toolkitName"]) . "\n";
19 
-    print "version: " . htmlspecialchars($value["toolkitVersion"]) . "\n";
20 
-    print "docs: " . htmlspecialchars($value["toolkitDocsUrl"]) . "\n";
21 
-    print "os: " . htmlspecialchars($value["toolkitOperatingSystem"]) . "\n";
18 
+    print "name: ".htmlspecialchars($value["toolkitName"])."\n";
19 
+    print "version: ".htmlspecialchars($value["toolkitVersion"])."\n";
20 
+    print "docs: ".htmlspecialchars($value["toolkitDocsUrl"])."\n";
21 
+    print "os: ".htmlspecialchars($value["toolkitOperatingSystem"])."\n";
22 22 
     print "</pre>";
23 23 
 } else {
24 24 
     print "An error occurred: ";
25 
-    print "Code: " . htmlspecialchars($resp->faultCode()) . " Reason: '" . htmlspecialchars($resp->faultString()) . "'\n";
25 
+    print "Code: ".htmlspecialchars($resp->faultCode())." Reason: '".htmlspecialchars($resp->faultString())."'\n";
26 26 
 }
27 27 
 ?>
28 28 
 </body>
29 
-</html><?php require_once __DIR__ . "/_append.php"; ?>
29 
+</html><?php require_once __DIR__."/_append.php"; ?>
Please login to merge, or discard this patch.
demo/server/_prepend.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -14,7 +14,7 @@  discard block
 
 block discarded – undo
14 14 
 }
15 15
16 16 
 // Use the custom class autoloader. These two lines not needed when the phpxmlrpc library is installed using Composer
17 
-include_once __DIR__ . '/../../src/Autoloader.php';
17 
+include_once __DIR__.'/../../src/Autoloader.php';
18 18 
 PhpXmlRpc\Autoloader::register();
19 19
20 20 
 // Out-of-band information: let the client manipulate the server operations.
 
@@ -26,5 +26,5 @@  discard block
 
 block discarded – undo
26 26 
         chmod($GLOBALS['PHPUNIT_COVERAGE_DATA_DIRECTORY'], 0777);
27 27 
     }
28 28
29 
-    include_once __DIR__ . "/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
29 
+    include_once __DIR__."/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/prepend.php";
30 30 
 }
Please login to merge, or discard this patch.
demo/client/_append.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -3,5 +3,5 @@
 
 block discarded – undo
3 3 
 // Out-of-band information: let the client manipulate the server operations.
4 4 
 // We do this to help the testsuite script: do not reproduce in production!
5 5 
 if (isset($_COOKIE['PHPUNIT_SELENIUM_TEST_ID']) && extension_loaded('xdebug')) {
6 
-    include_once __DIR__ . "/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
6 
+    include_once __DIR__."/../../vendor/phpunit/phpunit-selenium/PHPUnit/Extensions/SeleniumCommon/append.php";
7 7 
 }
Please login to merge, or discard this patch.